Merge branch 'jacopo-beschi/gitlab-ce-29712-unnecessary-wait-for-ajax'

See merge request !10567

Signed-off-by: Rémy Coutable <remy@rymai.me>

changelogs/unreleased/29712-unnecessary-wait-for-ajax.yml

+---
+title: Remove unnecessary test helpers includes
+merge_request: 10567
+author: Jacopo Beschi @jacopo-beschi

spec/controllers/dashboard/todos_controller_spec.rb

 require 'spec_helper'
 describe Dashboard::TodosController do
-  include ApiHelpers
-
   let(:user) { create(:user) }
   let(:author)  { create(:user) }
   let(:project) { create(:empty_project) }

spec/controllers/projects/builds_controller_spec.rb

 require 'spec_helper'
 describe Projects::BuildsController do
-  include ApiHelpers
-
   let(:user) { create(:user) }
   let(:project) { create(:empty_project, :public) }

spec/controllers/projects/environments_controller_spec.rb

 require 'spec_helper'
 describe Projects::EnvironmentsController do
-  include ApiHelpers
-
   let(:user) { create(:user) }
   let(:project) { create(:empty_project) }

spec/controllers/projects/merge_requests_controller_spec.rb

 require 'spec_helper'
 describe Projects::MergeRequestsController do
-  include ApiHelpers
-
   let(:project) { create(:project) }
   let(:user)    { create(:user) }
   let(:merge_request) { create(:merge_request_with_diffs, target_project: project, source_project: project) }

spec/controllers/projects/pipelines_controller_spec.rb

 require 'spec_helper'
 describe Projects::PipelinesController do
-  include ApiHelpers
-
   let(:user) { create(:user) }
   let(:project) { create(:empty_project, :public) }

spec/controllers/projects/todo_controller_spec.rb

 require('spec_helper')
 describe Projects::TodosController do
-  include ApiHelpers
-
   let(:user)          { create(:user) }
   let(:project)       { create(:empty_project) }
   let(:issue)         { create(:issue, project: project) }

spec/features/admin/admin_labels_spec.rb

 require 'spec_helper'
 RSpec.describe 'admin issues labels' do
-  include WaitForAjax
-
   let!(:bug_label) { Label.create(title: 'bug', template: true) }
   let!(:feature_label) { Label.create(title: 'feature', template: true) }

spec/features/admin/admin_users_spec.rb

 require 'spec_helper'
 describe "Admin::Users", feature: true do
-  include WaitForAjax
-
   let!(:user) do
     create(:omniauth_user, provider: 'twitter', extern_uid: '123456')
   end

spec/features/auto_deploy_spec.rb

 require 'spec_helper'
 describe 'Auto deploy' do
-  include WaitForAjax
-
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository) }

spec/features/boards/add_issues_modal_spec.rb

 require 'rails_helper'
 describe 'Issue Boards add issue modal', :feature, :js do
-  include WaitForAjax
   include WaitForVueResource
   let(:project) { create(:empty_project, :public) }

spec/features/boards/boards_spec.rb

 require 'rails_helper'
 describe 'Issue Boards', feature: true, js: true do
-  include WaitForAjax
   include WaitForVueResource
   include DragTo

spec/features/boards/new_issue_spec.rb

 require 'rails_helper'
 describe 'Issue Boards new issue', feature: true, js: true do
-  include WaitForAjax
   include WaitForVueResource
   let(:project) { create(:empty_project, :public) }

spec/features/boards/sidebar_spec.rb

 require 'rails_helper'
 describe 'Issue Boards', feature: true, js: true do
-  include WaitForAjax
   include WaitForVueResource
   let(:user)         { create(:user) }

spec/features/calendar_spec.rb

 require 'spec_helper'
 feature 'Contributions Calendar', :feature, :js do
-  include WaitForAjax
-
   let(:user) { create(:user) }
   let(:contributed_project) { create(:empty_project, :public) }
   let(:issue_note) { create(:note, project: contributed_project) }

spec/features/cycle_analytics_spec.rb

 require 'spec_helper'
 feature 'Cycle Analytics', feature: true, js: true do
-  include WaitForAjax
-
   let(:user) { create(:user) }
   let(:guest) { create(:user) }
   let(:project) { create(:project, :repository) }

spec/features/dashboard/datetime_on_tooltips_spec.rb

 require 'spec_helper'
 feature 'Tooltips on .timeago dates', feature: true, js: true do
-  include WaitForAjax
-
   let(:user)            { create(:user) }
   let(:project)         { create(:project, name: 'test', namespace: user.namespace) }
   let(:created_date)    { Date.yesterday.to_time }

spec/features/dashboard/groups_list_spec.rb

 require 'spec_helper'
 describe 'Dashboard Groups page', js: true, feature: true do
-  include WaitForAjax
-
   let!(:user) { create :user }
   let!(:group) { create(:group) }
   let!(:nested_group) { create(:group, :nested) }

spec/features/dashboard/project_member_activity_index_spec.rb

 require 'spec_helper'
 feature 'Project member activity', feature: true, js: true do
-  include WaitForAjax
-
   let(:user)            { create(:user) }
   let(:project)         { create(:empty_project, :public, name: 'x', namespace: user.namespace) }

spec/features/expand_collapse_diffs_spec.rb

 require 'spec_helper'
 feature 'Expand and collapse diffs', js: true, feature: true do
-  include WaitForAjax
-
   let(:branch) { 'expand-collapse-diffs' }
   let(:project) { create(:project, :repository) }