Enable the Layout/ExtraSpacing cop

Signed-off-by: Rémy Coutable <remy@rymai.me>

spec/services/system_note_service_spec.rb

@@ -819,7 +819,7 @@ describe SystemNoteService do
       end
       context 'for issues' do
-        let(:issue)           { create(:issue, project: project) }
+        let(:issue) { create(:issue, project: project) }
         it "creates comment" do
           result = described_class.cross_reference(jira_issue, issue, author)
@@ -1131,7 +1131,7 @@ describe SystemNoteService do
     end
     context 'across different projects' do
-      let(:other_project)  { create(:project) }
+      let(:other_project) { create(:project) }
       let(:canonical_issue) { create(:issue, project: other_project) }
       it_behaves_like 'a system note' do
@@ -1156,7 +1156,7 @@ describe SystemNoteService do
     end
     context 'across different projects' do
-      let(:other_project)  { create(:project) }
+      let(:other_project) { create(:project) }
       let(:duplicate_issue) { create(:issue, project: other_project) }
       it_behaves_like 'a system note' do
@@ -1168,7 +1168,7 @@ describe SystemNoteService do
   end
   describe '.discussion_lock' do
-    subject { described_class.discussion_lock(noteable, author)  }
+    subject { described_class.discussion_lock(noteable, author) }
     context 'discussion unlocked' do
       it_behaves_like 'a system note' do

spec/services/todo_service_spec.rb

@@ -457,7 +457,7 @@ describe TodoService do
       end
       context 'on commit' do
-        let(:project)  { create(:project, :repository) }
+        let(:project) { create(:project, :repository) }
         it 'creates a todo for each valid mentioned user when leaving a note on commit' do
           service.new_note(note_on_commit, john_doe)

spec/services/todos/destroy/entity_leave_service_spec.rb

@@ -173,10 +173,10 @@ describe Todos::Destroy::EntityLeaveService do
           let(:subproject) { create(:project, group: subgroup) }
           let(:subproject2) { create(:project, group: subgroup2) }
-          let!(:todo_subproject_user)  { create(:todo, user: user, project: subproject) }
-          let!(:todo_subproject2_user)  { create(:todo, user: user, project: subproject2) }
-          let!(:todo_subgroup_user)    { create(:todo, user: user, group: subgroup) }
-          let!(:todo_subgroup2_user)    { create(:todo, user: user, group: subgroup2) }
+          let!(:todo_subproject_user) { create(:todo, user: user, project: subproject) }
+          let!(:todo_subproject2_user) { create(:todo, user: user, project: subproject2) }
+          let!(:todo_subgroup_user) { create(:todo, user: user, group: subgroup) }
+          let!(:todo_subgroup2_user) { create(:todo, user: user, group: subgroup2) }
           let!(:todo_subproject_user2) { create(:todo, user: user2, project: subproject) }
           let!(:todo_subpgroup_user2)  { create(:todo, user: user2, group: subgroup) }

spec/services/todos/destroy/group_private_service_spec.rb

@@ -40,7 +40,7 @@ describe Todos::Destroy::GroupPrivateService do
         let(:parent_member)  { create(:user) }
         let(:subgroup_member)  { create(:user) }
-        let(:subgproject_member)  { create(:user) }
+        let(:subgproject_member) { create(:user) }
         let!(:todo_parent_member)     { create(:todo, user: parent_member, group: group) }
         let!(:todo_subgroup_member)   { create(:todo, user: subgroup_member, group: group) }

spec/services/users/migrate_to_ghost_user_service_spec.rb

@@ -6,7 +6,7 @@ describe Users::MigrateToGhostUserService do
   let(:service)    { described_class.new(user) }
   context "migrating a user's associated records to the ghost user" do
-    context 'issues'  do
+    context 'issues' do
       context 'deleted user is present as both author and edited_user' do
         include_examples "migrating a deleted user's associated records to the ghost user", Issue, [:author, :last_edited_by] do
           let(:created_record) do

spec/services/web_hook_service_spec.rb

@@ -61,7 +61,7 @@ describe WebHookService do
     end
     context 'when auth credentials are present' do
-      let(:url)  {'https://example.org'}
+      let(:url) {'https://example.org'}
       let(:project_hook) { create(:project_hook, url: 'https://demo:demo@example.org/') }
       it 'uses the credentials' do
@@ -76,7 +76,7 @@ describe WebHookService do
     end
     context 'when auth credentials are partial present' do
-      let(:url)  {'https://example.org'}
+      let(:url) {'https://example.org'}
       let(:project_hook) { create(:project_hook, url: 'https://demo@example.org/') }
       it 'uses the credentials anyways' do

spec/support/features/resolving_discussions_in_issues_shared_examples.rb

@@ -5,7 +5,7 @@ shared_examples 'creating an issue for a discussion' do
     expect(title_field.value).to include(merge_request.title)
   end
-  it 'has a mention of the discussion in the description'  do
+  it 'has a mention of the discussion in the description' do
     description_field = page.find_field('issue[description]')
     expect(description_field.value).to include(discussion.first_note.note)

spec/support/helpers/graphql_helpers.rb

@@ -149,7 +149,7 @@ module GraphqlHelpers
     # - List
     # - String!
     # - String
-    field_type = field_type.of_type  while field_type.respond_to?(:of_type)
+    field_type = field_type.of_type while field_type.respond_to?(:of_type)
     field_type
   end

spec/support/helpers/login_helpers.rb

@@ -157,7 +157,7 @@ module LoginHelpers
     env['omniauth.error.strategy'] = strategy
   end
-  def stub_omniauth_saml_config(messages,  context: Rails.application)
+  def stub_omniauth_saml_config(messages, context: Rails.application)
     set_devise_mapping(context: context)
     routes = Rails.application.routes
     routes.disable_clear_and_finalize = true

spec/support/redis/redis_shared_examples.rb

 RSpec.shared_examples "redis_shared_examples" do
   include StubENV
-  let(:test_redis_url)  { "redis://redishost:#{redis_port}"}
+  let(:test_redis_url) { "redis://redishost:#{redis_port}"}
   before do
     stub_env(environment_config_file_name, Rails.root.join(config_file_name))
@@ -76,7 +76,7 @@ RSpec.shared_examples "redis_shared_examples" do
     context 'when yml file with env variable' do
       let(:config_file_name) { config_with_environment_variable_inside }
-      before  do
+      before do
         stub_env(config_env_variable_url, test_redis_url)
       end

spec/support/shared_examples/malicious_regexp_shared_examples.rb

 require 'timeout'
 shared_examples 'malicious regexp' do
-  let(:malicious_text)  { 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!' }
+  let(:malicious_text) { 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!' }
   let(:malicious_regexp) { '(?i)^(([a-z])+.)+[A-Z]([a-z])+$' }
   it 'takes under a second' do

spec/support/shared_examples/mentionable_shared_examples.rb

@@ -8,8 +8,8 @@ shared_context 'mentionable context' do
   let(:project) { subject.project }
   let(:author)  { subject.author }
-  let(:mentioned_issue)  { create(:issue, project: project) }
-  let!(:mentioned_mr)     { create(:merge_request, source_project: project) }
+  let(:mentioned_issue) { create(:issue, project: project) }
+  let!(:mentioned_mr) { create(:merge_request, source_project: project) }
   let(:mentioned_commit) { project.commit("HEAD~1") }
   let(:ext_proj)   { create(:project, :public, :repository) }

spec/support/shared_examples/url_validator_examples.rb

 RSpec.shared_examples 'url validator examples' do |protocols|
-  let(:validator) { described_class.new(attributes: [:link_url],  **options) }
+  let(:validator) { described_class.new(attributes: [:link_url], **options) }
   let!(:badge) { build(:badge, link_url: 'http://www.example.com') }
   subject { validator.validate_each(badge, :link_url, badge.link_url) }

spec/uploaders/file_uploader_spec.rb

@@ -4,7 +4,7 @@ describe FileUploader do
   let(:group) { create(:group, name: 'awesome') }
   let(:project) { create(:project, :legacy_storage, namespace: group, name: 'project') }
   let(:uploader) { described_class.new(project) }
-  let(:upload)  { double(model: project, path: 'secret/foo.jpg') }
+  let(:upload) { double(model: project, path: 'secret/foo.jpg') }
   subject { uploader }

spec/uploaders/import_export_uploader_spec.rb

@@ -4,7 +4,7 @@ describe ImportExportUploader do
   let(:model) { build_stubbed(:import_export_upload) }
   let(:upload) { create(:upload, model: model) }
-  subject { described_class.new(model, :import_file)  }
+  subject { described_class.new(model, :import_file) }
   context "object_store is REMOTE" do
     before do

spec/workers/prune_old_events_worker_spec.rb

@@ -5,8 +5,8 @@ describe PruneOldEventsWorker do
     let(:user) { create(:user) }
     let!(:expired_event) { create(:event, :closed, author: user, created_at: 25.months.ago) }
-    let!(:not_expired_1_day_event) { create(:event, :closed, author: user,  created_at: 1.day.ago) }
-    let!(:not_expired_13_month_event) { create(:event, :closed, author: user,  created_at: 13.months.ago) }
+    let!(:not_expired_1_day_event) { create(:event, :closed, author: user, created_at: 1.day.ago) }
+    let!(:not_expired_13_month_event) { create(:event, :closed, author: user, created_at: 13.months.ago) }
     let!(:not_expired_2_years_event) { create(:event, :closed, author: user, created_at: 2.years.ago) }
     it 'prunes events older than 2 years' do