Enable the Layout/ExtraSpacing cop

Signed-off-by: Rémy Coutable <remy@rymai.me>

lib/gitlab/middleware/go.rb

@@ -111,7 +111,7 @@ module Gitlab
       def project_for_paths(paths, request)
         project = Project.where_full_path_in(paths).first
-        return unless  Ability.allowed?(current_user(request, project), :read_project, project)
+        return unless Ability.allowed?(current_user(request, project), :read_project, project)
         project
       end

lib/gitlab/pages_client.rb

@@ -103,7 +103,7 @@ module Gitlab
       end
       def write_token(new_token)
-        Tempfile.open(File.basename(token_path), File.dirname(token_path),  encoding: 'ascii-8bit') do |f|
+        Tempfile.open(File.basename(token_path), File.dirname(token_path), encoding: 'ascii-8bit') do |f|
           f.write(new_token)
           f.close
           File.link(f.path, token_path)

lib/tasks/gitlab/bulk_add_permission.rake

@@ -14,7 +14,7 @@ namespace :gitlab do
     end
     desc "GitLab | Add a specific user to all projects (as a developer)"
-    task :user_to_projects, [:email] => :environment  do |t, args|
+    task :user_to_projects, [:email] => :environment do |t, args|
       user = User.find_by(email: args.email)
       project_ids = Project.pluck(:id)
       puts "Importing #{user.email} users into #{project_ids.size} projects"
@@ -22,7 +22,7 @@ namespace :gitlab do
     end
     desc "GitLab | Add all users to all groups (admin users are added as owners)"
-    task all_users_to_all_groups: :environment  do |t, args|
+    task all_users_to_all_groups: :environment do |t, args|
       user_ids = User.where(admin: false).pluck(:id)
       admin_ids = User.where(admin: true).pluck(:id)
       groups = Group.all
@@ -36,7 +36,7 @@ namespace :gitlab do
     end
     desc "GitLab | Add a specific user to all groups (as a developer)"
-    task :user_to_groups, [:email] => :environment  do |t, args|
+    task :user_to_groups, [:email] => :environment do |t, args|
       user = User.find_by_email args.email
       groups = Group.all
       puts "Importing #{user.email} users into #{groups.size} groups"

qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Create' do
     describe 'Merge request creation' do
-      it 'user creates a new merge request'  do
+      it 'user creates a new merge request' do
         gitlab_account_username = "@#{Runtime::User.username}"
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
@@ -49,7 +49,7 @@ module QA
   end
   describe 'creates a merge request', :smoke do
-    it 'user creates a new merge request'  do
+    it 'user creates a new merge request' do
       Runtime::Browser.visit(:gitlab, Page::Main::Login)
       Page::Main::Login.act { sign_in_using_credentials }

qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Create' do
     describe 'Merge request rebasing' do
-      it 'user rebases source branch of merge request'  do
+      it 'user rebases source branch of merge request' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
         Page::Main::Login.act { sign_in_using_credentials }

qa/qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Create' do
     describe 'Merge request squashing' do
-      it 'user squashes commits while merging'  do
+      it 'user squashes commits while merging' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
         Page::Main::Login.perform(&:sign_in_using_credentials)

qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Create' do
     describe 'Git push over HTTP', :ldap_no_tls do
-      it 'user using a personal access token pushes code to the repository'  do
+      it 'user using a personal access token pushes code to the repository' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
         Page::Main::Login.perform(&:sign_in_using_credentials)

qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Create' do
     describe 'Push mirror a repository over HTTP' do
-      it 'configures and syncs a (push) mirrored repository'  do
+      it 'configures and syncs a (push) mirrored repository' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
         Page::Main::Login.perform(&:sign_in_using_credentials)

qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb

@@ -3,7 +3,7 @@
 module QA
   context 'Create' do
     describe 'Git push over HTTP', :ldap_no_tls do
-      it 'user pushes code to the repository'  do
+      it 'user pushes code to the repository' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
         Page::Main::Login.act { sign_in_using_credentials }

spec/bin/changelog_spec.rb

@@ -80,7 +80,7 @@ describe 'bin/changelog' do
       end
     end
-    describe '.read_type'  do
+    describe '.read_type' do
       let(:type) { '1' }
       it 'reads type from $stdin' do

spec/controllers/application_controller_spec.rb

@@ -423,7 +423,7 @@ describe ApplicationController do
         enforce_terms
       end
-      it 'redirects if the user did not accept the terms'  do
+      it 'redirects if the user did not accept the terms' do
         get :index
         expect(response).to have_gitlab_http_status(302)

spec/controllers/boards/issues_controller_spec.rb

@@ -229,7 +229,7 @@ describe Boards::IssuesController do
       post :create, params: {
                       board_id: board.to_param,
                       list_id: list.to_param,
-                      issue: { title: title,  project_id: project.id }
+                      issue: { title: title, project_id: project.id }
                     },
                     format: :json
     end

spec/controllers/concerns/checks_collaboration_spec.rb

@@ -22,7 +22,7 @@ describe ChecksCollaboration do
       end
     end
-    it 'is true if the user can push to the project'  do
+    it 'is true if the user can push to the project' do
       project.add_developer(user)
       expect(helper.can_collaborate_with_project?(project)).to be_truthy

spec/controllers/groups/children_controller_spec.rb

@@ -110,7 +110,7 @@ describe Groups::ChildrenController do
           matched_project_1 = create(:project, :public, namespace: shared_subgroup, name: 'mobile-soc')
           l2_subgroup = create(:group, :public, parent: shared_subgroup, path: 'broadcom')
-          l3_subgroup = create(:group, :public,  parent: l2_subgroup, path: 'wifi-group')
+          l3_subgroup = create(:group, :public, parent: l2_subgroup, path: 'wifi-group')
           matched_project_2 = create(:project, :public, namespace: l3_subgroup, name: 'mobile')
           get :index, params: { group_id: group.to_param, filter: 'mobile' }, format: :json
@@ -289,7 +289,7 @@ describe Groups::ChildrenController do
       end
       context 'with subgroups and projects', :nested_groups do
-        let!(:first_page_subgroups) { create_list(:group,  per_page, :public,  parent: group) }
+        let!(:first_page_subgroups) { create_list(:group, per_page, :public, parent: group) }
         let!(:other_subgroup) { create(:group, :public, parent: group) }
         let!(:next_page_projects) { create_list(:project, per_page, :public, namespace: group) }
@@ -306,7 +306,7 @@ describe Groups::ChildrenController do
         end
         context 'with a mixed first page' do
-          let!(:first_page_subgroups) { [create(:group,  :public,  parent: group)] }
+          let!(:first_page_subgroups) { [create(:group, :public, parent: group)] }
           let!(:first_page_projects) { create_list(:project, per_page, :public, namespace: group) }
           it 'correctly calculates the counts' do

spec/controllers/profiles/avatars_controller_spec.rb

 require 'spec_helper'
 describe Profiles::AvatarsController do
-  let(:user)    { create(:user, avatar: fixture_file_upload("spec/fixtures/dk.png")) }
+  let(:user) { create(:user, avatar: fixture_file_upload("spec/fixtures/dk.png")) }
   before do
     sign_in(user)

spec/controllers/projects/commit_controller_spec.rb

@@ -5,7 +5,7 @@ describe Projects::CommitController do
   set(:user)     { create(:user) }
   let(:commit)   { project.commit("master") }
   let(:master_pickable_sha) { '7d3b0f7cff5f37573aea97cebfd5692ea1689924' }
-  let(:master_pickable_commit)  { project.commit(master_pickable_sha) }
+  let(:master_pickable_commit) { project.commit(master_pickable_sha) }
   before do
     sign_in(user)

spec/controllers/projects/merge_requests_controller_spec.rb

@@ -253,8 +253,8 @@ describe Projects::MergeRequestsController do
     end
     context 'there is no source project' do
-      let(:project)       { create(:project, :repository) }
-      let(:forked_project)  { fork_project_with_submodules(project) }
+      let(:project) { create(:project, :repository) }
+      let(:forked_project) { fork_project_with_submodules(project) }
       let!(:merge_request) { create(:merge_request, source_project: forked_project, source_branch: 'add-submodule-version-bump', target_branch: 'master', target_project: project) }
       before do
@@ -884,7 +884,7 @@ describe Projects::MergeRequestsController do
   end
   describe 'POST #rebase' do
-    let(:viewer)        { user }
+    let(:viewer) { user }
     def post_rebase
       post :rebase, params: { namespace_id: project.namespace, project_id: project, id: merge_request }

spec/controllers/projects/pipelines_controller_spec.rb

@@ -50,7 +50,7 @@ describe Projects::PipelinesController do
       end
     end
-    context 'when using legacy stages', :request_store  do
+    context 'when using legacy stages', :request_store do
       before do
         stub_feature_flags(ci_pipeline_persisted_stages: false)
       end

spec/controllers/projects/serverless/functions_controller_spec.rb

@@ -87,7 +87,7 @@ describe Projects::Serverless::FunctionsController do
     end
     it 'has data' do
-      get :index, params: params({ format:  :json })
+      get :index, params: params({ format: :json })
       expect(response).to have_gitlab_http_status(200)

spec/controllers/projects_controller_spec.rb

@@ -456,7 +456,7 @@ describe ProjectsController do
     end
     context "when the project is forked" do
-      let(:project)      { create(:project, :repository) }
+      let(:project) { create(:project, :repository) }
       let(:forked_project) { fork_project(project, nil, repository: true) }
       let(:merge_request) do
         create(:merge_request,