Merge branch 'master' into docs_refactor

lib/banzai/filter/external_issue_reference_filter.rb

-require 'banzai'
-
 module Banzai
   module Filter
     # HTML filter that replaces external issue tracker references with links.

lib/banzai/filter/external_link_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 module Banzai

lib/banzai/filter/gollum_tags_filter.rb

+require 'banzai'
+require 'html/pipeline/filter'
+
+module Banzai
+  module Filter
+    # HTML Filter for parsing Gollum's tags in HTML. It's only parses the
+    # following tags:
+    #
+    # - Link to internal pages:
+    #
+    #   * [[Bug Reports]]
+    #   * [[How to Contribute|Contributing]]
+    #
+    # - Link to external resources:
+    #
+    #   * [[http://en.wikipedia.org/wiki/Git_(software)]]
+    #   * [[Git|http://en.wikipedia.org/wiki/Git_(software)]]
+    #
+    # - Link internal images, the special attributes will be ignored:
+    #
+    #   * [[images/logo.png]]
+    #   * [[images/logo.png|alt=Logo]]
+    #
+    # - Link external images, the special attributes will be ignored:
+    #
+    #   * [[http://example.com/images/logo.png]]
+    #   * [[http://example.com/images/logo.png|alt=Logo]]
+    #
+    # Based on Gollum::Filter::Tags
+    #
+    # Context options:
+    #   :project_wiki (required) - Current project wiki.
+    #
+    class GollumTagsFilter < HTML::Pipeline::Filter
+      include ActionView::Helpers::TagHelper
+
+      # Pattern to match tags content that should be parsed in HTML.
+      #
+      # Gollum's tags have been made to resemble the tags of other markups,
+      # especially MediaWiki. The basic syntax is:
+      #
+      # [[tag]]
+      #
+      # Some tags will accept attributes which are separated by pipe
+      # symbols.Some attributes must precede the tag and some must follow it:
+      #
+      # [[prefix-attribute|tag]]
+      # [[tag|suffix-attribute]]
+      #
+      # See https://github.com/gollum/gollum/wiki
+      #
+      # Rubular: http://rubular.com/r/7dQnE5CUCH
+      TAGS_PATTERN = %r{\[\[(.+?)\]\]}
+
+      # Pattern to match allowed image extensions
+      ALLOWED_IMAGE_EXTENSIONS = %r{.+(jpg|png|gif|svg|bmp)\z}i
+
+      def call
+        search_text_nodes(doc).each do |node|
+          content = node.content
+
+          next unless content.match(TAGS_PATTERN)
+
+          html = process_tag($1)
+
+          if html && html != node.content
+            node.replace(html)
+          end
+        end
+
+        doc
+      end
+
+      private
+
+      # Process a single tag into its final HTML form.
+      #
+      # tag - The String tag contents (the stuff inside the double brackets).
+      #
+      # Returns the String HTML version of the tag.
+      def process_tag(tag)
+        parts = tag.split('|')
+
+        return if parts.size.zero?
+
+        process_image_tag(parts) || process_page_link_tag(parts)
+      end
+
+      # Attempt to process the tag as an image tag.
+      #
+      # tag - The String tag contents (the stuff inside the double brackets).
+      #
+      # Returns the String HTML if the tag is a valid image tag or nil
+      # if it is not.
+      def process_image_tag(parts)
+        content = parts[0].strip
+
+        return unless image?(content)
+
+        if url?(content)
+          path = content
+        elsif file = project_wiki.find_file(content)
+          path = ::File.join project_wiki_base_path, file.path
+        end
+
+        if path
+          content_tag(:img, nil, src: path)
+        end
+      end
+
+      def image?(path)
+        path =~ ALLOWED_IMAGE_EXTENSIONS
+      end
+
+      def url?(path)
+        path.start_with?(*%w(http https))
+      end
+
+      # Attempt to process the tag as a page link tag.
+      #
+      # tag - The String tag contents (the stuff inside the double brackets).
+      #
+      # Returns the String HTML if the tag is a valid page link tag or nil
+      # if it is not.
+      def process_page_link_tag(parts)
+        if parts.size == 1
+          url = parts[0].strip
+        else
+          name, url = *parts.compact.map(&:strip)
+        end
+
+        content_tag(:a, name || url, href: url)
+      end
+
+      def project_wiki
+        context[:project_wiki]
+      end
+
+      def project_wiki_base_path
+        project_wiki && project_wiki.wiki_base_path
+      end
+
+      # Ensure that a :project_wiki key exists in context
+      #
+      # Note that while the key might exist, its value could be nil!
+      def validate
+        needs :project_wiki
+      end
+    end
+  end
+end

lib/banzai/filter/issue_reference_filter.rb

-require 'banzai'
-
 module Banzai
   module Filter
     # HTML filter that replaces issue references with links. References to

lib/banzai/filter/label_reference_filter.rb

-require 'banzai'
-
 module Banzai
   module Filter
     # HTML filter that replaces label references with links.

lib/banzai/filter/markdown_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 module Banzai

lib/banzai/filter/merge_request_reference_filter.rb

-require 'banzai'
-
 module Banzai
   module Filter
     # HTML filter that replaces merge request references with links. References

lib/banzai/filter/redactor_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 module Banzai

lib/banzai/filter/reference_filter.rb

 require 'active_support/core_ext/string/output_safety'
-require 'banzai'
 require 'html/pipeline/filter'
 module Banzai
@@ -133,7 +132,7 @@ module Banzai
           next unless link && text
-          link = URI.decode(link)
+          link = CGI.unescape(link)
           # Ignore ending punctionation like periods or commas
           next unless link == text && text =~ /\A#{pattern}/
@@ -170,7 +169,7 @@ module Banzai
           text = node.text
           next unless link && text
-          link = URI.decode(link)
+          link = CGI.unescape(link)
           next unless link && link =~ /\A#{pattern}\z/
           html = yield link, text

lib/banzai/filter/reference_gatherer_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 module Banzai

lib/banzai/filter/relative_link_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 require 'uri'

lib/banzai/filter/sanitization_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 require 'html/pipeline/sanitization_filter'

lib/banzai/filter/snippet_reference_filter.rb

-require 'banzai'
-
 module Banzai
   module Filter
     # HTML filter that replaces snippet references with links. References to

lib/banzai/filter/syntax_highlight_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 require 'rouge/plugins/redcarpet'

lib/banzai/filter/table_of_contents_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 module Banzai

lib/banzai/filter/task_list_filter.rb

-require 'banzai'
 require 'task_list/filter'
 module Banzai

lib/banzai/filter/upload_link_filter.rb

-require 'banzai'
 require 'html/pipeline/filter'
 require 'uri'

lib/banzai/filter/user_reference_filter.rb

-require 'banzai'
-
 module Banzai
   module Filter
     # HTML filter that replaces user or group references with links.

lib/banzai/lazy_reference.rb

-require 'banzai'
-
 module Banzai
   class LazyReference
     def self.load(refs)

lib/banzai/pipeline.rb

-require 'banzai'
-
 module Banzai
   module Pipeline
     def self.[](name)