Merge branch 'even-more-frozen-string-lib' into 'master'

Enable even more frozen string in lib/**/*.rb

See merge request gitlab-org/gitlab-ce!22206

.rubocop.yml

@@ -50,7 +50,8 @@ Style/FrozenStringLiteralComment:
     - 'danger/**/*'
     - 'db/**/*'
     - 'ee/**/*'
-    - 'lib/**/*'
+    - 'lib/gitlab/**/*'
+    - 'lib/tasks/**/*'
     - 'qa/**/*'
     - 'rubocop/**/*'
     - 'scripts/**/*'

changelogs/unreleased/even-more-frozen-string-lib.yml

+---
+title: Enable even more frozen string in lib/**/*.rb
+merge_request:
+author: gfyoung
+type: performance

lib/generators/rails/post_deployment_migration/post_deployment_migration_generator.rb

+# frozen_string_literal: true
+
 require 'rails/generators'
 module Rails

lib/gitaly/server.rb

+# frozen_string_literal: true
+
 module Gitaly
   class Server
     def self.all

lib/google_api/auth.rb

+# frozen_string_literal: true
+
 module GoogleApi
   class Auth
     attr_reader :access_token, :redirect_uri, :state

lib/google_api/cloud_platform/client.rb

+# frozen_string_literal: true
+
 require 'google/apis/compute_v1'
 require 'google/apis/container_v1'
 require 'google/apis/cloudbilling_v1'

lib/haml_lint/inline_javascript.rb

-unless Rails.env.production? # rubocop:disable Naming/FileName
+# rubocop:disable Naming/FileName
+# frozen_string_literal: true
+
+unless Rails.env.production?
   require 'haml_lint/haml_visitor'
   require 'haml_lint/linter'
   require 'haml_lint/linter_registry'

lib/json_web_token/rsa_token.rb

+# frozen_string_literal: true
+
 module JSONWebToken
   class RSAToken < Token
     attr_reader :key_file

lib/json_web_token/token.rb

+# frozen_string_literal: true
+
 module JSONWebToken
   class Token
     attr_accessor :issuer, :subject, :audience, :id

lib/mattermost/client.rb

+# frozen_string_literal: true
+
 module Mattermost
   ClientError = Class.new(Mattermost::Error)

lib/mattermost/command.rb

+# frozen_string_literal: true
+
 module Mattermost
   class Command < Client
     def create(params)

lib/mattermost/error.rb

+# frozen_string_literal: true
+
 module Mattermost
   Error = Class.new(StandardError)
 end

lib/mattermost/session.rb

+# frozen_string_literal: true
+
 module Mattermost
   class NoSessionError < Mattermost::Error
     def message

lib/mattermost/team.rb

+# frozen_string_literal: true
+
 module Mattermost
   class Team < Client
     # Returns all teams that the current user is a member of

lib/microsoft_teams/activity.rb

+# frozen_string_literal: true
+
 module MicrosoftTeams
   class Activity
     def initialize(title:, subtitle:, text:, image:)

lib/microsoft_teams/notifier.rb

+# frozen_string_literal: true
+
 module MicrosoftTeams
   class Notifier
     def initialize(webhook)

lib/object_storage/direct_upload.rb

+# frozen_string_literal: true
+
 module ObjectStorage
   #
   # The DirectUpload c;ass generates a set of presigned URLs

lib/omni_auth/strategies/bitbucket.rb

+# frozen_string_literal: true
+
 require 'omniauth-oauth2'
 module OmniAuth

lib/omni_auth/strategies/jwt.rb

+# frozen_string_literal: true
+
 require 'omniauth'
 require 'jwt'

lib/peek/rblineprof/custom_controller_helpers.rb

+# frozen_string_literal: true
+
 module Peek
   module Rblineprof
     module CustomControllerHelpers
@@ -41,7 +43,7 @@ module Peek
             ]
           end.sort_by{ |a,b,c,d,e,f| -f }
-          output = "<div class='modal-dialog modal-xl'><div class='modal-content'>"
+          output = ["<div class='modal-dialog modal-xl'><div class='modal-content'>"]
           output << "<div class='modal-header'>"
           output << "<h4>Line profiling: #{human_description(params[:lineprofiler])}</h4>"
           output << "<button class='close' type='button' data-dismiss='modal' aria-label='close'><span aria-hidden='true'>&times;</span></button>"
@@ -93,7 +95,7 @@ module Peek
           output << "</div></div></div>"
-          response.body += "<div class='modal' id='modal-peek-line-profile' tabindex=-1>#{output}</div>".html_safe
+          response.body += "<div class='modal' id='modal-peek-line-profile' tabindex=-1>#{output.join}</div>".html_safe
         end
         ret