Skip to content
Snippets Groups Projects
Unverified Commit 4377b479 authored by Phil Hughes's avatar Phil Hughes
Browse files

remove useless ajaxPost method

parent 988747df
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -35,8 +35,6 @@ export const ajaxGet = url => axios.get(url, {
$.globalEval(data);
});
 
export const ajaxPost = (url, data) => axios.post(url, data);
export const rstrip = (val) => {
if (val) {
return val.replace(/\s+$/, '');
Loading
Loading
@@ -409,7 +407,6 @@ window.gl.utils = {
getGroupSlug,
isInIssuePage,
ajaxGet,
ajaxPost,
rstrip,
updateTooltipTitle,
disableButtonIfEmptyField,
Loading
Loading
Loading
Loading
@@ -17,13 +17,14 @@ import 'vendor/jquery.caret'; // required by jquery.atwho
import 'vendor/jquery.atwho';
import AjaxCache from '~/lib/utils/ajax_cache';
import { getLocationHash } from './lib/utils/url_utility';
import axios from './lib/utils/axios_utils';
import Flash from './flash';
import CommentTypeToggle from './comment_type_toggle';
import GLForm from './gl_form';
import loadAwardsHandler from './awards_handler';
import Autosave from './autosave';
import TaskList from './task_list';
import { ajaxPost, isInViewport, getPagePath, scrollToElement, isMetaKey } from './lib/utils/common_utils';
import { isInViewport, getPagePath, scrollToElement, isMetaKey } from './lib/utils/common_utils';
import imageDiffHelper from './image_diff/helpers/index';
import { localTimeAgo } from './lib/utils/datetime_utility';
 
Loading
Loading
@@ -1404,7 +1405,7 @@ export default class Notes {
* 2) Identify comment type; a) Main thread b) Discussion thread c) Discussion resolve
* 3) Build temporary placeholder element (using `createPlaceholderNote`)
* 4) Show placeholder note on UI
* 5) Perform network request to submit the note using `ajaxPost`
* 5) Perform network request to submit the note using `axios.post`
* a) If request is successfully completed
* 1. Remove placeholder element
* 2. Show submitted Note element
Loading
Loading
@@ -1486,7 +1487,7 @@ export default class Notes {
 
/* eslint-disable promise/catch-or-return */
// Make request to submit comment on server
ajaxPost(formAction, formData)
axios.post(formAction, formData)
.then((res) => {
const note = res.data;
 
Loading
Loading
@@ -1601,7 +1602,7 @@ export default class Notes {
*
* 1) Get Form metadata
* 2) Update note element with new content
* 3) Perform network request to submit the updated note using `ajaxPost`
* 3) Perform network request to submit the updated note using `axios.post`
* a) If request is successfully completed
* 1. Show submitted Note element
* b) If request failed
Loading
Loading
@@ -1632,7 +1633,7 @@ export default class Notes {
 
/* eslint-disable promise/catch-or-return */
// Make request to update comment on server
ajaxPost(formAction, formData)
axios.post(formAction, formData)
.then(({ data }) => {
// Submission successful! render final note element
this.updateNote(data, $editingNote);
Loading
Loading
Loading
Loading
@@ -459,19 +459,6 @@ describe('common_utils', () => {
});
});
 
describe('ajaxPost', () => {
it('should perform `$.ajax` call and do `POST` request', () => {
const requestURL = '/some/random/api';
const data = { keyname: 'value' };
const ajaxSpy = spyOn(axios, 'post').and.callFake(() => {});
commonUtils.ajaxPost(requestURL, data);
expect(ajaxSpy.calls.allArgs()[0][0]).toEqual(requestURL);
expect(ajaxSpy.calls.allArgs()[0][1]).toEqual(data);
});
});
describe('spriteIcon', () => {
let beforeGon;
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment