Skip to content
Snippets Groups Projects
Commit 4d0d5e79 authored by Ciro Santilli's avatar Ciro Santilli
Browse files

Factor authorize_push! and authorize_code_access!

with existing method_missing. Pattern already used extensively,
so let's be consistent and use it everywhere.
parent e261de25
No related branches found
No related tags found
1 merge request!8030Factor authorize_push! and authorize_code_access!
Showing
with 18 additions and 26 deletions
Loading
Loading
@@ -119,14 +119,6 @@ class ApplicationController < ActionController::Base
return access_denied! unless can?(current_user, action, project)
end
 
def authorize_code_access!
return access_denied! unless can?(current_user, :download_code, project)
end
def authorize_push!
return access_denied! unless can?(current_user, :push_code, project)
end
def authorize_labels!
# Labels should be accessible for issues and/or merge requests
authorize_read_issue! || authorize_read_merge_request!
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@ class Projects::BaseTreeController < Projects::ApplicationController
include ExtractsPath
 
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
end
 
Loading
Loading
@@ -4,7 +4,7 @@ class Projects::BlameController < Projects::ApplicationController
 
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def show
Loading
Loading
Loading
Loading
@@ -4,9 +4,9 @@ class Projects::BlobController < Projects::ApplicationController
 
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
before_filter :authorize_push!, only: [:destroy]
before_filter :authorize_push_code!, only: [:destroy]
 
before_filter :blob
 
Loading
Loading
Loading
Loading
@@ -3,8 +3,8 @@ class Projects::BranchesController < Projects::ApplicationController
before_filter :authorize_read_project!
before_filter :require_non_empty_project
 
before_filter :authorize_code_access!
before_filter :authorize_push!, only: [:create, :destroy]
before_filter :authorize_download_code!
before_filter :authorize_push_code!, only: [:create, :destroy]
 
def index
@sort = params[:sort] || 'name'
Loading
Loading
Loading
Loading
@@ -4,7 +4,7 @@
class Projects::CommitController < Projects::ApplicationController
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
before_filter :commit
 
Loading
Loading
Loading
Loading
@@ -5,7 +5,7 @@ class Projects::CommitsController < Projects::ApplicationController
 
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def show
Loading
Loading
class Projects::CompareController < Projects::ApplicationController
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def index
Loading
Loading
class Projects::EditTreeController < Projects::BaseTreeController
before_filter :require_branch_head
before_filter :blob
before_filter :authorize_push!
before_filter :authorize_push_code!
before_filter :from_merge_request
before_filter :after_edit_path
 
Loading
Loading
class Projects::GraphsController < Projects::ApplicationController
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def show
Loading
Loading
Loading
Loading
@@ -4,7 +4,7 @@ class Projects::NetworkController < Projects::ApplicationController
 
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def show
Loading
Loading
class Projects::NewTreeController < Projects::BaseTreeController
before_filter :require_branch_head
before_filter :authorize_push!
before_filter :authorize_push_code!
 
def show
end
Loading
Loading
Loading
Loading
@@ -4,7 +4,7 @@ class Projects::RawController < Projects::ApplicationController
 
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def show
Loading
Loading
Loading
Loading
@@ -3,7 +3,7 @@ class Projects::RefsController < Projects::ApplicationController
 
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def switch
Loading
Loading
class Projects::RepositoriesController < Projects::ApplicationController
# Authorize
before_filter :authorize_read_project!
before_filter :authorize_code_access!
before_filter :authorize_download_code!
before_filter :require_non_empty_project
 
def archive
Loading
Loading
Loading
Loading
@@ -3,8 +3,8 @@ class Projects::TagsController < Projects::ApplicationController
before_filter :authorize_read_project!
before_filter :require_non_empty_project
 
before_filter :authorize_code_access!
before_filter :authorize_push!, only: [:create]
before_filter :authorize_download_code!
before_filter :authorize_push_code!, only: [:create]
before_filter :authorize_admin_project!, only: [:destroy]
 
def index
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment