Merge branch '43273-fix-double-scrollbar-dropdowns' into 'master'

Resolve "Some dropdowns have two scroll bars."

Closes #43273

See merge request gitlab-org/gitlab-ce!17665

app/assets/stylesheets/framework/dropdowns.scss

@@ -622,7 +622,7 @@
 }
 .dropdown-content {
-  max-height: $dropdown-max-height;
+  max-height: 252px;
   overflow-y: auto;
 }
@@ -699,6 +699,31 @@
   border-radius: $border-radius-base;
 }
+.git-revision-dropdown {
+  .dropdown-content {
+    max-height: 215px;
+  }
+}
+
+.sidebar-move-issue-dropdown {
+  .dropdown-content {
+    max-height: 160px;
+  }
+}
+
+.dropdown-menu-author {
+  .dropdown-content {
+    max-height: 215px;
+  }
+}
+
+.dropdown-menu-labels {
+  .dropdown-content {
+    max-height: 128px;
+  }
+}
+
+
 .dropdown-menu-due-date {
   .dropdown-content {
     max-height: 230px;

app/assets/stylesheets/framework/sidebar.scss

@@ -152,3 +152,4 @@
 .sidebar-collapsed-icon .sidebar-collapsed-value {
   font-size: 12px;
 }
+

app/assets/stylesheets/pages/boards.scss

@@ -31,8 +31,12 @@
 .dropdown-menu-issues-board-new {
   width: 320px;
+  .open & {
+    max-height: 400px;
+  }
+
   .dropdown-content {
-    max-height: 150px;
+    max-height: 162px;
   }
 }

app/assets/stylesheets/pages/labels.scss

@@ -26,9 +26,15 @@
   }
 }
+.dropdown-menu-labels {
+  .dropdown-content {
+    max-height: 135px;
+  }
+}
+
 .dropdown-new-label {
   .dropdown-content {
-    max-height: 260px;
+    max-height: 136px;
   }
 }

app/assets/stylesheets/pages/search.scss

@@ -112,7 +112,7 @@ input[type="checkbox"]:hover {
     }
     .dropdown-content {
-      max-height: 350px;
+      max-height: 302px;
     }
   }