Skip to content
Snippets Groups Projects
Commit 549242c6 authored by Julian Zinn's avatar Julian Zinn Committed by Rémy Coutable
Browse files

For single line git commit messages, the close quote should be on the same line as the open quote


Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent 0139896b
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -220,7 +220,7 @@ class JiraService < IssueTrackerService
entity_title = data[:entity][:title]
project_name = data[:project][:name]
 
message = "[#{user_name}|#{user_url}] mentioned this issue in [a #{entity_name} of #{project_name}|#{entity_url}]:\n'#{entity_title}'"
message = "[#{user_name}|#{user_url}] mentioned this issue in [a #{entity_name} of #{project_name}|#{entity_url}]:\n'#{entity_title.chomp}'"
link_title = "GitLab: Mentioned on #{entity_name} - #{entity_title}"
link_props = build_remote_link_props(url: entity_url, title: link_title)
 
Loading
Loading
---
title: For single line git commit messages, the close quote should be on the same
line as the open quote
merge_request:
author:
Loading
Loading
@@ -694,7 +694,7 @@ describe SystemNoteService, services: true do
 
describe "existing reference" do
before do
message = "[#{author.name}|http://localhost/#{author.username}] mentioned this issue in [a commit of #{project.path_with_namespace}|http://localhost/#{project.path_with_namespace}/commit/#{commit.id}]:\n'#{commit.title}'"
message = "[#{author.name}|http://localhost/#{author.username}] mentioned this issue in [a commit of #{project.path_with_namespace}|http://localhost/#{project.path_with_namespace}/commit/#{commit.id}]:\n'#{commit.title.chomp}'"
allow_any_instance_of(JIRA::Resource::Issue).to receive(:comments).and_return([OpenStruct.new(body: message)])
end
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment