Merge branch 'issue-64738' into 'master'

Prevent archived projects from showing up in global search

See merge request gitlab-org/gitlab-ce!31498

app/services/search/global_service.rb

@@ -18,7 +18,7 @@ module Search
     end
     def projects
-      @projects ||= ProjectsFinder.new(current_user: current_user).execute
+      @projects ||= ProjectsFinder.new(params: { non_archived: true }, current_user: current_user).execute
     end
     def allowed_scopes

changelogs/unreleased/issue-64738.yml

+---
+title: Prevent archived projects from showing up in global search
+merge_request: 31498
+author: David Palubin
+type: fixed

spec/services/search/global_service_spec.rb

@@ -42,6 +42,14 @@ describe Search::GlobalService do
         expect(results.objects('projects')).to match_array [found_project]
       end
+
+      it 'does not return archived projects' do
+        archived_project = create(:project, :public, archived: true, name: 'archived_project')
+
+        results = described_class.new(user, search: "archived").execute
+
+        expect(results.objects('projects')).not_to include(archived_project)
+      end
     end
   end
 end