Skip to content
Snippets Groups Projects
Commit 578adc9b authored by Athar Hameed's avatar Athar Hameed
Browse files

Fix missing optional path parameter in "Create project for user" API

parent 5cb8ad6c
No related branches found
No related tags found
No related merge requests found
---
title: Fix missing optional path parameter in "Create project for user" API
merge_request: 11868
author:
Loading
Loading
@@ -129,6 +129,7 @@ module API
params do
requires :name, type: String, desc: 'The name of the project'
requires :user_id, type: Integer, desc: 'The ID of a user'
optional :path, type: String, desc: 'The path of the repository'
optional :default_branch, type: String, desc: 'The default branch of the project'
use :optional_params
use :create_params
Loading
Loading
Loading
Loading
@@ -316,15 +316,15 @@ describe API::Projects do
expect(project.path).to eq('foo_project')
end
 
it 'creates new project name and path and returns 201' do
expect { post api('/projects', user), path: 'foo-Project', name: 'Foo Project' }.
it 'creates new project with name and path and returns 201' do
expect { post api('/projects', user), path: 'path-project-Foo', name: 'Foo Project' }.
to change { Project.count }.by(1)
expect(response).to have_http_status(201)
 
project = Project.first
 
expect(project.name).to eq('Foo Project')
expect(project.path).to eq('foo-Project')
expect(project.path).to eq('path-project-Foo')
end
 
it 'creates last project before reaching project limit' do
Loading
Loading
@@ -470,9 +470,25 @@ describe API::Projects do
before { project }
before { admin }
 
it 'creates new project without path and return 201' do
expect { post api("/projects/user/#{user.id}", admin), name: 'foo' }.to change {Project.count}.by(1)
it 'creates new project without path but with name and return 201' do
expect { post api("/projects/user/#{user.id}", admin), name: 'Foo Project' }.to change {Project.count}.by(1)
expect(response).to have_http_status(201)
project = Project.first
expect(project.name).to eq('Foo Project')
expect(project.path).to eq('foo-project')
end
it 'creates new project with name and path and returns 201' do
expect { post api("/projects/user/#{user.id}", admin), path: 'path-project-Foo', name: 'Foo Project' }.
to change { Project.count }.by(1)
expect(response).to have_http_status(201)
project = Project.first
expect(project.name).to eq('Foo Project')
expect(project.path).to eq('path-project-Foo')
end
 
it 'responds with 400 on failure and not project' do
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment