Skip to content
Snippets Groups Projects
Unverified Commit 5c39c7c3 authored by Phil Hughes's avatar Phil Hughes
Browse files

Updated latestDiff logic to only be used to LegacyDiffNotes

parent 5eef5f24
No related branches found
No related tags found
1 merge request!10495Merge Requests - Assignee
Loading
Loading
@@ -86,8 +86,6 @@ export default {
},
 
[types.SET_LINE_DISCUSSIONS_FOR_FILE](state, { fileHash, discussions, diffPositionByLineCode }) {
if (!state.latestDiff) return;
const selectedFile = state.diffFiles.find(f => f.fileHash === fileHash);
const firstDiscussion = discussions[0];
const isDiffDiscussion = firstDiscussion.diff_discussion;
Loading
Loading
@@ -99,7 +97,7 @@ export default {
isDiffDiscussion &&
hasLineCode &&
diffPosition &&
isDiscussionApplicableToLine(firstDiscussion, diffPosition)
isDiscussionApplicableToLine(firstDiscussion, diffPosition, state.latestDiff)
) {
const targetLine = selectedFile.parallelDiffLines.find(
line =>
Loading
Loading
Loading
Loading
@@ -254,7 +254,7 @@ export function getDiffPositionByLineCode(diffFiles) {
 
// This method will check whether the discussion is still applicable
// to the diff line in question regarding different versions of the MR
export function isDiscussionApplicableToLine(discussion, diffPosition) {
export function isDiscussionApplicableToLine(discussion, diffPosition, latestDiff) {
const { lineCode, ...diffPositionCopy } = diffPosition;
 
if (discussion.original_position && discussion.position) {
Loading
Loading
@@ -264,5 +264,5 @@ export function isDiscussionApplicableToLine(discussion, diffPosition) {
return _.isEqual(refs, diffPositionCopy) || _.isEqual(originalRefs, diffPositionCopy);
}
 
return discussion.active && lineCode === discussion.line_code;
return latestDiff && discussion.active && lineCode === discussion.line_code;
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment