Resolve annoying deprecation warnings

DEPRECATION WARNING: The success? predicate is deprecated and will be
removed in Rails 6.0. Please use successful? ...

spec/javascripts/fixtures/abuse_reports.rb

@@ -21,6 +21,6 @@ describe Admin::AbuseReportsController, '(JavaScript fixtures)', type: :controll
   it 'abuse_reports/abuse_reports_list.html' do
     get :index
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/admin_users.rb

@@ -23,6 +23,6 @@ describe Admin::UsersController, '(JavaScript fixtures)', type: :controller do
     get :new
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/application_settings.rb

@@ -28,6 +28,6 @@ describe Admin::ApplicationSettingsController, '(JavaScript fixtures)', type: :c
     get :show
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/autocomplete_sources.rb

@@ -34,6 +34,6 @@ describe Projects::AutocompleteSourcesController, '(JavaScript fixtures)', type:
             type_id: issue.id
         }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/blob.rb

@@ -29,6 +29,6 @@ describe Projects::BlobController, '(JavaScript fixtures)', type: :controller do
       id: 'add-ipython-files/files/ipython/basic.ipynb'
     })
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/boards.rb

@@ -23,6 +23,6 @@ describe Projects::BoardsController, '(JavaScript fixtures)', type: :controller
       project_id: project
     })
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/branches.rb

@@ -27,6 +27,6 @@ describe Projects::BranchesController, '(JavaScript fixtures)', type: :controlle
       project_id: project
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/clusters.rb

@@ -29,6 +29,6 @@ describe Projects::ClustersController, '(JavaScript fixtures)', type: :controlle
       id: cluster
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/commit.rb

@@ -28,6 +28,6 @@ describe Projects::CommitController, '(JavaScript fixtures)', type: :controller
     get :show, params: params
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/deploy_keys.rb

@@ -38,6 +38,6 @@ describe Projects::DeployKeysController, '(JavaScript fixtures)', type: :control
       project_id: project
     }, format: :json
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/groups.rb

@@ -21,7 +21,7 @@ describe 'Groups (JavaScript fixtures)', type: :controller do
     it 'groups/edit.html' do
       get :edit, params: { id: group }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
@@ -29,7 +29,7 @@ describe 'Groups (JavaScript fixtures)', type: :controller do
     it 'groups/ci_cd_settings.html' do
       get :show, params: { group_id: group }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 end

spec/javascripts/fixtures/issues.rb

@@ -48,7 +48,7 @@ describe Projects::IssuesController, '(JavaScript fixtures)', type: :controller
       project_id: project
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
   private
@@ -60,7 +60,7 @@ describe Projects::IssuesController, '(JavaScript fixtures)', type: :controller
       id: issue.to_param
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end
@@ -117,6 +117,6 @@ describe API::Issues, '(JavaScript fixtures)', type: :request do
     get_related_merge_requests(project.id, issue.iid, user)
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/jobs.rb

@@ -39,7 +39,7 @@ describe Projects::JobsController, '(JavaScript fixtures)', type: :controller do
       id: build_with_artifacts.to_param
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
   it 'jobs/delayed.json' do
@@ -49,6 +49,6 @@ describe Projects::JobsController, '(JavaScript fixtures)', type: :controller do
       id: delayed_job.to_param
     }, format: :json
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/labels.rb

@@ -35,7 +35,7 @@ describe 'Labels (JavaScript fixtures)' do
         group_id: group
       }, format: 'json'
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
@@ -52,7 +52,7 @@ describe 'Labels (JavaScript fixtures)' do
         project_id: project
       }, format: 'json'
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 end

spec/javascripts/fixtures/merge_requests.rb

@@ -129,6 +129,6 @@ describe Projects::MergeRequestsController, '(JavaScript fixtures)', type: :cont
       id: merge_request.to_param
     }, format: :html
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/merge_requests_diffs.rb

@@ -65,6 +65,6 @@ describe Projects::MergeRequests::DiffsController, '(JavaScript fixtures)', type
       **extra_params
     }, format: :json
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/pipeline_schedules.rb

@@ -28,7 +28,7 @@ describe Projects::PipelineSchedulesController, '(JavaScript fixtures)', type: :
       id: pipeline_schedule.id
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
   it 'pipeline_schedules/edit_with_variables.html' do
@@ -38,6 +38,6 @@ describe Projects::PipelineSchedulesController, '(JavaScript fixtures)', type: :
       id: pipeline_schedule_populated.id
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/pipelines.rb

@@ -29,6 +29,6 @@ describe Projects::PipelinesController, '(JavaScript fixtures)', type: :controll
       project_id: project
     }, format: :json
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end

spec/javascripts/fixtures/projects.rb

@@ -34,7 +34,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
         id: project
       }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
     it 'projects/overview.html' do
@@ -43,7 +43,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
         id: project_with_repo
       }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
     it 'projects/edit.html' do
@@ -52,7 +52,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
         id: project
       }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
@@ -63,7 +63,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
         project_id: project
       }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
     it 'projects/ci_cd_settings_with_variables.html' do
@@ -75,7 +75,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
         project_id: project_variable_populated
       }
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 end

spec/javascripts/fixtures/prometheus_service.rb

@@ -29,6 +29,6 @@ describe Projects::ServicesController, '(JavaScript fixtures)', type: :controlle
       id: service.to_param
     }
-    expect(response).to be_success
+    expect(response).to be_successful
   end
 end