Remove Koding integration and documentation

This integration no longer works and does not appear to be supported.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39697

app/assets/images/koding-logo.svg

-<?xml version="1.0" encoding="utf-8"?>
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 14">
-    <g fill="#d6d7d9">
-        <path d="M8.7 0L5.3.3l3.2 6.8-3.2 6.6 3.5.3L12 6.9z"/>
-        <ellipse cx="1.7" cy="11.1" rx="1.7" ry="1.7"/>
-        <ellipse cx="1.7" cy="5.6" rx="1.7" ry="1.7"/>
-    </g>
-</svg>
\ No newline at end of file

app/controllers/koding_controller.rb

-# frozen_string_literal: true
-
-class KodingController < ApplicationController
-  before_action :check_integration!
-  layout 'koding'
-
-  def index
-    path = File.join(Rails.root, 'doc/user/project/koding.md')
-    @markdown = File.read(path)
-  end
-
-  private
-
-  def check_integration!
-    render_404 unless Gitlab::CurrentSettings.koding_enabled?
-  end
-end

app/helpers/application_settings_helper.rb

@@ -7,7 +7,6 @@ module ApplicationSettingsHelper
             :gravatar_enabled?,
             :password_authentication_enabled_for_web?,
             :akismet_enabled?,
-            :koding_enabled?,
             to: :'Gitlab::CurrentSettings.current_application_settings'
   def user_oauth_applications?
@@ -155,8 +154,6 @@ module ApplicationSettingsHelper
       :housekeeping_incremental_repack_period,
       :html_emails_enabled,
       :import_sources,
-      :koding_enabled,
-      :koding_url,
       :max_artifacts_size,
       :max_attachment_size,
       :max_pages_size,

app/helpers/projects_helper.rb

@@ -388,22 +388,6 @@ module ProjectsHelper
     end
   end
-  def koding_project_url(project = nil, branch = nil, sha = nil)
-    if project
-      import_path = "/Home/Stacks/import"
-
-      repo = project.full_path
-      branch ||= project.default_branch
-      sha ||= project.commit.short_id
-
-      path = "#{import_path}?repo=#{repo}&branch=#{branch}&sha=#{sha}"
-
-      return URI.join(Gitlab::CurrentSettings.koding_url, path).to_s
-    end
-
-    Gitlab::CurrentSettings.koding_url
-  end
-
   def project_wiki_path_with_version(proj, page, version, is_newest)
     url_params = is_newest ? {} : { version_id: version }
     project_wiki_path(proj, page, url_params)

app/models/application_setting.rb

@@ -33,6 +33,8 @@ class ApplicationSetting < ActiveRecord::Base
   ignore_column :circuitbreaker_storage_timeout
   ignore_column :circuitbreaker_access_retries
   ignore_column :circuitbreaker_check_interval
+  ignore_column :koding_url
+  ignore_column :koding_enabled
   cache_markdown_field :sign_in_text
   cache_markdown_field :help_page_text
@@ -100,10 +102,6 @@ class ApplicationSetting < ActiveRecord::Base
             presence: true,
             if: :unique_ips_limit_enabled
-  validates :koding_url,
-            presence: true,
-            if: :koding_enabled
-
   validates :plantuml_url,
             presence: true,
             if: :plantuml_enabled
@@ -252,8 +250,6 @@ class ApplicationSetting < ActiveRecord::Base
       housekeeping_gc_period: 200,
       housekeeping_incremental_repack_period: 10,
       import_sources: Settings.gitlab['import_sources'],
-      koding_enabled: false,
-      koding_url: nil,
       max_artifacts_size: Settings.artifacts['max_size'],
       max_attachment_size: Settings.gitlab['max_attachment_size'],
       mirror_available: true,

app/models/repository.rb

@@ -36,7 +36,7 @@ class Repository
   # For example, for entry `:commit_count` there's a method called `commit_count` which
   # stores its data in the `commit_count` cache key.
   CACHED_METHODS = %i(size commit_count rendered_readme contribution_guide
-                      changelog license_blob license_key gitignore koding_yml
+                      changelog license_blob license_key gitignore
                       gitlab_ci_yml branch_names tag_names branch_count
                       tag_count avatar exists? root_ref has_visible_content?
                       issue_template_names merge_request_template_names xcode_project?).freeze
@@ -53,7 +53,6 @@ class Repository
     license: %i(license_blob license_key license),
     contributing: :contribution_guide,
     gitignore: :gitignore,
-    koding: :koding_yml,
     gitlab_ci: :gitlab_ci_yml,
     avatar: :avatar,
     issue_template: :issue_template_names,
@@ -619,11 +618,6 @@ class Repository
   end
   cache_method :gitignore
-  def koding_yml
-    file_on_head(:koding)
-  end
-  cache_method :koding_yml
-
   def gitlab_ci_yml
     file_on_head(:gitlab_ci)
   end

app/presenters/project_presenter.rb

@@ -36,8 +36,7 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
       contribution_guide_anchor_data,
       autodevops_anchor_data(show_auto_devops_callout: show_auto_devops_callout),
       kubernetes_cluster_anchor_data,
-      gitlab_ci_anchor_data,
-      koding_anchor_data
+      gitlab_ci_anchor_data
     ].compact.reject { |item| item.enabled }
   end
@@ -125,43 +124,6 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
     add_special_file_path(file_name: 'README.md')
   end
-  def add_koding_stack_path
-    project_new_blob_path(
-      project,
-      default_branch || 'master',
-      file_name:      '.koding.yml',
-      commit_message: "Add Koding stack script",
-      content: <<-CONTENT.strip_heredoc
-        provider:
-          aws:
-            access_key: '${var.aws_access_key}'
-            secret_key: '${var.aws_secret_key}'
-        resource:
-          aws_instance:
-            #{project.path}-vm:
-              instance_type: t2.nano
-              user_data: |-
-
-                # Created by GitLab UI for :>
-
-                echo _KD_NOTIFY_@Installing Base packages...@
-
-                apt-get update -y
-                apt-get install git -y
-
-                echo _KD_NOTIFY_@Cloning #{project.name}...@
-
-                export KODING_USER=${var.koding_user_username}
-                export REPO_URL=#{root_url}${var.koding_queryString_repo}.git
-                export BRANCH=${var.koding_queryString_branch}
-
-                sudo -i -u $KODING_USER git clone $REPO_URL -b $BRANCH
-
-                echo _KD_NOTIFY_@#{project.name} cloned.@
-      CONTENT
-    )
-  end
-
   def license_short_name
     license = repository.license
     license&.nickname || license&.name || 'LICENSE'
@@ -310,14 +272,6 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
     end
   end
-  def koding_anchor_data
-    if current_user && can_current_user_push_code? && koding_enabled? && repository.koding_yml.blank?
-      AnchorData.new(false,
-                     _('Set up Koding'),
-                     add_koding_stack_path)
-    end
-  end
-
   def tags_to_show
     project.tag_list.take(MAX_TAGS_TO_SHOW) # rubocop: disable CodeReuse/ActiveRecord
   end
@@ -363,8 +317,4 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
       branch_name:    branch_name
     )
   end
-
-  def koding_enabled?
-    Gitlab::CurrentSettings.koding_enabled?
-  end
 end

app/views/admin/application_settings/_koding.html.haml

-= form_for @application_setting, url: admin_application_settings_path(anchor: 'js-koding-settings'), html: { class: 'fieldset-form' } do |f|
-  = form_errors(@application_setting)
-
-  %fieldset
-    .form-group
-      .form-check
-        = f.check_box :koding_enabled, class: 'form-check-input'
-        = f.label :koding_enabled, class: 'form-check-label' do
-          Enable Koding
-      .form-text.text-muted
-        Koding integration has been deprecated since GitLab 10.0. If you disable your Koding integration, you will not be able to enable it again.
-    .form-group
-      = f.label :koding_url, 'Koding URL', class: 'label-bold'
-      = f.text_field :koding_url, class: 'form-control', placeholder: 'http://gitlab.your-koding-instance.com:8090'
-      .form-text.text-muted
-        Koding has integration enabled out of the box for the
-        %strong gitlab
-        team, and you need to provide that team's URL here. Learn more in the
-        = succeed "." do
-          = link_to "Koding administration documentation", help_page_path("administration/integration/koding")
-
-  = f.submit 'Save changes', class: "btn btn-success"

app/views/admin/application_settings/show.html.haml

@@ -68,18 +68,6 @@
   .settings-content
     = render 'terms'
-- if koding_enabled?
-  %section.settings.as-koding.no-animate#js-koding-settings{ class: ('expanded' if expanded_by_default?) }
-    .settings-header
-      %h4
-        = _('Koding')
-      %button.btn.btn-default.js-settings-toggle{ type: 'button' }
-        = expanded_by_default? ? _('Collapse') : _('Expand')
-      %p
-        = _('Online IDE integration settings.')
-    .settings-content
-      = render 'koding'
-
 = render_if_exists 'admin/application_settings/external_authorization_service_form', expanded: expanded_by_default?
 %section.settings.as-terminal.no-animate#js-terminal-settings{ class: ('expanded' if expanded_by_default?) }

app/views/koding/index.html.haml

-.row-content-block.second-block.center
-  %p
-    = icon('circle', class: 'cgreen')
-    Integration is active for
-    = link_to koding_project_url, target: '_blank', rel: 'noopener noreferrer' do
-      #{Gitlab::CurrentSettings.koding_url}

app/views/layouts/koding.html.haml

-- page_title        _("Koding")
-- page_description  _("Koding Dashboard")
-- header_title      _("Koding"), koding_path
-
-= render template: "layouts/application"

app/views/projects/_home_panel.html.haml

@@ -76,8 +76,6 @@
             = render 'projects/buttons/download', project: @project, ref: @ref
           .d-none.d-sm-inline-flex
             = render 'projects/buttons/dropdown'
-          .d-none.d-sm-inline-flex
-            = render 'projects/buttons/koding'
         .d-none.d-sm-inline-flex
           = render 'shared/notifications/button', notification_setting: @notification_setting

app/views/projects/buttons/_koding.html.haml

-- if koding_enabled? && current_user && @repository.koding_yml && @project.can_current_user_push_code?
-  = link_to koding_project_url(@project), class: 'btn project-action-button inline', target: '_blank', rel: 'noopener noreferrer' do
-    _('Run in IDE (Koding)')

changelogs/unreleased/sh-remove-koding.yml

+---
+title: Remove Koding integration and documentation
+merge_request: 22334
+author:
+type: removed

config/routes.rb

@@ -81,9 +81,6 @@ Rails.application.routes.draw do
     draw :instance_statistics
   end
-  # Koding route
-  get 'koding' => 'koding#index'
-
   draw :api
   draw :sidekiq
   draw :help

db/post_migrate/20181013005024_remove_koding_from_application_settings.rb

+# frozen_string_literal: true
+
+class RemoveKodingFromApplicationSettings < ActiveRecord::Migration
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+
+  def up
+    remove_column :application_settings, :koding_enabled
+    remove_column :application_settings, :koding_url
+  end
+
+  def down
+    add_column :application_settings, :koding_enabled, :boolean # rubocop:disable Migration/SaferBooleanColumn
+    add_column :application_settings, :koding_url, :string
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 20181008200441) do
+ActiveRecord::Schema.define(version: 20181013005024) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -104,8 +104,6 @@ ActiveRecord::Schema.define(version: 20181008200441) do
     t.boolean "domain_blacklist_enabled", default: false
     t.text "domain_blacklist"
     t.boolean "usage_ping_enabled", default: true, null: false
-    t.boolean "koding_enabled"
-    t.string "koding_url"
     t.text "sign_in_text_html"
     t.text "help_page_text_html"
     t.text "shared_runners_text_html"

doc/administration/integration/koding.md

-# Koding & GitLab
-
-> **Notes:**
-> - **As of GitLab 10.0, the Koding integration is deprecated and will be removed
->   in a future version. The option to configure it is removed from GitLab's admin
->   area.**
-> - [Introduced][ce-5909] in GitLab 8.11.
-
-This document will guide you through installing and configuring Koding with
-GitLab.
-
-First of all, to be able to use Koding and GitLab together you will need public
-access to your server. This allows you to use single sign-on from GitLab to
-Koding and using vms from cloud providers like AWS. Koding has a registry for
-VMs, called Kontrol and it runs on the same server as Koding itself, VMs from
-cloud providers register themselves to Kontrol via the agent that we put into
-provisioned VMs. This agent is called Klient and it provides Koding to access
-and manage the target machine.
-
-Kontrol and Klient are based on another technology called
-[Kite](https://github.com/koding/kite), that we have written at Koding. Which is a
-microservice framework that allows you to develop microservices easily.
-
-## Requirements
-
-### Hardware
-
-Minimum requirements are;
-
-  - 2 cores CPU
-  - 3G RAM
-  - 10G Storage
-
-If you plan to use AWS to install Koding it is recommended that you use at
-least a `c3.xlarge` instance.
-
-### Software
-
-  - [Git](https://git-scm.com)
-  - [Docker](https://www.docker.com)
-  - [docker-compose](https://www.docker.com/products/docker-compose)
-
-Koding can run on most of the UNIX based operating systems, since it's shipped
-as containerized with Docker support, it can work on any operating system that
-supports Docker.
-
-Required services are:
-
-- **PostgreSQL** - Kontrol and Service DB provider
-- **MongoDB**    - Main DB provider the application
-- **Redis**      - In memory DB used by both application and services
-- **RabbitMQ**   - Message Queue for both application and services
-
-which are also provided as a Docker container by Koding.
-
-
-## Getting Started with Development Versions
-
-
-### Koding
-
-You can run `docker-compose` environment for developing koding by
-executing commands in the following snippet.
-
-```bash
-git clone https://github.com/koding/koding.git
-cd koding
-docker-compose -f docker-compose-init.yml run init
-docker-compose up
-```
-
-This should start koding on `localhost:8090`.
-
-By default there is no team exists in Koding DB. You'll need to create a team
-called `gitlab` which is the default team name for GitLab integration in the
-configuration. To make things in order it's recommended to create the `gitlab`
-team first thing after setting up Koding.
-
-
-### GitLab
-
-To install GitLab to your environment for development purposes it's recommended
-to use GitLab Development Kit which you can get it from
-[here](https://gitlab.com/gitlab-org/gitlab-development-kit).
-
-After all those steps, gitlab should be running on `localhost:3000`
-
-
-## Integration
-
-Integration includes following components;
-
-  - Single Sign On with OAuth from GitLab to Koding
-  - System Hook integration for handling GitLab events on Koding
-    (`project_created`, `user_joined` etc.)
-  - Service endpoints for importing/executing stacks from GitLab to Koding
-    (`Run/Try on IDE (Koding)` buttons on GitLab Projects, Issues, MRs)
-
-As it's pointed out before, you will need public access to this machine that
-you've installed Koding and GitLab on. Better to use a domain but a static IP
-is also fine.
-
-For IP based installation you can use [nip.io](https://nip.io) service which is
-free and provides DNS resolution to IP based requests like following;
-
-  - 127.0.0.1.nip.io              -> resolves to 127.0.0.1
-  - foo.bar.baz.127.0.0.1.nip.io  -> resolves to 127.0.0.1
-  - and so on...
-
-As Koding needs subdomains for team names; `foo.127.0.0.1.nip.io` requests for
-a running koding instance on `127.0.0.1` server will be handled as `foo` team
-requests.
-
-
-### GitLab Side
-
-You need to enable Koding integration from Settings under Admin Area. To do
-that login with an Admin account and do followings;
-
-- open [http://127.0.0.1:3000/admin/application_settings](http://127.0.0.1:3000/admin/application_settings)
-- scroll to bottom of the page until Koding section
-- check `Enable Koding` checkbox
-- provide GitLab team page for running Koding instance as `Koding URL`*
-  * For `Koding URL` you need to provide the gitlab integration enabled team on
-your Koding installation. Team called `gitlab` has integration on Koding out
-of the box, so if you didn't change anything your team on Koding should be
-`gitlab`.
-
-So, if your Koding is running on `http://1.2.3.4.nip.io:8090` your URL needs
-to be `http://gitlab.1.2.3.4.nip.io:8090`. You need to provide the same host
-with your Koding installation here.
-
-
-#### Registering Koding for OAuth integration
-
-We need `Application ID` and `Secret` to enable login to Koding via GitLab
-feature and to do that you need to register running Koding as a new application
-to your running GitLab application. Follow
-[these](http://docs.gitlab.com/ce/integration/oauth_provider.html) steps to
-enable this integration.
-
-Redirect URI should be `http://gitlab.127.0.0.1:8090/-/oauth/gitlab/callback`
-which again you need to _replace `127.0.0.1` with your instance public IP._
-
-Take a copy of `Application ID` and `Secret` that is generated by the GitLab
-application, we will need those on _Koding Part_ of this guide.
-
-
-#### Registering system hooks to Koding (optional)
-
-Koding can take actions based on the events generated by GitLab application.
-This feature is still in progress and only following events are processed by
-Koding at the moment;
-
-  - user_create
-  - user_destroy
-
-All system events are handled but not implemented on Koding side.
-
-To enable this feature you need to provide a `URL` and a `Secret Token` to your
-GitLab application. Open your admin area on your GitLab app from
-[http://127.0.0.1:3000/admin/hooks](http://127.0.0.1:3000/admin/hooks)
-and provide `URL` as `http://gitlab.127.0.0.1:8090/-/api/gitlab` which is the
-endpoint to handle GitLab events on Koding side. Provide a `Secret Token` and
-keep a copy of it, we will need it on _Koding Part_ of this guide.
-
-_(replace `127.0.0.1` with your instance public IP)_
-
-
-### Koding Part
-
-If you followed the steps in GitLab part we should have followings to enable
-Koding part integrations;
-
-  - `Application ID` and `Secret` for OAuth integration
-  - `Secret Token` for system hook integration
-  - Public address of running GitLab instance
-
-
-#### Start Koding with GitLab URL
-
-Now we need to configure Koding with all this information to get things ready.
-If it's already running please stop koding first.
-
-##### From command-line
-
-Replace followings with the ones you got from GitLab part of this guide;
-
-```bash
-cd koding
-docker-compose run                              \
-  --service-ports backend                       \
-  /opt/koding/scripts/bootstrap-container build \
-  --host=**YOUR_IP**.nip.io                     \
-  --gitlabHost=**GITLAB_IP**                    \
-  --gitlabPort=**GITLAB_PORT**                  \
-  --gitlabToken=**SECRET_TOKEN**                \
-  --gitlabAppId=**APPLICATION_ID**              \
-  --gitlabAppSecret=**SECRET**
-```
-
-##### By updating configuration
-
-Alternatively you can update `gitlab` section on
-`config/credentials.default.coffee` like following;
-
-```
-gitlab =
-  host: '**GITLAB_IP**'
-  port: '**GITLAB_PORT**'
-  applicationId: '**APPLICATION_ID**'
-  applicationSecret: '**SECRET**'
-  team: 'gitlab'
-  redirectUri: ''
-  systemHookToken: '**SECRET_TOKEN**'
-  hooksEnabled: yes
-```
-
-and start by only providing the `host`;
-
-```bash
-cd koding
-docker-compose run                              \
-  --service-ports backend                       \
-  /opt/koding/scripts/bootstrap-container build \
-  --host=**YOUR_IP**.nip.io                     \
-```
-
-#### Enable Single Sign On
-
-Once you restarted your Koding and logged in with your username and password
-you need to activate oauth authentication for your user. To do that
-
- - Navigate to Dashboard on Koding from;
-   `http://gitlab.**YOUR_IP**.nip.io:8090/Home/my-account`
- - Scroll down to Integrations section
- - Click on toggle to turn On integration in GitLab integration section
-
-This will redirect you to your GitLab instance and will ask your permission (
-if you are not logged in to GitLab at this point you will be redirected after
-login) once you accept you will be redirected to your Koding instance.
-
-From now on you can login by using `SIGN IN WITH GITLAB` button on your Login
-screen in your Koding instance.
-
-[ce-5909]: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5909

doc/api/settings.md

@@ -45,8 +45,6 @@ Example response:
    "sign_in_text" : null,
    "container_registry_token_expire_delay": 5,
    "repository_storages": ["default"],
-   "koding_enabled": false,
-   "koding_url": null,
    "plantuml_enabled": false,
    "plantuml_url": null,
    "terminal_max_session_time": 0,
@@ -103,8 +101,6 @@ Example response:
   "after_sign_out_path": "",
   "container_registry_token_expire_delay": 5,
   "repository_storages": ["default"],
-  "koding_enabled": false,
-  "koding_url": null,
   "plantuml_enabled": false,
   "plantuml_url": null,
   "terminal_max_session_time": 0,
@@ -175,8 +171,6 @@ are listed in the descriptions of the relevant settings.
 | `html_emails_enabled`                    | boolean          | no                                   | Enable HTML emails. |
 | `instance_statistics_visibility_private` | boolean          | no                                   | When set to `true` Instance statistics will only be available to admins. |
 | `import_sources`                         | array of strings | no                                   | Sources to allow project import from, possible values: `github`, `bitbucket`, `gitlab`, `google_code`, `fogbugz`, `git`, and `gitlab_project`. |
-| `koding_enabled`                         | boolean          | no                                   | (If enabled, requires: `koding_url`) Enable Koding integration. Default is `false`. |
-| `koding_url`                             | string           | required by: `koding_enabled`        | The Koding instance URL for integration. |
 | `max_artifacts_size`                     | integer          | no                                   | Maximum artifacts size in MB |
 | `max_attachment_size`                    | integer          | no                                   | Limit attachment size in MB |
 | `max_pages_size`                         | integer          | no                                   | Maximum size of pages repositories in MB |