Add latest changes from gitlab-org/gitlab@master

.haml-lint_todo.yml

@@ -495,7 +495,6 @@ linters:
       - 'ee/app/views/projects/services/prometheus/_metrics.html.haml'
       - 'ee/app/views/projects/settings/slacks/edit.html.haml'
       - 'ee/app/views/shared/_additional_email_text.html.haml'
-      - 'ee/app/views/shared/_geo_info_modal.html.haml'
       - 'ee/app/views/shared/_mirror_update_button.html.haml'
       - 'ee/app/views/shared/_shared_runners_minutes_limit.html.haml'
       - 'ee/app/views/shared/audit_events/_event_table.html.haml'

CHANGELOG-EE.md

 Please view this file on the master branch, on stable branches it's out of date.
+## 12.4.0
+
+### Security (2 changes)
+
+- Prevent IDOR when adding groups to protected environments.
+- Hide approvers if a rule has any hidden groups.
+
+### Removed (1 change)
+
+- Remove db_load_balancing_index gauge metric. !17561
+
+### Fixed (26 changes, 1 of them is from the community)
+
+- Admin settings errors now shown in the correct panel. !14374
+- Add missing error handling for epic quick actions. !15648
+- Fix project exports clobbering concurrent export paths. !16280
+- Fixes scroll handle icon in time series. !16354
+- Remove hardcoded Medium confidence for Container Scanning vulnerabilities. !16395
+- Fixed renaming changed files. !16539
+- Fix project-defined metrics dashboards not rendering. !16589
+- Remove duplication of Licenses in Dependency List page. !16946
+- Backfill SPDX identifiers in software_licenses table. !17004
+- Monitor charts: Validate form for creating an alert before submitting. !17109
+- Hide Push rules link when you dont have a license installed. !17530
+- Operations Dashboard: fix minimum query message. !17574
+- Fix page layout for sidebar on designs view. !17579
+- Display error for invalid insights config. !17589
+- Display appropriate approval status icon next to license. !17613
+- Fix deduplication of WASC vulnerabilities in the Security dashboard. !17778
+- Fix burndown negative count edge case. !18053
+- Change design management empty state button style. !18060 (George Tsiolis)
+- Decouple dependency list parser from v1.0 license scanning report. !18103
+- Respect Group SSO Enforcement on projects where the user is an owner. !18154
+- Scoped labels do not remove old label in board sidebar. !18313
+- Restrict number of users input to positive numbers. !18381
+- Fix undefined method log_geo_deleted_event for MergeRequestDiff. !18405
+- Add default empty values to prevent parser errors from approving the Vulnerability-Check rule. !18423
+- Fix time tracking info when the sidebar is collapsed.
+- Fix Discussion tab counter on Issues.
+
+### Changed (18 changes, 1 of them is from the community)
+
+- Style burndown charts with gitlab-ui. !15463
+- Add epic_iid parameter to issues API. !15640
+- Use a single badge to show number of active alerts on metrics dashboards. !15789
+- Allow files with .svg extensions to be uploaded as designs for Design Management. !16160
+- Implement dismissal behaviour when dismissed vulnerabilities are hidden. !16207
+- Remove environment_metrics_show_multiple_dashboards feature flag. !16640
+- Make name an optional parameter of releases. !16647
+- Expose epics closed_at on API. !17156
+- Add static_context API param when editing GitHub project service. !17397
+- Support variable expansion in branch property of bridge jobs. !17430
+- Add environment dropdown to pod logs screen. !17532
+- Parse v2 license scanning reports. !17646
+- Remove broken HTML5 routing behaviour from Pipeline Security Dashboard. !17767
+- Change Prometheus Alert details list from bulleted to description list. !18116 (Vitali Tatarintev)
+- Check for software license violations using SPDX identifiers. !18300
+- Move 'Advanced search' message to search page title. !18349
+- Add alert message for feature 'require approval from code owners' being moved. !18715
+- Enable Productivity Analytics feature by default. !18754
+
+### Performance (1 change)
+
+- Reduce excessive GC on pull mirrors. !17931
+
+### Added (35 changes)
+
+- Allow Design Management files and data to be included in the project exporter/importer. !14702
+- Create system notes for design events. !14791
+- Paginate SCIM responses using count and startIndex. !14892
+- Front-End UI for design deletion. !15034
+- Add max issue count to lists. !15116
+- Sign in / sign up step for trial. !15289
+- Add notification for updated privacy policy. !15435
+- Show Billing Plan as Cards in profile and groups. !15437
+- Add Audit Event API. !15698
+- Add configurable Code Owner approvals for protected branches. !15862
+- Add Alerts Service to Projects. !16117
+- Add Conan check_credentials API endpoint. !16215
+- Initial endpoint for exposing Cycle Analytics stages for the new frontend. !16240
+- Add ability to multi select issue board cards. !16317
+- Add License-Check approval UI. !16371
+- Add links to associated releases on Tags page. !16479
+- Frontend implementation for improved trial sign-up experience for GitLab.com (SaaS) users. !16732
+- Return Todos for Designs via the REST API. !16885
+- Set active insights dashboard tab from hash fragment. !16904
+- Extend group IP restriction to Git activity. !16980
+- Inactivate pipeline retries for Merge Trains. !17065
+- Expose time when the build was generated. !17113
+- Add new table for recording commit counts per file. !17277
+- Add vendored template for Browser Performance Testing. !17319
+- Link Gitlab managed Prometheus alerts and issues. !17477
+- Disable insights tab navigation whilst current page loads. !17678
+- Drop all merge requests from merge trains when the project-level setting is disabled. !17774
+- Implement DAST for default branches. !17789
+- Add rack attack settings for prometheus and generic alert endpoint. !17859
+- Add Licenses list backend usage ping. !17925
+- Associate self-managed Prometheus Alerts and Issues. !18046
+- Operator can see all projects using an instance level cluster. !18173
+- Expose subscribed attribute for Epics in GraphQL. !18607
+- Expose epic participants on GraphQL. !18691
+- Adds a generic alert integration which can accept alerts from any source via a generic webhook receiver.
+
+### Other (4 changes)
+
+- Productivity analytics: Add scatterplot. !15569
+- Updated sidebar navigation icons to be horizontally centered when bar is condensed. !16820
+- Pin major version of SAST analyzers. !17110
+- Docs for protected branch code owner approval API. !17132
+
+
 ## 12.3.4
 ### Fixed (2 changes)

CHANGELOG.md

@@ -2,6 +2,325 @@
 documentation](doc/development/changelog.md) for instructions on adding your own
 entry.
+## 12.4.0
+
+### Security (14 changes)
+
+- HTML-escape search term in empty message. !18319
+- Fix private feature Elasticsearch leak.
+- Prevent bypassing email verification using Salesforce.
+- Fix new project path being disclosed through unsubscribe link of issue/merge requests.
+- Do not show resource label events referencing not accessible labels.
+- Check permissions before showing head pipeline blocking merge requests.
+- Cancel all running CI jobs triggered by the user who is just blocked.
+- Do not disclose project milestones on group milestones page when project milestones access is disabled in project settings.
+- Display only participants that user has permission to see on milestone page.
+- Fix Gitaly SearchBlobs flag RPC injection.
+- Add a policy check for system notes that may not be visible due to cross references to private items.
+- Limit search for IID to a type to avoid leaking records with the same IID that the user does not have access to.
+- Prevent GitLab accounts takeover if SAML is configured.
+- Only render fixed number of mermaid blocks.
+
+### Fixed (103 changes, 12 of them are from the community)
+
+- When user toggles task list item, keep details open until user closes the details manually. !16153
+- Fix formatting welcome screen external users. !16667
+- Fix signup link in admin area not being disabled. !16726 (Illya Klymov)
+- Fix routing bugs in security dashboards. !16738
+- Fix Jira integration favicon image with relative URL. !16802
+- Add timeout mechanism for CI config validation. !16807
+- Fix for count in todo badge when user has over 1,000 todos. Will now correctly display todo count after user marks some todos as done. !16844 (Jesse Hall @jessehall3)
+- Naming a project "shared" will no longer automatically open the "Shared Projects" tab. !16847 (Jesse Hall @jessehall3)
+- Adds the ability to delete single tags from the docker registry. Fix the issue that caused all related tags and image to be deleted at the same time. !16886
+- Changed confidential quick action to only be available on non confidential issues. !16902 (Marc Schwede)
+- Stop sidebar icons from jumping when expanded & collapsed. !16971
+- Set name and updated_at properly in GitHub ReleaseImporter. !17020
+- Remove thin white line at top of diff view code blocks. !17026
+- Show correct CI indicator when build succeeded with warnings. !17034
+- Create a persistent ref per pipeline for keeping pipelines run from force-push and merged results. !17043
+- Move SMAU usage counters to the UsageData count field. !17074
+- Allow maintainers to toggle write permission for public deploy keys. !17210
+- Fix GraphQL for read-only instances. !17225
+- Fix visibility level error when updating group from API. !17227 (Mathieu Parent)
+- Fix stylelint errors in epics.scss. !17243
+- Fix new discussion replies sometimes showing up twice. !17255
+- Adjust unnapliable suggestions in expanded lines. !17286
+- Show all groups user belongs to in Notification settings. !17303
+- Alphabetically sorts selected sidebar labels. !17309
+- Show issue weight when weight is 0. !17329 (briankabiro)
+- Generate LFS token authorization for user LFS requests. !17332
+- Backfill releases table updated_at column and add not null constraints to created_at and updated_at. !17400
+- Log Sidekiq exceptions properly in JSON format. !17412
+- Redo fix for related issues border radius. !17480
+- Show the original branch name and link of merge request in pipeline emails. !17513
+- Fixes issues with the security reports migration. !17519
+- Users can view the blame or history of a file with newlines in its filename. !17543 (Jesse Hall @jessehall3)
+- Display reCAPTCHA modal when making issue public. !17553
+- Fix css selector for details in issue description. !17557
+- Prevents a group path change when a project inside the group has container registry images. !17583
+- Show 20 labels in dropdown instead of 5. !17596
+- Nullify platform Kubernetes namespace if blank. !17657
+- Fix Issue: WebIDE asks for confirmation to leave the page when committing and creating a new MR. !17671
+- Catch unhandled exceptions in health checks. !17694
+- Suppress error messages shown when navigating to a new page. !17706
+- Specify sort order explicitly for Group and Project audit events. !17739
+- Merge Request: Close JIRA issues when issues are disabled. !17743
+- Disable gitlab-workhorse static error page on health endpoints. !17770
+- Fix notes race condition when linking to specific note. !17777
+- Fix relative positioning when moving items down and there is no space. !17781
+- Fix project imports for pipelines for merge requests. !17799
+- Increase the limit of includes in CI file to 100. !17807
+- Geo: Fix race condition for container synchronization. !17823
+- Geo: Invalidate cache after refreshing foreign tables. !17885
+- Abort Merge When Pipeline Succeeds when Fast Forward merge is impossible. !17886
+- Fix viewing merge reqeust from a fork that's being deleted. !17894
+- Fix empty security dashboard for public projects. !17915
+- Fix inline rendering of videos for uploads with uppercase file extensions. !17924
+- Hide redundant labels in issue boards. !17937
+- Time window filter in monitor dashboard gets reset. !17972
+- Use cache_method_asymmetrically with Repository#has_visible_content?. !17975
+- Allow users to compare Git revisions on a read-only instance. !18038
+- Enable Google API retries for uploads. !18040
+- Fix bug with new wiki not being indexed. !18051
+- Stops the expand button in reports from expanding. !18064
+- Make sure project insights stick on its own. !18082
+- Embed metrics time window scroll no longer affects other embeds. !18109
+- Fix broken notes avatar rendering in Chrome 77. !18110
+- Ignore incoming emails with X-Autoreply header. !18118
+- Enable grid, frame and stripes styling on AsciiDoc tables. !18165 (Guillaume Grossetie)
+- Add backend support for selecting custom templates by ID. !18178
+- Fix notifications for private group mentions in Notes, Issues, and Merge Requests. !18183
+- Do not strip forwarded message body when creating an issue from Service Desk email. !18196
+- Fix protected branch detection used by notification service. !18221
+- Fix error where helper was incorrectly returning `true`. !18231
+- Adjust placeholder to solve misleading regex. !18235
+- Fix Flaky spec/finders/members_finder_spec.rb:85. !18257 (Jacopo Beschi @jacopo-beschi)
+- Fix 500 error on clicking to LetsEncrypt Terms of Service. !18263
+- Fix error tracking table layout on small screens. !18325
+- GitHub import: Handle nil published_at dates. !18355
+- Do not allow deactivated users to use slash commands. !18365
+- Fix creating epics with dates from api. !18393
+- JIRA Service: Improve username/email validation. !18397
+- Stopped CRD apply retrying from allowing silent failures. !18421
+- Fix erroneous "No activities found" message. !18434
+- Support ES searches for project snippets. !18459
+- Fix styling of set status emoji picker. !18509
+- Fix showing diff when it has legacy diff notes. !18510
+- JIRA Integration API URL works having a trailing slash. !18526
+- Fixes embedded metrics chart tooltip spacing. !18543
+- Bump GITLAB_ELASTICSEARCH_INDEXER_VERSION=v1.4.0. !18558
+- Fix pod logs failure when pod contains more than 1 container. !18574
+- Prevent the slash command parser from removing leading whitespace from content that is unrelated to slash commands. !18589 (Jared Deckard)
+- Fix inability to set snippet visibility via API. !18612
+- Fix Web IDE tree not updating modified status. !18647
+- Fix button link foreground color. !18669
+- Resolve missing design system notes icons. !18693
+- Remove duplicate primary button in dashboard snippets. !32048 (George Tsiolis)
+- Allow to view productivity analytics page without a license. !33876
+- Fix container registry delete tag modal title and button. !34032
+- Fixes variables overflowing in sm screens.
+- Update top nav bar to fit all content in at all screen sizes.
+- Fix permissions for group milestones.
+- Removes Collapsible Sections from Job Log.
+- Fixes job overflow in stages dropdown.
+- Fix moved help URL for monitoring performance.
+- Fix issue with wiki TOC links being treated as external links. (Oren Kanner)
+- Show error message when setting an invalid group ID for the performance bar.
+
+### Deprecated (1 change)
+
+- Removing cleanup:repo, cleanup:dirs. !18087
+
+### Changed (51 changes, 3 of them are from the community)
+
+- Links on Releases page to commits and tags. !16128
+- Add status to deployments and state to environments in API responses. !16242
+- Use search scope label in empty results message. !16324
+- Add step 2 of the experimental signup flow. !16583
+- Add property to enable metrics dashboards to be rearranged. !16605
+- Allow intra-project MR dependencies. !16799
+- Use scope param instead of hide_dismissed. !16834
+- Add empty state in file search. !16851
+- Warn before applying issue templates. !16865
+- MR Test Summary now shows errors as failures. !17039
+- Add support for the association of multiple milestones to the Releases page. !17091
+- Display if an issue was moved in issue list. !17102
+- Improve UI for admin/projects and group/settings/projects pages. !17247
+- Update registry tag delete popup message. !17257
+- Show the "Set up CI/CD" prompt in empty repositories when applicable. !17274 (Ben McCormick)
+- Knative version bump 0.6 -> 0.7. !17367 (Chris Baumbauer)
+- Fix usability problems with the file template picker. !17522
+- Make commit status created for any pipelines. !17524 (Aufar Gilbran)
+- Add warnings to performance bar when page shows signs of poor performance. !17612
+- Banners should only be dismissable by clicking x button. !17642
+- Changes response body of liveness check to be more accurate. !17655
+- Enable Request Access functionality by default for new projects and groups. !17662
+- Add more attributes to issues GraphQL endpoint. !17802
+- Improve admin/system_info page ui. !17829
+- Adds management project for a cluster. !17866
+- Upgrade gitlab-workhorse to 8.12.0. !17892
+- Geo: Fix instruction from rake geo:gitlab:check. !17895
+- Upgrade to Gitaly v1.66.0. !17900
+- Do not start mirroring via API when paused. !17930
+- Use MR links in PipelinePresenter#ref_text for branch pipelines. !17947
+- Avoid knative and prometheus uninstall race condition. !18020
+- Deprecate usage of state column for issues and merge requests. !18099
+- Add missing page title to projects/container-registry. !18114
+- Port over EE pipeline functionality to CE. !18136
+- Aggregate push events when there are too many. !18239
+- Cleanup background migrations for any approval rules. !18256
+- Container registry tag(s) delete button pluralization. !18260
+- Create clusters with VPC-Native enabled. !18284
+- Update cluster link text. !18322
+- Upgrade to Gitaly v1.67.0. !18326
+- Improve UI of documentation under /help. !18331
+- Cross-link unreplicated Geo types to issues. !18443
+- Make designs read-only if the issue has been moved, or if its discussion has been locked. !18551
+- Do not show new issue button on archived projects. !18590
+- Increase group avatar size to 40px. !18654
+- Sort vulnerabilities by severity then confidence for dashboard and pipeline views. !18675
+- Add timeouts for each RPC call. !31766
+- Add more specific message to clarify the role of empty images in container registry. !32919
+- Embed Jaeger in Gitlab UI.
+- Use text instead of icon for recent searches dropdown.
+- Export liveness and readiness probes.
+
+### Performance (25 changes, 1 of them is from the community)
+
+- Limit diverging commit counts requests. !16737
+- Use GetBlobs RPC for uri type. !16824
+- Reduce Gitaly calls when viewing a commit. !17095
+- Limit snippets search count. !17585
+- Narrow snippet search scope in GitLab.com. !17625
+- Handle wiki and graphql attachments in gitlab-workhorse. !17690
+- Reduce lock contention of deployment creation by allocating IID outside of the pipeline transaction. !17696
+- Update PumaWorkerKiller defaults. !17758
+- Add trigram index on snippet content. !17806
+- Fix Gitaly N+1 queries in related merge requests API. !17850
+- Don't execute webhooks/services when above limit. !17874
+- Only schedule updating push-mirrors once per push. !17902
+- Show only personal snippets on explore page. !18092
+- Priority bump authorized_projects sidekiq queue. !18125
+- Avoid dumping files on disk when direct_upload is enabled. !18135
+- Check if mapping is empty before caching in File Collections. !18290 (briankabiro)
+- Avoid unnecessary locks on internal_ids. !18328
+- Fix N+1 queries in Jira Development Panel API endpoint. !18329
+- Optimize SQL requests for BlameController and CommitsController. !18342
+- Remove N+1 for fetching commits signatures. !18389
+- Reduce idle in transaction time when updating a merge request. !18493
+- Use cascading deletes for deleting logs upon deleting a webhook. !18642
+- Replace index on ci_triggers. !18652
+- Hide license breakdown in /admin if user count is high. !18825
+- Cache branch and tag names as Redis sets. !30476
+
+### Added (78 changes, 12 of them are from the community)
+
+- Adds sorting of packages at the project level. !15448
+- Add projects.only option to Insights. !15930
+- Add kubernetes section to group runner settings. !16338
+- Enable Cloud Run on GKE cluster creation. !16566
+- Add file matching rule to flexible CI rules. !16574
+- Enable preview of private artifacts. !16675 (Tuomo Ala-Vannesluoma)
+- Upgrade Gitaly to v1.64. !16788
+- Render xml artifact files in GitLab. !16790
+- Add GitHub & Gitea importers project filtering. !16823
+- Add project filtering to Bitbucket Cloud import. !16828
+- Provides internationalization support to chart legends. !16832
+- Expose name property in imports API. !16848
+- Add allowFilter and allowAnySHA1InWant for partial clones. !16850
+- [ObjectStorage] Allow migrating back to local storage. !16868
+- Require admins to enter admin-mode by re-authenticating before performing administrative operations. !16981 (Roger Rüttimann & Diego Louzán)
+- Deactivate a user (with self-service reactivation). !17037
+- Add database tables to store AWS roles and cluster providers. !17057
+- Collect docker registry related metrics. !17063
+- Allow releases to be targeted by URL anchor links on the Releases page. !17150
+- Add project_pages_metadata DB table. !17197
+- Add index on ci_builds for successful Pages deploys. !17204
+- Creation of Evidence collection of new releases. !17217
+- API: Add missing group parameters. !17220 (Mathieu Parent)
+- Allow to exclude ancestor groups on group labels API. !17221 (Mathieu Parent)
+- Added 'copy link' in epic comment dropdown. !17224
+- Add columns for per project/group max pages/artifacts sizes. !17231
+- Create table for grafana api token for metrics embeds. !17234
+- Add proper label REST API for update, delete and promote. !17239 (Mathieu Parent)
+- Allow cross-project pipeline triggering with CI_JOB_TOKEN in core. !17251
+- Add user_id and created_at columns to design_management_versions table. !17316
+- Add pull_mirror_branch_prefix column on projects table. !17368
+- Expose web_url for epics on API. !17380
+- Improve time window filtering on metrics dashboard. !17554
+- Group level Container Registry browser. !17615
+- Add API for manually creating and updating deployments. !17620
+- Introduce diffs_batch JSON endpoint for paginated diffs. !17651
+- Web IDE button should fork and open forked project when selected from read-only project. !17672
+- Allow users to be searched with a @ prefix. !17742
+- Add individual inherited member lookup API. !17744
+- Preserve custom .gitlab-ci.yml config path when forking. !17817 (Mathieu Parent)
+- Introduce CI_PROJECT_TITLE as predefined environment variable. !17849 (Nejc Habjan)
+- Feature enabling embedded audio elements in markdown. !17860 (Jesse Hall @jessehall3)
+- Add 'New release' to the project custom notifications. !17877
+- Added timestamps (created_at and updated_at) to API pipelines response. !17911
+- Added timestamp (updated_at) to API deployments response. !17913
+- Add pipeline preparing status icons. !17923
+- Creates Vue and Vuex app to render exposed artifacts. !17934
+- Add web_exporter to expose Prometheus metrics. !17943
+- Schedule background migration to populate pages metadata. !17993
+- Add "Edit Release" page. !18033
+- Unpin ingress image version, upgrade chart to 1.22.1. !18047
+- Adds sorting of packages at the group level. !18062
+- Introduce a lightweight diffs_metadata endpoint. !18104
+- Limit the number of comments on an issue, MR, or commit. !18111
+- Introduce new Ansi2json parser to convert job logs to JSON. !18133
+- Use new Ansi2json job log converter via feature flag. !18134
+- Snowplow custom events for Monitor: Health Product Categories. !18157
+- Support Create/Read/Destroy operations in Feature Flag API. !18198
+- Add two new predefined stages to pipelines. !18205
+- Add endpoint to proxy requests to grafana's proxy endpoint. !18210
+- Add ability to query todos using GraphQL. !18218
+- Include in the callout message a list of jobs that caused missing dependencies failure. !18219
+- Adds login input with copy box and supporting copy to empty container registry view. !18244 (nate geslin)
+- Add max_artifacts_size fields under project and group settings. !18286
+- Provide Merge requests and Issue links through the Release API. !18311
+- Adds separate parsers for mentions of users, groups, projects in markdown content. !18318
+- Add matching branch info to branch column. !18352
+- Users can preview audio files in a repository. !18354 (Jesse Hall @jessehall3)
+- Add edit button to release blocks on Releases page. !18411
+- Add "Custom HTTP Git clone URL root" setting. !18422
+- Add support for epic update through GraphQL API. !18440
+- Expose subscribed attribute for epic on API. !18475
+- Geo: Enable replicating uploads, LFS objects, and artifacts in Object Storage. !18482
+- Show related merge requests in pipeline view. !18697
+- Allow users to configure protected paths from Admin panel. !31246
+- persist the refs when open the link of refs in a new tab of browser. !31998 (minghuan lei)
+- Add first_parent option to list commits api. !32410 (jhenkens)
+- Allow users to add and remove zoom rooms on an issue using quick action commands.
+
+### Other (23 changes, 5 of them are from the community)
+
+- Sync issuables state_id with null values. !16480
+- Experimental separate sign up flow. !16482
+- Upgrade Rouge to v3.11.0. !17011
+- Better job naming for Docker.gitlab-ci.yml. !17218 (luca.orlandi@gmail.com)
+- Update GitLab Runner Helm Chart to 0.9.0. !17326
+- Change welcome message and make translatable. !17391
+- Remove map-get($grid-breakpoints, xs) for max-width. !17420 (Takuya Noguchi)
+- Document Git LFS and max file size interaction. !17609
+- Refactor email notification code. !17741 (briankabiro)
+- Ignore id column of ci_build_trace_sections table. !17805
+- Extend graphql query endpoint for merge requests to return more attributes to support sidebar implementation. !17813
+- Project list: Align star icons. !17833
+- Moves the license compliance reports to the Backend. !17905
+- Fixes wrong link on Protected paths admin settings. !17945
+- Update Pages to v1.11.0. !18010
+- Refactor checksum code in uploads. !18065 (briankabiro)
+- Make instance configuration user friendly. !18363 (Takuya Noguchi)
+- Update Workhorse to v8.14.0. !18391
+- Attribute each Sidekiq worker to a feature category. !18462
+- Update GitLab Shell to v10.2.0. !18735
+- Use correct icons for issue actions.
+- Increase color contrast of select option path.
+- Remove Postgresql specific setup tasks and move to schema.rb.
+
+
 ## 12.3.4
 ### Fixed (2 changes)

app/assets/javascripts/clusters/clusters_bundle.js

@@ -37,6 +37,7 @@ export default class Clusters {
       installJupyterPath,
       installKnativePath,
       updateKnativePath,
+      installElasticStackPath,
       installPrometheusPath,
       managePrometheusPath,
       clusterEnvironmentsPath,
@@ -86,6 +87,7 @@ export default class Clusters {
       installJupyterEndpoint: installJupyterPath,
       installKnativeEndpoint: installKnativePath,
       updateKnativeEndpoint: updateKnativePath,
+      installElasticStackEndpoint: installElasticStackPath,
       clusterEnvironmentsEndpoint: clusterEnvironmentsPath,
     });

app/assets/javascripts/clusters/components/applications.vue

@@ -12,6 +12,7 @@ import certManagerLogo from 'images/cluster_app_logos/cert_manager.png';
 import knativeLogo from 'images/cluster_app_logos/knative.png';
 import meltanoLogo from 'images/cluster_app_logos/meltano.png';
 import prometheusLogo from 'images/cluster_app_logos/prometheus.png';
+import elasticStackLogo from 'images/cluster_app_logos/elastic_stack.png';
 import { s__, sprintf } from '../../locale';
 import applicationRow from './application_row.vue';
 import clipboardButton from '../../vue_shared/components/clipboard_button.vue';
@@ -91,6 +92,7 @@ export default {
     knativeLogo,
     meltanoLogo,
     prometheusLogo,
+    elasticStackLogo,
   }),
   computed: {
     isProjectCluster() {
@@ -114,6 +116,9 @@ export default {
     certManagerInstalled() {
       return this.applications.cert_manager.status === APPLICATION_STATUS.INSTALLED;
     },
+    enableClusterApplicationElasticStack() {
+      return gon.features && gon.features.enableClusterApplicationElasticStack;
+    },
     ingressDescription() {
       return sprintf(
         _.escape(
@@ -168,6 +173,12 @@ export default {
     jupyterHostname() {
       return this.applications.jupyter.hostname;
     },
+    elasticStackInstalled() {
+      return this.applications.elastic_stack.status === APPLICATION_STATUS.INSTALLED;
+    },
+    elasticStackKibanaHostname() {
+      return this.applications.elastic_stack.kibana_hostname;
+    },
     knative() {
       return this.applications.knative;
     },
@@ -542,6 +553,75 @@ export default {
           />
         </div>
       </application-row>
+      <application-row
+        v-if="enableClusterApplicationElasticStack"
+        id="elastic_stack"
+        :logo-url="elasticStackLogo"
+        :title="applications.elastic_stack.title"
+        :status="applications.elastic_stack.status"
+        :status-reason="applications.elastic_stack.statusReason"
+        :request-status="applications.elastic_stack.requestStatus"
+        :request-reason="applications.elastic_stack.requestReason"
+        :version="applications.elastic_stack.version"
+        :chart-repo="applications.elastic_stack.chartRepo"
+        :update-available="applications.elastic_stack.updateAvailable"
+        :installed="applications.elastic_stack.installed"
+        :install-failed="applications.elastic_stack.installFailed"
+        :update-successful="applications.elastic_stack.updateSuccessful"
+        :update-failed="applications.elastic_stack.updateFailed"
+        :uninstallable="applications.elastic_stack.uninstallable"
+        :uninstall-successful="applications.elastic_stack.uninstallSuccessful"
+        :uninstall-failed="applications.elastic_stack.uninstallFailed"
+        :disabled="!helmInstalled"
+        :install-application-request-params="{
+          kibana_hostname: applications.elastic_stack.kibana_hostname,
+        }"
+        title-link="https://github.com/helm/charts/tree/master/stable/elastic-stack"
+      >
+        <div slot="description">
+          <p>
+            {{
+              s__(
+                `ClusterIntegration|The elastic stack collects logs from all pods in your cluster`,
+              )
+            }}
+          </p>
+
+          <template v-if="ingressExternalEndpoint">
+            <div class="form-group">
+              <label for="elastic-stack-kibana-hostname">{{
+                s__('ClusterIntegration|Kibana Hostname')
+              }}</label>
+
+              <div class="input-group">
+                <input
+                  v-model="applications.elastic_stack.kibana_hostname"
+                  :readonly="elasticStackInstalled"
+                  type="text"
+                  class="form-control js-hostname"
+                />
+                <span class="input-group-btn">
+                  <clipboard-button
+                    :text="elasticStackKibanaHostname"
+                    :title="s__('ClusterIntegration|Copy Kibana Hostname')"
+                    class="js-clipboard-btn"
+                  />
+                </span>
+              </div>
+
+              <p v-if="ingressInstalled" class="form-text text-muted">
+                {{
+                  s__(`ClusterIntegration|Replace this with your own hostname if you want.
+                If you do so, point hostname to Ingress IP Address from above.`)
+                }}
+                <a :href="ingressDnsHelpPath" target="_blank" rel="noopener noreferrer">
+                  {{ __('More information') }}
+                </a>
+              </p>
+            </div>
+          </template>
+        </div>
+      </application-row>
     </div>
   </section>
 </template>

app/assets/javascripts/clusters/components/uninstall_application_confirmation_modal.vue

@@ -2,7 +2,16 @@
 import { GlModal } from '@gitlab/ui';
 import { sprintf, s__ } from '~/locale';
 import trackUninstallButtonClickMixin from 'ee_else_ce/clusters/mixins/track_uninstall_button_click';
-import { HELM, INGRESS, CERT_MANAGER, PROMETHEUS, RUNNER, KNATIVE, JUPYTER } from '../constants';
+import {
+  HELM,
+  INGRESS,
+  CERT_MANAGER,
+  PROMETHEUS,
+  RUNNER,
+  KNATIVE,
+  JUPYTER,
+  ELASTIC_STACK,
+} from '../constants';
 const CUSTOM_APP_WARNING_TEXT = {
   [HELM]: sprintf(
@@ -28,6 +37,7 @@ const CUSTOM_APP_WARNING_TEXT = {
   [JUPYTER]: s__(
     'ClusterIntegration|All data not committed to GitLab will be deleted and cannot be restored.',
   ),
+  [ELASTIC_STACK]: s__('ClusterIntegration|All data will be deleted and cannot be restored.'),
 };
 export default {

app/assets/javascripts/clusters/constants.js

@@ -51,7 +51,17 @@ export const KNATIVE = 'knative';
 export const RUNNER = 'runner';
 export const CERT_MANAGER = 'cert_manager';
 export const PROMETHEUS = 'prometheus';
-export const APPLICATIONS = [HELM, INGRESS, JUPYTER, KNATIVE, RUNNER, CERT_MANAGER, PROMETHEUS];
+export const ELASTIC_STACK = 'elastic_stack';
+export const APPLICATIONS = [
+  HELM,
+  INGRESS,
+  JUPYTER,
+  KNATIVE,
+  RUNNER,
+  CERT_MANAGER,
+  PROMETHEUS,
+  ELASTIC_STACK,
+];
 export const INGRESS_DOMAIN_SUFFIX = '.nip.io';

app/assets/javascripts/clusters/services/clusters_service.js

@@ -11,6 +11,7 @@ export default class ClusterService {
       prometheus: this.options.installPrometheusEndpoint,
       jupyter: this.options.installJupyterEndpoint,
       knative: this.options.installKnativeEndpoint,
+      elastic_stack: this.options.installElasticStackEndpoint,
     };
     this.appUpdateEndpointMap = {
       knative: this.options.updateKnativeEndpoint,

app/assets/javascripts/clusters/stores/clusters_store.js

@@ -5,6 +5,7 @@ import {
   JUPYTER,
   KNATIVE,
   CERT_MANAGER,
+  ELASTIC_STACK,
   RUNNER,
   APPLICATION_INSTALLED_STATUSES,
   APPLICATION_STATUS,
@@ -85,6 +86,11 @@ export default class ClusterStore {
           updateSuccessful: false,
           updateFailed: false,
         },
+        elastic_stack: {
+          ...applicationInitialState,
+          title: s__('ClusterIntegration|Elastic Stack'),
+          kibana_hostname: null,
+        },
       },
       environments: [],
       fetchingEnvironments: false,
@@ -198,12 +204,11 @@ export default class ClusterStore {
         this.state.applications.cert_manager.email =
           this.state.applications.cert_manager.email || serverAppEntry.email;
       } else if (appId === JUPYTER) {
-        this.state.applications.jupyter.hostname =
-          this.state.applications.jupyter.hostname ||
-          serverAppEntry.hostname ||
-          (this.state.applications.ingress.externalIp
-            ? `jupyter.${this.state.applications.ingress.externalIp}.nip.io`
-            : '');
+        this.state.applications.jupyter.hostname = this.updateHostnameIfUnset(
+          this.state.applications.jupyter.hostname,
+          serverAppEntry.hostname,
+          'jupyter',
+        );
       } else if (appId === KNATIVE) {
         if (!this.state.applications.knative.isEditingHostName) {
           this.state.applications.knative.hostname =
@@ -216,10 +221,26 @@ export default class ClusterStore {
       } else if (appId === RUNNER) {
         this.state.applications.runner.version = version;
         this.state.applications.runner.updateAvailable = updateAvailable;
+      } else if (appId === ELASTIC_STACK) {
+        this.state.applications.elastic_stack.kibana_hostname = this.updateHostnameIfUnset(
+          this.state.applications.elastic_stack.kibana_hostname,
+          serverAppEntry.kibana_hostname,
+          'kibana',
+        );
       }
     });
   }
+  updateHostnameIfUnset(current, updated, fallback) {
+    return (
+      current ||
+      updated ||
+      (this.state.applications.ingress.externalIp
+        ? `${fallback}.${this.state.applications.ingress.externalIp}.nip.io`
+        : '')
+    );
+  }
+
   toggleFetchEnvironments(isFetching) {
     this.state.fetchingEnvironments = isFetching;
   }

app/assets/javascripts/pages/projects/project.js

@@ -40,11 +40,6 @@ export default class Project {
         $label.text(activeText);
       });
-      $('#modal-geo-info').data({
-        cloneUrlSecondary: $this.attr('href'),
-        cloneUrlPrimary: $this.data('primaryUrl') || '',
-      });
-
       if (mobileCloneField) {
         mobileCloneField.dataset.clipboardText = url;
       } else {

app/controllers/clusters/applications_controller.rb

@@ -47,7 +47,7 @@ class Clusters::ApplicationsController < Clusters::BaseController
   end
   def cluster_application_params
-    params.permit(:application, :hostname, :email)
+    params.permit(:application, :hostname, :kibana_hostname, :email)
   end
   def cluster_application_destroy_params

app/controllers/clusters/clusters_controller.rb

@@ -15,6 +15,9 @@ class Clusters::ClustersController < Clusters::BaseController
   before_action only: [:new, :create_gcp] do
     push_frontend_feature_flag(:create_eks_clusters)
   end
+  before_action only: [:show] do
+    push_frontend_feature_flag(:enable_cluster_application_elastic_stack)
+  end
   helper_method :token_in_session

app/models/clusters/applications/elastic_stack.rb

+# frozen_string_literal: true
+
+module Clusters
+  module Applications
+    class ElasticStack < ApplicationRecord
+      VERSION = '1.8.0'
+
+      self.table_name = 'clusters_applications_elastic_stacks'
+
+      include ::Clusters::Concerns::ApplicationCore
+      include ::Clusters::Concerns::ApplicationStatus
+      include ::Clusters::Concerns::ApplicationVersion
+      include ::Clusters::Concerns::ApplicationData
+
+      default_value_for :version, VERSION
+
+      def set_initial_status
+        return unless not_installable?
+        return unless cluster&.application_ingress_available?
+
+        ingress = cluster.application_ingress
+        self.status = status_states[:installable] if ingress.external_ip_or_hostname?
+      end
+
+      def chart
+        'stable/elastic-stack'
+      end
+
+      def values
+        content_values.to_yaml
+      end
+
+      def install_command
+        Gitlab::Kubernetes::Helm::InstallCommand.new(
+          name: 'elastic-stack',
+          version: VERSION,
+          rbac: cluster.platform_kubernetes_rbac?,
+          chart: chart,
+          files: files
+        )
+      end
+
+      def uninstall_command
+        Gitlab::Kubernetes::Helm::DeleteCommand.new(
+          name: 'elastic-stack',
+          rbac: cluster.platform_kubernetes_rbac?,
+          files: files,
+          postdelete: post_delete_script
+        )
+      end
+
+      private
+
+      def specification
+        {
+          "kibana" => {
+            "ingress" => {
+              "hosts" => [kibana_hostname],
+              "tls" => [{
+                "hosts" => [kibana_hostname],
+                "secretName" => "kibana-cert"
+              }]
+            }
+          }
+        }
+      end
+
+      def content_values
+        YAML.load_file(chart_values_file).deep_merge!(specification)
+      end
+
+      def post_delete_script
+        [
+          Gitlab::Kubernetes::KubectlCmd.delete("pvc", "--selector", "release=elastic-stack")
+        ].compact
+      end
+    end
+  end
+end

app/models/clusters/applications/ingress.rb

@@ -40,7 +40,7 @@ module Clusters
       end
       def allowed_to_uninstall?
-        external_ip_or_hostname? && application_jupyter_nil_or_installable?
+        external_ip_or_hostname? && application_jupyter_nil_or_installable? && application_elastic_stack_nil_or_installable?
       end
       def install_command
@@ -91,6 +91,10 @@ module Clusters
       def application_jupyter_nil_or_installable?
         cluster.application_jupyter.nil? || cluster.application_jupyter&.installable?
       end
+
+      def application_elastic_stack_nil_or_installable?
+        cluster.application_elastic_stack.nil? || cluster.application_elastic_stack&.installable?
+      end
     end
   end
 end

app/models/clusters/applications/runner.rb

@@ -3,7 +3,7 @@
 module Clusters
   module Applications
     class Runner < ApplicationRecord
-      VERSION = '0.9.0'
+      VERSION = '0.10.0'
       self.table_name = 'clusters_applications_runners'

app/models/clusters/cluster.rb

@@ -18,7 +18,8 @@ module Clusters
       Applications::Prometheus.application_name => Applications::Prometheus,
       Applications::Runner.application_name => Applications::Runner,
       Applications::Jupyter.application_name => Applications::Jupyter,
-      Applications::Knative.application_name => Applications::Knative
+      Applications::Knative.application_name => Applications::Knative,
+      Applications::ElasticStack.application_name => Applications::ElasticStack
     }.merge(PROJECT_ONLY_APPLICATIONS).freeze
     DEFAULT_ENVIRONMENT = '*'
     KUBE_INGRESS_BASE_DOMAIN = 'KUBE_INGRESS_BASE_DOMAIN'
@@ -51,6 +52,7 @@ module Clusters
     has_one_cluster_application :runner
     has_one_cluster_application :jupyter
     has_one_cluster_application :knative
+    has_one_cluster_application :elastic_stack
     has_many :kubernetes_namespaces

app/models/issue.rb

@@ -206,7 +206,16 @@ class Issue < ApplicationRecord
     if self.confidential?
       "#{iid}-confidential-issue"
     else
-      "#{iid}-#{title.parameterize}"
+      branch_name = "#{iid}-#{title.parameterize}"
+
+      if branch_name.length > 100
+        truncated_string = branch_name[0, 100]
+        # Delete everything dangling after the last hyphen so as not to risk
+        # existence of unintended words in the branch name due to mid-word split.
+        branch_name = truncated_string[0, truncated_string.rindex("-")]
+      end
+
+      branch_name
     end
   end

app/serializers/cluster_application_entity.rb

@@ -8,6 +8,7 @@ class ClusterApplicationEntity < Grape::Entity
   expose :external_ip, if: -> (e, _) { e.respond_to?(:external_ip) }
   expose :external_hostname, if: -> (e, _) { e.respond_to?(:external_hostname) }
   expose :hostname, if: -> (e, _) { e.respond_to?(:hostname) }
+  expose :kibana_hostname, if: -> (e, _) { e.respond_to?(:kibana_hostname) }
   expose :email, if: -> (e, _) { e.respond_to?(:email) }
   expose :update_available?, as: :update_available, if: -> (e, _) { e.respond_to?(:update_available?) }
   expose :can_uninstall?, as: :can_uninstall

app/services/clusters/applications/base_service.rb

@@ -19,6 +19,10 @@ module Clusters
             application.hostname = params[:hostname]
           end
+          if application.has_attribute?(:kibana_hostname)
+            application.kibana_hostname = params[:kibana_hostname]
+          end
+
           if application.has_attribute?(:email)
             application.email = params[:email]
           end
@@ -60,7 +64,7 @@ module Clusters
       end
       def invalid_application?
-        unknown_application? || (!cluster.project_type? && project_only_application?)
+        unknown_application? || (!cluster.project_type? && project_only_application?) || (application_name == Applications::ElasticStack.application_name && !Feature.enabled?(:enable_cluster_application_elastic_stack))
       end
       def unknown_application?