Replace old hashes with new 1.9 ruby hashes (rebase)

features/steps/project/project_milestones.rb

@@ -19,7 +19,7 @@ class ProjectMilestones < Spinach::FeatureSteps
   end
   And 'I submit new milestone "v2.3"' do
-    fill_in "milestone_title", :with => "v2.3"
+    fill_in "milestone_title", with: "v2.3"
     click_button "Create milestone"
   end
@@ -32,9 +32,9 @@ class ProjectMilestones < Spinach::FeatureSteps
   And 'project "Shop" has milestone "v2.2"' do
     project = Project.find_by_name("Shop")
-    milestone = create(:milestone, :title => "v2.2", :project => project)
-    3.times { create(:issue, :project => project, :milestone => milestone) }
+    milestone = create(:milestone, title: "v2.2", project: project)
+    3.times { create(:issue, project: project, milestone: milestone) }
   end
   Given 'the milestone has open and closed issues' do

features/steps/project/project_network_graph.rb

@@ -16,7 +16,7 @@ class ProjectNetworkGraph < Spinach::FeatureSteps
   end
   And 'page should select "master" in select box' do
-    page.should have_selector '#ref_chzn span', :text => "master"
+    page.should have_selector '#ref_chzn span', text: "master"
   end
   And 'page should have "master" on graph' do
@@ -26,21 +26,21 @@ class ProjectNetworkGraph < Spinach::FeatureSteps
   end
   When 'I switch ref to "stable"' do
-    page.select 'stable', :from => 'ref'
+    page.select 'stable', from: 'ref'
     sleep 2
   end
   When 'I switch ref to "v2.1.0"' do
-    page.select 'v2.1.0', :from => 'ref'
+    page.select 'v2.1.0', from: 'ref'
     sleep 2
   end
   And 'page should select "stable" in select box' do
-    page.should have_selector '#ref_chzn span', :text => "stable"
+    page.should have_selector '#ref_chzn span', text: "stable"
   end
   And 'page should select "v2.1.0" in select box' do
-    page.should have_selector '#ref_chzn span', :text => "v2.1.0"
+    page.should have_selector '#ref_chzn span', text: "v2.1.0"
   end
   And 'page should have "stable" on graph' do
@@ -51,7 +51,7 @@ class ProjectNetworkGraph < Spinach::FeatureSteps
   When 'I looking for a commit by SHA of "v2.1.0"' do
     within ".content .search" do
-      fill_in 'q', :with => '98d6492'
+      fill_in 'q', with: '98d6492'
       find('button').click
     end
     sleep 2

features/steps/project/project_wiki.rb

@@ -16,7 +16,7 @@ class ProjectWiki < Spinach::FeatureSteps
   end
   Given 'I create the Wiki Home page' do
-    fill_in "Content", :with => '[link test](test)'
+    fill_in "Content", with: '[link test](test)'
     click_on "Save"
   end
@@ -42,7 +42,7 @@ class ProjectWiki < Spinach::FeatureSteps
   end
   And 'I change the content' do
-    fill_in "Content", :with => 'Updated Wiki Content'
+    fill_in "Content", with: 'Updated Wiki Content'
     click_on "Save"
   end

lib/gitlab/auth.rb

@@ -10,7 +10,7 @@ module Gitlab
         @user
       elsif @user = User.find_by_email(email)
         log.info "Updating legacy LDAP user #{email} with extern_uid => #{uid}"
-        @user.update_attributes(:extern_uid => uid, :provider => provider)
+        @user.update_attributes(extern_uid: uid, provider: provider)
         @user
       else
         create_from_omniauth(auth, true)
@@ -57,7 +57,7 @@ module Gitlab
       if @user = User.find_by_provider_and_extern_uid(provider, uid)
         @user
       elsif @user = User.find_by_email(email)
-        @user.update_attributes(:extern_uid => uid, :provider => provider)
+        @user.update_attributes(extern_uid: uid, provider: provider)
         @user
       else
         if Gitlab.config.omniauth['allow_single_sign_on']

lib/gitlab/popen.rb

@@ -2,7 +2,7 @@ module Gitlab
   module Popen
     def popen(cmd, path)
       vars = { "PWD" => path }
-      options = { :chdir => path }
+      options = { chdir: path }
       @cmd_output = ""
       @cmd_status = 0

lib/tasks/gitlab/backup.rake

@@ -4,7 +4,7 @@ namespace :gitlab do
   namespace :backup do
     # Create backup of GitLab system
     desc "GITLAB | Create a backup of the GitLab system"
-    task :create => :environment do
+    task create: :environment do
       warn_user_is_not_gitlab
       Rake::Task["gitlab:backup:db:create"].invoke
@@ -57,7 +57,7 @@ namespace :gitlab do
     # Restore backup of GitLab system
     desc "GITLAB | Restore a previously created backup"
-    task :restore => :environment do
+    task restore: :environment do
       warn_user_is_not_gitlab
       Dir.chdir(Gitlab.config.backup.path)
@@ -113,13 +113,13 @@ namespace :gitlab do
     end
     namespace :repo do
-      task :create => :environment do
+      task create: :environment do
         puts "Dumping repositories ...".blue
         Backup::Repository.new.dump
         puts "done".green
       end
-      task :restore => :environment do
+      task restore: :environment do
         puts "Restoring repositories ...".blue
         Backup::Repository.new.restore
         puts "done".green
@@ -127,13 +127,13 @@ namespace :gitlab do
     end
     namespace :db do
-      task :create => :environment do
+      task create: :environment do
         puts "Dumping database ... ".blue
         Backup::Database.new.dump
         puts "done".green
       end
-      task :restore => :environment do
+      task restore: :environment do
         puts "Restoring database ... ".blue
         Backup::Database.new.restore
         puts "done".green
@@ -141,13 +141,13 @@ namespace :gitlab do
     end
     namespace :uploads do
-      task :create => :environment do
+      task create: :environment do
         puts "Dumping uploads ... ".blue
         Backup::Uploads.new.dump
         puts "done".green
       end
-      task :restore => :environment do
+      task restore: :environment do
         puts "Restoring uploads ... ".blue
         Backup::Uploads.new.restore
         puts "done".green

lib/tasks/gitlab/bulk_add_permission.rake

 namespace :gitlab do
   namespace :import do
     desc "GITLAB | Add all users to all projects (admin users are added as masters)"
-    task :all_users_to_all_projects => :environment  do |t, args|
-      user_ids = User.where(:admin => false).pluck(:id)
-      admin_ids = User.where(:admin => true).pluck(:id)
+    task all_users_to_all_projects: :environment  do |t, args|
+      user_ids = User.where(admin: false).pluck(:id)
+      admin_ids = User.where(admin: true).pluck(:id)
       projects_ids = Project.pluck(:id)
       puts "Importing #{user_ids.size} users into #{projects_ids.size} projects"

lib/tasks/gitlab/cleanup.rake

 namespace :gitlab do
   namespace :cleanup do
     desc "GITLAB | Cleanup | Clean namespaces"
-    task :dirs => :environment  do
+    task dirs: :environment  do
       warn_user_is_not_gitlab
       remove_flag = ENV['REMOVE']
@@ -44,7 +44,7 @@ namespace :gitlab do
     end
     desc "GITLAB | Cleanup | Clean respositories"
-    task :repos => :environment  do
+    task repos: :environment  do
       warn_user_is_not_gitlab
       remove_flag = ENV['REMOVE']

lib/tasks/gitlab/import.rake

@@ -10,7 +10,7 @@ namespace :gitlab do
     #  * existing projects will be skipped
     #
     desc "GITLAB | Import bare repositories from git_host -> base_path into GitLab project instance"
-    task :repos => :environment do
+    task repos: :environment do
       git_base_path = Gitlab.config.gitlab_shell.repos_path
       repos_to_import = Dir.glob(git_base_path + '/*')
@@ -40,7 +40,7 @@ namespace :gitlab do
           user = User.admins.first
           project_params = {
-            :name => path,
+            name: path,
           }
           project = Projects::CreateContext.new(user, project_params).execute

lib/tasks/gitlab/setup.rake

 namespace :gitlab do
   desc "GITLAB | Setup production application"
-  task :setup => :environment do
+  task setup: :environment do
     setup_db
   end

lib/tasks/gitlab/test.rake

 namespace :gitlab do
   desc "GITLAB | Run both spinach and rspec"
-  task :test => ['spinach', 'spec']
+  task test: ['spinach', 'spec']
 end

lib/tasks/travis.rake

 desc "Travis run tests"
-task :travis => [
+task travis: [
   :spinach,
   :spec
 ]

spec/observers/users_project_observer_spec.rb

@@ -16,7 +16,7 @@ describe UsersProjectObserver do
     it "should send email to user" do
       subject.should_receive(:notification)
-      Event.stub(:create => true)
+      Event.stub(create: true)
       create(:users_project)
     end

spec/requests/api/groups_spec.rb

@@ -85,17 +85,17 @@ describe Gitlab::API do
       end
       it "should not create group, duplicate" do
-        post api("/groups", admin), {:name => "Duplicate Test", :path => group2.path}
+        post api("/groups", admin), {name: "Duplicate Test", path: group2.path}
         response.status.should == 404
       end
       it "should return 400 bad request error if name not given" do
-        post api("/groups", admin), { :path => group2.path }
+        post api("/groups", admin), { path: group2.path }
         response.status.should == 400
       end
       it "should return 400 bad request error if path not given" do
-        post api("/groups", admin), { :name => 'test' }
+        post api("/groups", admin), { name: 'test' }
         response.status.should == 400
       end
     end

spec/routing/admin_routing_spec.rb

@@ -56,15 +56,15 @@ describe Admin::UsersController, "routing" do
   end
 end
-#        team_admin_project GET    /admin/projects/:id/team(.:format)        admin/projects#team {:id=>/[^\/]+/}
-# team_update_admin_project PUT    /admin/projects/:id/team_update(.:format) admin/projects#team_update {:id=>/[^\/]+/}
-#            admin_projects GET    /admin/projects(.:format)                 admin/projects#index {:id=>/[^\/]+/}
-#                           POST   /admin/projects(.:format)                 admin/projects#create {:id=>/[^\/]+/}
-#         new_admin_project GET    /admin/projects/new(.:format)             admin/projects#new {:id=>/[^\/]+/}
-#        edit_admin_project GET    /admin/projects/:id/edit(.:format)        admin/projects#edit {:id=>/[^\/]+/}
-#             admin_project GET    /admin/projects/:id(.:format)             admin/projects#show {:id=>/[^\/]+/}
-#                           PUT    /admin/projects/:id(.:format)             admin/projects#update {:id=>/[^\/]+/}
-#                           DELETE /admin/projects/:id(.:format)             admin/projects#destroy {:id=>/[^\/]+/}
+#        team_admin_project GET    /admin/projects/:id/team(.:format)        admin/projects#team {id: /[^\/]+/}
+# team_update_admin_project PUT    /admin/projects/:id/team_update(.:format) admin/projects#team_update {id: /[^\/]+/}
+#            admin_projects GET    /admin/projects(.:format)                 admin/projects#index {id: /[^\/]+/}
+#                           POST   /admin/projects(.:format)                 admin/projects#create {id: /[^\/]+/}
+#         new_admin_project GET    /admin/projects/new(.:format)             admin/projects#new {id: /[^\/]+/}
+#        edit_admin_project GET    /admin/projects/:id/edit(.:format)        admin/projects#edit {id: /[^\/]+/}
+#             admin_project GET    /admin/projects/:id(.:format)             admin/projects#show {id: /[^\/]+/}
+#                           PUT    /admin/projects/:id(.:format)             admin/projects#update {id: /[^\/]+/}
+#                           DELETE /admin/projects/:id(.:format)             admin/projects#destroy {id: /[^\/]+/}
 describe Admin::ProjectsController, "routing" do
   it "to #index" do
     get("/admin/projects").should route_to('admin/projects#index')
@@ -75,9 +75,9 @@ describe Admin::ProjectsController, "routing" do
   end
 end
-# edit_admin_project_member GET      /admin/projects/:project_id/members/:id/edit(.:format)    admin/projects/members#edit {:id=>/[^\/]+/, :project_id=>/[^\/]+/}
-#      admin_project_member PUT      /admin/projects/:project_id/members/:id(.:format)         admin/projects/members#update {:id=>/[^\/]+/, :project_id=>/[^\/]+/}
-#                           DELETE   /admin/projects/:project_id/members/:id(.:format)         admin/projects/members#destroy {:id=>/[^\/]+/, :project_id=>/[^\/]+/}
+# edit_admin_project_member GET      /admin/projects/:project_id/members/:id/edit(.:format)    admin/projects/members#edit {id: /[^\/]+/, project_id: /[^\/]+/}
+#      admin_project_member PUT      /admin/projects/:project_id/members/:id(.:format)         admin/projects/members#update {id: /[^\/]+/, project_id: /[^\/]+/}
+#                           DELETE   /admin/projects/:project_id/members/:id(.:format)         admin/projects/members#destroy {id: /[^\/]+/, project_id: /[^\/]+/}
 describe Admin::Projects::MembersController, "routing" do
   it "to #edit" do
     get("/admin/projects/test/members/1/edit").should route_to('admin/projects/members#edit', project_id: 'test', id: '1')

spec/routing/project_routing_spec.rb

@@ -279,7 +279,7 @@ describe HooksController, "routing" do
   end
 end
-# project_commit GET    /:project_id/commit/:id(.:format) commit#show {:id=>/[[:alnum:]]{6,40}/, :project_id=>/[^\/]+/}
+# project_commit GET    /:project_id/commit/:id(.:format) commit#show {id: /[[:alnum:]]{6,40}/, project_id: /[^\/]+/}
 describe CommitController, "routing" do
   it "to #show" do
     get("/gitlabhq/commit/4246fb").should route_to('commit#show', project_id: 'gitlabhq', id: '4246fb')
@@ -375,7 +375,7 @@ describe NotesController, "routing" do
   end
 end
-# project_blame GET    /:project_id/blame/:id(.:format) blame#show {:id=>/.+/, :project_id=>/[^\/]+/}
+# project_blame GET    /:project_id/blame/:id(.:format) blame#show {id: /.+/, project_id: /[^\/]+/}
 describe BlameController, "routing" do
   it "to #show" do
     get("/gitlabhq/blame/master/app/models/project.rb").should route_to('blame#show', project_id: 'gitlabhq', id: 'master/app/models/project.rb')
@@ -383,7 +383,7 @@ describe BlameController, "routing" do
   end
 end
-# project_blob GET    /:project_id/blob/:id(.:format) blob#show {:id=>/.+/, :project_id=>/[^\/]+/}
+# project_blob GET    /:project_id/blob/:id(.:format) blob#show {id: /.+/, project_id: /[^\/]+/}
 describe BlobController, "routing" do
   it "to #show" do
     get("/gitlabhq/blob/master/app/models/project.rb").should route_to('blob#show', project_id: 'gitlabhq', id: 'master/app/models/project.rb')
@@ -392,7 +392,7 @@ describe BlobController, "routing" do
   end
 end
-# project_tree GET    /:project_id/tree/:id(.:format) tree#show {:id=>/.+/, :project_id=>/[^\/]+/}
+# project_tree GET    /:project_id/tree/:id(.:format) tree#show {id: /.+/, project_id: /[^\/]+/}
 describe TreeController, "routing" do
   it "to #show" do
     get("/gitlabhq/tree/master/app/models/project.rb").should route_to('tree#show', project_id: 'gitlabhq', id: 'master/app/models/project.rb')
@@ -400,9 +400,9 @@ describe TreeController, "routing" do
   end
 end
-# project_compare_index GET    /:project_id/compare(.:format)             compare#index {:id=>/[^\/]+/, :project_id=>/[^\/]+/}
-#                       POST   /:project_id/compare(.:format)             compare#create {:id=>/[^\/]+/, :project_id=>/[^\/]+/}
-#       project_compare        /:project_id/compare/:from...:to(.:format) compare#show {:from=>/.+/, :to=>/.+/, :id=>/[^\/]+/, :project_id=>/[^\/]+/}
+# project_compare_index GET    /:project_id/compare(.:format)             compare#index {id: /[^\/]+/, project_id: /[^\/]+/}
+#                       POST   /:project_id/compare(.:format)             compare#create {id: /[^\/]+/, project_id: /[^\/]+/}
+#       project_compare        /:project_id/compare/:from...:to(.:format) compare#show {from: /.+/, to: /.+/, id: /[^\/]+/, project_id: /[^\/]+/}
 describe CompareController, "routing" do
   it "to #index" do
     get("/gitlabhq/compare").should route_to('compare#index', project_id: 'gitlabhq')

spec/support/valid_commit.rb

@@ -9,7 +9,7 @@ module ValidCommit
   C_FILE_PATH = "app/models"
   C_FILES = [".gitkeep", "ability.rb", "commit.rb", "issue.rb", "key.rb", "mailer_observer.rb", "merge_request.rb", "note.rb", "project.rb", "protected_branch.rb", "repository.rb", "snippet.rb", "tree.rb", "user.rb", "users_project.rb", "web_hook.rb", "wiki.rb"]
-  BLOB_FILE = %{%h3= @key.title\n%hr\n%pre= @key.key\n.actions\n  = link_to 'Remove', @key, :confirm => 'Are you sure?', :method => :delete, :class => \"btn danger delete-key\"\n\n\n}
+  BLOB_FILE = %{%h3= @key.title\n%hr\n%pre= @key.key\n.actions\n  = link_to 'Remove', @key, confirm: 'Are you sure?', method: :delete, class: \"btn danger delete-key\"\n\n\n}
   BLOB_FILE_PATH = "app/views/keys/show.html.haml"
 end

spec/tasks/gitlab/backup_rake_spec.rb

@@ -22,21 +22,21 @@ describe 'gitlab:app namespace rake task' do
     context 'gitlab version' do
       before do
-        Dir.stub :glob => []
+        Dir.stub glob: []
         Dir.stub :chdir
-        File.stub :exists? => true
-        Kernel.stub :system => true
+        File.stub exists?: true
+        Kernel.stub system: true
       end
       let(:gitlab_version) { %x{git rev-parse HEAD}.gsub(/\n/,"") }
       it 'should fail on mismach' do
-        YAML.stub :load_file => {:gitlab_version => gitlab_version.reverse}
+        YAML.stub load_file: {gitlab_version: gitlab_version.reverse}
         expect { run_rake_task }.to raise_error SystemExit
       end
       it 'should invoke restoration on mach' do
-        YAML.stub :load_file => {:gitlab_version => gitlab_version}
+        YAML.stub load_file: {gitlab_version: gitlab_version}
         Rake::Task["gitlab:backup:db:restore"].should_receive :invoke
         Rake::Task["gitlab:backup:repo:restore"].should_receive :invoke
         expect { run_rake_task }.to_not raise_error SystemExit