Merge branch 'create-build-qa-image-for-all-pipelines' into 'master'

Make sure 'build-qa-image' is created for all pipelines

See merge request gitlab-org/gitlab-ce!32570

(cherry picked from commit d548766c)

a22646af Ensure 'build-qa-image' is created for all pipelines except docs & qa
fb51de2e Introduce a new 'package-and-qa-manual:master' job

.gitlab/ci/qa.gitlab-ci.yml

 .package-and-qa-base:
   image: ruby:2.6-alpine
   stage: qa
-  needs: ["build-qa-image", "gitlab:assets:compile pull-cache"]
   dependencies: []
   variables:
     GIT_DEPTH: "1"
@@ -20,14 +19,24 @@ package-and-qa-manual:
   extends:
     - .package-and-qa-base
     - .except-docs-qa
-  when: manual
   except:
-    - master
-    - /(^docs[\/-].+|.+-docs$)/
-    - /(^qa[\/-].*|.*-qa$)
+    refs:
+      - master
+  needs: ["build-qa-image", "gitlab:assets:compile pull-cache"]
+  when: manual
+
+package-and-qa-manual:master:
+  extends:
+    - .package-and-qa-base
+  needs: ["build-qa-image", "gitlab:assets:compile"]
+  only:
+    refs:
+      - master
+  when: manual
 package-and-qa:
   extends: .package-and-qa-base
+  needs: ["build-qa-image", "gitlab:assets:compile pull-cache"]
   allow_failure: true
   only:
     - /(^qa[\/-].*|.*-qa$)/@gitlab-org/gitlab-ce

.gitlab/ci/review.gitlab-ci.yml

@@ -22,7 +22,9 @@
     - source scripts/utils.sh
 .review-docker:
-  extends: .review-base
+  extends:
+    - .default-tags
+    - .default-retry
   image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-alpine
   services:
     - docker:19.03.0-dind
@@ -36,7 +38,13 @@
     QA_IMAGE: "${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab/${CI_PROJECT_NAME}-qa:${CI_COMMIT_REF_SLUG}"
 build-qa-image:
-  extends: .review-docker
+  extends:
+    - .review-docker
+    - .except-docs-qa
+  only:
+    refs:
+      - branches@gitlab-org/gitlab-ce
+      - branches@gitlab-org/gitlab-ee
   stage: test
   script:
     - time docker build --cache-from ${LATEST_QA_IMAGE} --tag ${QA_IMAGE} --file ./qa/Dockerfile ./
@@ -124,7 +132,9 @@ review-stop:
   artifacts: {}
 .review-qa-base:
-  extends: .review-docker
+  extends:
+    - .review-docker
+    - .review-only
   retry: 2
   stage: qa
   variables: