Skip to content
Snippets Groups Projects
Commit 77d0e41d authored by Nihad Abbasov's avatar Nihad Abbasov
Browse files

fix API route to delete project hook

parent 8b65d069
No related branches found
No related tags found
1 merge request!3856fix API route to delete project hook
Loading
Loading
@@ -274,7 +274,7 @@ module Gitlab
# hook_id (required) - The ID of hook to delete
# Example Request:
# DELETE /projects/:id/hooks/:hook_id
delete ":id/hooks" do
delete ":id/hooks/:hook_id" do
authorize! :admin_project, user_project
required_attributes! [:hook_id]
 
Loading
Loading
Loading
Loading
@@ -467,21 +467,21 @@ describe Gitlab::API do
end
end
 
describe "DELETE /projects/:id/hooks" do
describe "DELETE /projects/:id/hooks/:hook_id" do
it "should delete hook from project" do
expect {
delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
}.to change {project.hooks.count}.by(-1)
response.status.should == 200
end
 
it "should return success when deleting hook" do
delete api("/projects/#{project.id}/hooks", user), hook_id: hook.id
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
response.status.should == 200
end
 
it "should return success when deleting non existent hook" do
delete api("/projects/#{project.id}/hooks", user), hook_id: 42
delete api("/projects/#{project.id}/hooks/42", user)
response.status.should == 200
end
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment