Skip to content
Snippets Groups Projects
Commit 7d18c4d2 authored by Stan Hu's avatar Stan Hu
Browse files

Truncate merge request titles with periods instead of ellipsis

parent acc785f5
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -177,7 +177,9 @@ class Commit
def title
return full_title if full_title.length < 100
 
full_title.truncate(81, separator: ' ', omission: '…')
# Use three dots instead of the ellipsis Unicode character because
# some clients show the raw Unicode value in the merge commit.
full_title.truncate(81, separator: ' ', omission: '...')
end
 
# Returns the full commits title
Loading
Loading
---
title: Truncate merge request titles with periods instead of ellipsis
merge_request: 23558
author:
type: changed
Loading
Loading
@@ -204,7 +204,7 @@ describe Commit do
message = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec sodales id felis id blandit. Vivamus egestas lacinia lacus, sed rutrum mauris.'
 
allow(commit).to receive(:safe_message).and_return(message)
expect(commit.title).to eq('Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec sodales id felis…')
expect(commit.title).to eq('Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec sodales id...')
end
 
it "truncates a message with a newline before 80 characters at the newline" do
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment