Merge branch 'jc-fix-set-project-writable' into 'master'

Fix method to mark a project repository as writable

See merge request gitlab-org/gitlab-ce!25546

(cherry picked from commit a8a02387)

df044542 Fix project set_repository_writable!

app/models/project.rb

@@ -1830,7 +1830,7 @@ class Project < ActiveRecord::Base
   # Set repository as writable again
   def set_repository_writable!
     with_lock do
-      update_column(repository_read_only, false)
+      update_column(:repository_read_only, false)
     end
   end

changelogs/unreleased/jc-fix-set-project-writable.yml

+---
+title: Fix method to mark a project repository as writable
+merge_request: 25546
+author:
+type: fixed

spec/models/project_spec.rb

@@ -2487,6 +2487,16 @@ describe Project do
     end
   end
+  describe '#set_repository_writable!' do
+    it 'sets repository_read_only to false' do
+      project = create(:project, :read_only)
+
+      expect { project.set_repository_writable! }
+        .to change(project, :repository_read_only)
+        .from(true).to(false)
+    end
+  end
+
   describe '#pushes_since_gc' do
     let(:project) { create(:project) }