Add latest changes from gitlab-org/gitlab@master

app/views/projects/wikis/_sidebar_wiki_page.html.haml

+%li{ class: active_when(params[:id] == wiki_page.slug) }
+  = link_to project_wiki_path(@project, wiki_page) do
+    = wiki_page.human_title

app/views/projects/wikis/_wiki_directory.html.haml

+%li
+  = wiki_directory.slug
+  %ul
+    = render wiki_directory.pages, context: context

app/views/projects/wikis/_wiki_page.html.haml

+= render "#{context}_wiki_page", wiki_page: wiki_page

app/views/projects/wiki_pages/edit.html.haml → app/views/projects/wikis/edit.html.haml

-- @content_class = 'edit-wiki-page' + (fluid_layout ? '' : ' limit-container-width')
-- add_to_breadcrumbs _("Wiki"), project_wiki_path(@project, :home)
-- add_to_breadcrumbs s_("Wiki|Pages"), project_wikis_pages_path(@project)
-- if @page.persisted? && @page_dir.present?
-  - add_to_breadcrumbs _(@page_dir.slug), project_wiki_dir_path(@project, @page_dir)
-- if @page.persisted?
-  - add_to_breadcrumbs @page.human_title, project_wiki_path(@project, @page)
+- @content_class = "limit-container-width" unless fluid_layout
+- add_to_breadcrumbs _("Wiki"), project_wiki_path(@project, @page)
 - breadcrumb_title @page.persisted? ? _("Edit") : _("New")
 - page_title @page.persisted? ? _("Edit") : _("New"), @page.human_title, _("Wiki")
@@ -17,7 +12,10 @@
   .nav-text
     %h2.wiki-page-title
       - if @page.persisted?
-        = render partial: 'page_title', locals: { subtitle: s_("Wiki|Edit Page") }
+        = link_to @page.human_title, project_wiki_path(@project, @page)
+        %span.light
+          ·
+          = s_("Wiki|Edit Page")
       - else
         = s_("Wiki|Create New Page")

app/views/projects/wiki_pages/history.html.haml → app/views/projects/wikis/history.html.haml

-- @content_class = 'wiki-history'
 - page_title _("History"), @page.human_title, _("Wiki")
 .wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row
@@ -7,7 +6,10 @@
   .nav-text
     %h2.wiki-page-title
-      = render partial: 'page_title', locals: { subtitle: _("History") }
+      = link_to @page.human_title, project_wiki_path(@project, @page)
+      %span.light
+        ·
+        = _("History")
 .table-holder
   %table.table
@@ -37,4 +39,4 @@
               = version.format
 = paginate @page_versions, theme: 'gitlab'
-= render 'shared/wiki/sidebar'
+= render 'sidebar'

app/views/projects/wikis/pages.html.haml

+- add_to_breadcrumbs "Wiki", project_wiki_path(@project, :home)
+- breadcrumb_title s_("Wiki|Pages")
+- page_title s_("Wiki|Pages"), _("Wiki")
+- sort_title = wiki_sort_title(params[:sort])
+
+.wiki-page-header.top-area.flex-column.flex-lg-row
+
+  .nav-text.flex-fill
+    %h2.wiki-page-title
+      = s_("Wiki|Wiki Pages")
+
+  .nav-controls.pb-md-3.pb-lg-0
+    = link_to project_wikis_git_access_path(@project), class: 'btn' do
+      = icon('cloud-download')
+      = _("Clone repository")
+
+    .dropdown.inline.wiki-sort-dropdown
+      .btn-group{ role: 'group' }
+        .btn-group{ role: 'group' }
+          %button.dropdown-toggle{ type: 'button', data: { toggle: 'dropdown', display: 'static' }, class: 'btn btn-default' }
+            = sort_title
+            = icon('chevron-down')
+          %ul.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
+            %li
+              = sortable_item(s_("Wiki|Title"), project_wikis_pages_path(@project, sort: ProjectWiki::TITLE_ORDER), sort_title)
+              = sortable_item(s_("Wiki|Created date"), project_wikis_pages_path(@project, sort: ProjectWiki::CREATED_AT_ORDER), sort_title)
+        = wiki_sort_controls(@project, params[:sort], params[:direction])
+
+%ul.wiki-pages-list.content-list
+  = render @wiki_entries, context: 'pages'
+
+= paginate @wiki_pages, theme: 'gitlab'

app/views/projects/wikis/show.html.haml

-- add_to_breadcrumbs "Wiki", project_wiki_path(@project, :home)
-- breadcrumb_title s_("Wiki|Pages")
-- page_title s_("Wiki|Contents"), _("Wiki")
-= render 'page_listing', { allow_change_nesting: ::Feature.enabled?(:wikis_allow_change_nesting), wiki_page_title: page_title, page_path: ->(opts) { project_wikis_pages_path(@project, opts) } }
+- @content_class = "limit-container-width" unless fluid_layout
+- breadcrumb_title @page.human_title
+- wiki_breadcrumb_dropdown_links(@page.slug)
+- page_title @page.human_title, _("Wiki")
+- add_to_breadcrumbs _("Wiki"), project_wiki_path(@project, :home)
+.wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row
+  %button.btn.btn-default.sidebar-toggle.js-sidebar-wiki-toggle{ role: "button", type: "button" }
+    = icon('angle-double-left')
+
+  .nav-text.flex-fill
+    %h2.wiki-page-title= @page.human_title
+    %span.wiki-last-edit-by
+      - if @page.last_version
+        = (_("Last edited by %{name}") % { name: "<strong>#{@page.last_version.author_name}</strong>" }).html_safe
+        #{time_ago_with_tooltip(@page.last_version.authored_date)}
+
+  .nav-controls.pb-md-3.pb-lg-0
+    = render 'main_links'
+
+- if @page.historical?
+  .warning_message
+    = s_("WikiHistoricalPage|This is an old version of this page.")
+    - most_recent_link = link_to s_("WikiHistoricalPage|most recent version"), project_wiki_path(@project, @page)
+    - history_link = link_to s_("WikiHistoricalPage|history"), project_wiki_history_path(@project, @page)
+    = (s_("WikiHistoricalPage|You can view the %{most_recent_link} or browse the %{history_link}.") % { most_recent_link: most_recent_link, history_link: history_link }).html_safe
+
+.prepend-top-default.append-bottom-default
+  .md.md-file{ data: { qa_selector: 'wiki_page_content' } }
+    = render_wiki_content(@page)
+
+= render 'sidebar'

app/views/shared/empty_states/_wikis.html.haml

 - layout_path = 'shared/empty_states/wikis_layout'
-- wiki_is_empty = @project_wiki.empty?
-- empty_msg  = wiki_is_empty ? s_('WikiEmpty|This project has no wiki pages') : s_('WikiEmpty|This page does not exist')
-- create_msg = wiki_is_empty ? s_('WikiEmpty|Create your first page')         : s_('WikiEmpty|Create this page')
 - if can?(current_user, :create_wiki, @project)
   - create_path = project_wiki_path(@project, params[:id], { view: 'create' })
-  - create_link = link_to create_msg, create_path, class: 'btn btn-success qa-create-first-page-link', title: create_msg
+  - create_link = link_to s_('WikiEmpty|Create your first page'), create_path, class: 'btn btn-success qa-create-first-page-link', title: s_('WikiEmpty|Create your first page')
   = render layout: layout_path, locals: { image_path: 'illustrations/wiki_login_empty.svg' } do
     %h4.text-left
@@ -20,7 +17,7 @@
   = render layout: layout_path, locals: { image_path: 'illustrations/wiki_logout_empty.svg' } do
     %h4
-      = empty_msg
+      = s_('WikiEmpty|This project has no wiki pages')
     %p.text-left
       = s_('WikiEmptyIssueMessage|You must be a project member in order to add wiki pages. If you have suggestions for how to improve the wiki for this project, consider opening an issue in the %{issues_link}.').html_safe % { issues_link: issues_link }
     = new_issue_link
@@ -28,6 +25,6 @@
 - else
   = render layout: layout_path, locals: { image_path: 'illustrations/wiki_logout_empty.svg' } do
     %h4
-      = empty_msg
+      = s_('WikiEmpty|This project has no wiki pages')
     %p
       = s_('WikiEmpty|You must be a project member in order to add wiki pages.')

app/views/shared/wiki/_page_listing.html.haml

-- @no_container = true
-- current_sorting = params.permit(:sort, :direction)
-- sort_title = wiki_sort_title(params[:sort])
-
-%div{ class: container_class }
-  .wiki-page-header.top-area.flex-column.flex-lg-row
-
-    .nav-text.flex-fill
-      %h2.wiki-page-title
-        = wiki_page_title
-
-    .nav-controls.pb-md-3.pb-lg-0
-      - if can?(current_user, :create_wiki, @project)
-        = link_to project_wiki_pages_new_path(@project), class: "add-new-wiki btn btn-success" do
-          = s_("Wiki|New page")
-
-      = link_to project_wikis_git_access_path(@project), class: 'btn qa-clone-repository-link' do
-        = sprite_icon('download', size: 16)
-        = _("Clone repository")
-
-      - if @nesting.present? && allow_change_nesting
-        .dropdown.inline.wiki-nesting-dropdown
-          .btn-group{ role: 'group' }
-            %button.dropdown-toggle{ type: 'button', data: { toggle: 'dropdown', display: 'static' }, class: 'btn btn-default' }
-              = wiki_show_children_icon(@nesting)
-              = sprite_icon('chevron-down', size: 16)
-            %ul.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
-              - ProjectWiki::NESTINGS.each do |choice|
-                %li= link_to wiki_show_children_icon(choice), page_path.call(current_sorting.merge(show_children: choice)), class: @nesting == choice ? 'is-active' : ''
-
-      .dropdown.inline.wiki-sort-dropdown
-        .btn-group{ role: 'group' }
-          %button.dropdown-toggle{ type: 'button', data: { toggle: 'dropdown', display: 'static' }, class: 'btn btn-default' }
-            = sort_title
-            = sprite_icon('chevron-down', size: 16)
-          %ul.dropdown-menu.dropdown-menu-right.dropdown-menu-selectable.dropdown-menu-sort
-            %li
-              = sortable_item(s_("Wiki|Title"), page_path.call(sort: ProjectWiki::TITLE_ORDER), sort_title)
-              = sortable_item(s_("Wiki|Created date"), page_path.call(sort: ProjectWiki::CREATED_AT_ORDER), sort_title)
-          = wiki_sort_controls(current_sorting.merge(show_children: @nesting), &page_path)
-
-  %ul.wiki-pages-list.content-list
-    = render @wiki_entries, context: 'pages'
-
-  = paginate @wiki_pages, theme: 'gitlab'

changelogs/unreleased/34230-fix-popover-image.yml

+---
+title: Fix cluster feature highlight popover image
+merge_request: 19372
+author:
+type: fixed

changelogs/unreleased/add-snowplow-iglu-registry-application-setting.yml

+---
+title: Add ApplicationSetting for snowplow_iglu_registry_url
+merge_request: 18449
+author:
+type: added

changelogs/unreleased/sort-wiki-pages-by-date.yml

----
-title: Sort wiki pages by date
-merge_request: 30245
-type: added

config/routes/project.rb

@@ -617,7 +617,7 @@ constraints(::Constraints::ProjectUrlConstrainer.new) do
       end
       # Since both wiki and repository routing contains wildcard characters
-      # its preferable to keep them below all other project routes
+      # its preferable to keep it below all other project routes
       draw :wiki
       draw :repository

config/routes/wiki.rb

 scope(controller: :wikis) do
-  scope(path: 'wikis/pages', as: :wiki_pages, format: false) do
-    get :new, to: 'wiki_pages#new'
-    post '/', to: 'wiki_pages#create'
-  end
-
   scope(path: 'wikis', as: :wikis) do
     get :git_access
     get :pages
-    get '/', to: redirect('%{namespace_id}/%{project_id}/-/wiki_pages/home')
-    get '/*id', to: redirect('%{namespace_id}/%{project_id}/-/wiki_pages/%{id}')
-  end
-
-  scope(path: '-/wiki_pages', as: :wiki_page, format: false) do
-    post '/', to: 'wiki_pages#create'
+    get :new
+    get '/', to: redirect('%{namespace_id}/%{project_id}/wikis/home')
+    post '/', to: 'wikis#create'
   end
-  scope(path: '-/wiki_pages/*id', as: :wiki, format: false, controller: :wiki_pages) do
+  scope(path: 'wikis/*id', as: :wiki, format: false) do
     get :edit
     get :history
     post :preview_markdown
@@ -23,8 +15,4 @@ scope(controller: :wikis) do
     put '/', action: :update
     delete '/', action: :destroy
   end
-
-  scope(path: '-/wiki_dirs/*id', as: :wiki_dir, format: false, controller: :wiki_directories) do
-    get '/', action: :show
-  end
 end

db/migrate/20191010174846_add_snowplow_iglu_registry_url_to_application_settings.rb

+# frozen_string_literal: true
+
+class AddSnowplowIgluRegistryUrlToApplicationSettings < ActiveRecord::Migration[5.2]
+  DOWNTIME = false
+
+  def change
+    add_column :application_settings, :snowplow_iglu_registry_url, :string, limit: 255
+  end
+end

db/migrate/20191024134020_add_index_to_zoom_meetings.rb

+# frozen_string_literal: true
+
+class AddIndexToZoomMeetings < ActiveRecord::Migration[5.2]
+  include Gitlab::Database::MigrationHelpers
+
+  DOWNTIME = false
+
+  disable_ddl_transaction!
+
+  def up
+    add_concurrent_index :zoom_meetings, :issue_status
+  end
+
+  def down
+    remove_concurrent_index :zoom_meetings, :issue_status if index_exists?(:zoom_meetings, :issue_status)
+  end
+end

db/schema.rb

@@ -338,6 +338,7 @@ ActiveRecord::Schema.define(version: 2019_10_26_124116) do
     t.boolean "throttle_incident_management_notification_enabled", default: false, null: false
     t.integer "throttle_incident_management_notification_period_in_seconds", default: 3600
     t.integer "throttle_incident_management_notification_per_period", default: 3600
+    t.string "snowplow_iglu_registry_url", limit: 255
     t.integer "push_event_hooks_limit", default: 3, null: false
     t.integer "push_event_activities_limit", default: 3, null: false
     t.string "custom_http_clone_url_root", limit: 511
@@ -4041,6 +4042,7 @@ ActiveRecord::Schema.define(version: 2019_10_26_124116) do
     t.string "url", limit: 255
     t.index ["issue_id", "issue_status"], name: "index_zoom_meetings_on_issue_id_and_issue_status", unique: true, where: "(issue_status = 1)"
     t.index ["issue_id"], name: "index_zoom_meetings_on_issue_id"
+    t.index ["issue_status"], name: "index_zoom_meetings_on_issue_status"
     t.index ["project_id"], name: "index_zoom_meetings_on_project_id"
   end

doc/api/settings.md

@@ -316,6 +316,7 @@ are listed in the descriptions of the relevant settings.
 | `snowplow_cookie_domain`                 | string           | no                                   | The Snowplow cookie domain. (e.g. `.gitlab.com`) |
 | `snowplow_enabled`                       | boolean          | no                                   | Enable snowplow tracking. |
 | `snowplow_site_id`                       | string           | no                                   | The Snowplow site name / application id. (e.g. `gitlab`) |
+| `snowplow_iglu_registry_url`             | string           | no                                   | The Snowplow base Iglu Schema Registry URL to use for custom context and self describing events'|
 | `pendo_url`                              | string           | required by: `pendo_enabled`         | The Pendo endpoint url with js snippet. (e.g. `https://cdn.pendo.io/agent/static/your-api-key/pendo.js`) |
 | `pendo_enabled`                          | boolean          | no                                   | Enable pendo tracking. |
 | `terminal_max_session_time`              | integer          | no                                   | Maximum time for web terminal websocket connection (in seconds). Set to `0` for unlimited time. |

lib/api/settings.rb

@@ -135,6 +135,7 @@ module API
       optional :local_markdown_version, type: Integer, desc: 'Local markdown version, increase this value when any cached markdown should be invalidated'
       optional :allow_local_requests_from_hooks_and_services, type: Boolean, desc: 'Deprecated: Use :allow_local_requests_from_web_hooks_and_services instead. Allow requests to the local network from hooks and services.' # support legacy names, can be removed in v5
       optional :snowplow_enabled, type: Grape::API::Boolean, desc: 'Enable Snowplow tracking'
+      optional :snowplow_iglu_registry_url, type: String, desc: 'The Snowplow base Iglu Schema Registry URL to use for custom context and self describing events'
       given snowplow_enabled: ->(val) { val } do
         requires :snowplow_collector_hostname, type: String, desc: 'The Snowplow collector hostname'
         optional :snowplow_cookie_domain, type: String, desc: 'The Snowplow cookie domain'