Merge branch '51712-new-line-before-expect' into 'master'

3. enable jasmine/new-line-before-expect

See merge request gitlab-org/gitlab-ce!22234

spec/javascripts/.eslintrc.yml

@@ -36,5 +36,4 @@ rules:
     - ignore:
       - 'fixtures/blob'
   # Temporarily disabled to facilitate an upgrade to eslint-plugin-jasmine
-  jasmine/new-line-before-expect: off
   jasmine/prefer-toHaveBeenCalledWith: off

spec/javascripts/ajax_loading_spinner_spec.js

@@ -42,6 +42,7 @@ describe('Ajax Loading Spinner', () => {
       req.complete({});
       const icon = ajaxLoadingSpinner.querySelector('i');
+
       expect(icon).toHaveClass('fa-trash-o');
       expect(icon).not.toHaveClass('fa-spinner');
       expect(icon).not.toHaveClass('fa-spin');

spec/javascripts/awards_handler_spec.js

@@ -74,6 +74,7 @@ import '~/lib/utils/common_utils';
         return lazyAssert(done, function() {
           var $emojiMenu;
           $emojiMenu = $('.emoji-menu');
+
           expect($emojiMenu.length).toBe(1);
           expect($emojiMenu.hasClass('is-visible')).toBe(true);
           expect($emojiMenu.find('.js-emoji-menu-search').length).toBe(1);
@@ -85,7 +86,8 @@ import '~/lib/utils/common_utils';
         $('.js-add-award.note-action-button').click();
         return lazyAssert(done, function() {
           var $emojiMenu = $('.emoji-menu');
-          return expect($emojiMenu.length).toBe(1);
+
+          expect($emojiMenu.length).toBe(1);
         });
       });
@@ -97,6 +99,7 @@ import '~/lib/utils/common_utils';
           var $emojiMenu;
           $emojiMenu = $('.emoji-menu');
           $('body').click();
+
           expect($emojiMenu.length).toBe(1);
           expect($emojiMenu.hasClass('is-visible')).toBe(false);
           return expect($('.js-awards-block.current').length).toBe(0);
@@ -111,6 +114,7 @@ import '~/lib/utils/common_utils';
           var $emojiMenu;
           $emojiMenu = $('.emoji-menu');
           $('.emoji-search').click();
+
           expect($emojiMenu.length).toBe(1);
           expect($emojiMenu.hasClass('is-visible')).toBe(true);
           return expect($('.js-awards-block.current').length).toBe(1);
@@ -124,6 +128,7 @@ import '~/lib/utils/common_utils';
         $votesBlock = $('.js-awards-block').eq(0);
         awardsHandler.addAwardToEmojiBar($votesBlock, 'heart', false);
         $emojiButton = $votesBlock.find('[data-name=heart]');
+
         expect($emojiButton.length).toBe(1);
         expect($emojiButton.next('.js-counter').text()).toBe('1');
         return expect($votesBlock.hasClass('hidden')).toBe(false);
@@ -135,7 +140,8 @@ import '~/lib/utils/common_utils';
         awardsHandler.addAwardToEmojiBar($votesBlock, 'heart', false);
         awardsHandler.addAwardToEmojiBar($votesBlock, 'heart', false);
         $emojiButton = $votesBlock.find('[data-name=heart]');
-        return expect($emojiButton.length).toBe(0);
+
+        expect($emojiButton.length).toBe(0);
       });
       return it('should decrement the emoji counter', function() {
         var $emojiButton, $votesBlock;
@@ -144,6 +150,7 @@ import '~/lib/utils/common_utils';
         $emojiButton = $votesBlock.find('[data-name=heart]');
         $emojiButton.next('.js-counter').text(5);
         awardsHandler.addAwardToEmojiBar($votesBlock, 'heart', false);
+
         expect($emojiButton.length).toBe(1);
         return expect($emojiButton.next('.js-counter').text()).toBe('4');
       });
@@ -156,7 +163,8 @@ import '~/lib/utils/common_utils';
         $thumbsUpEmoji = $votesBlock.find('[data-name=thumbsup]').parent();
         $thumbsUpEmoji.attr('data-title', 'sam');
         awardsHandler.userAuthored($thumbsUpEmoji);
-        return expect($thumbsUpEmoji.data('originalTitle')).toBe(
+
+        expect($thumbsUpEmoji.data('originalTitle')).toBe(
           'You cannot vote on your own issue, MR and note',
         );
       });
@@ -170,13 +178,15 @@ import '~/lib/utils/common_utils';
         awardsHandler.userAuthored($thumbsUpEmoji);
         jasmine.clock().tick(2801);
         jasmine.clock().uninstall();
-        return expect($thumbsUpEmoji.data('originalTitle')).toBe('sam');
+
+        expect($thumbsUpEmoji.data('originalTitle')).toBe('sam');
       });
     });
     describe('::getAwardUrl', function() {
       return it('returns the url for request', function() {
-        return expect(awardsHandler.getAwardUrl()).toBe(
+
+        expect(awardsHandler.getAwardUrl()).toBe(
           'http://test.host/snippets/1/toggle_award_emoji',
         );
       });
@@ -190,11 +200,13 @@ import '~/lib/utils/common_utils';
         $thumbsUpEmoji = $votesBlock.find('[data-name=thumbsup]').parent();
         $thumbsDownEmoji = $votesBlock.find('[data-name=thumbsdown]').parent();
         awardsHandler.addAward($votesBlock, awardUrl, 'thumbsup', false);
+
         expect($thumbsUpEmoji.hasClass('active')).toBe(true);
         expect($thumbsDownEmoji.hasClass('active')).toBe(false);
         $thumbsUpEmoji.tooltip();
         $thumbsDownEmoji.tooltip();
         awardsHandler.addAward($votesBlock, awardUrl, 'thumbsdown', true);
+
         expect($thumbsUpEmoji.hasClass('active')).toBe(false);
         return expect($thumbsDownEmoji.hasClass('active')).toBe(true);
       });
@@ -206,9 +218,11 @@ import '~/lib/utils/common_utils';
         awardUrl = awardsHandler.getAwardUrl();
         $votesBlock = $('.js-awards-block').eq(0);
         awardsHandler.addAward($votesBlock, awardUrl, 'fire', false);
+
         expect($votesBlock.find('[data-name=fire]').length).toBe(1);
         awardsHandler.removeEmoji($votesBlock.find('[data-name=fire]').closest('button'));
-        return expect($votesBlock.find('[data-name=fire]').length).toBe(0);
+
+        expect($votesBlock.find('[data-name=fire]').length).toBe(0);
       });
     });
@@ -221,7 +235,8 @@ import '~/lib/utils/common_utils';
         $thumbsUpEmoji.attr('data-title', 'sam, jerry, max, and andy');
         awardsHandler.addAward($votesBlock, awardUrl, 'thumbsup', false);
         $thumbsUpEmoji.tooltip();
-        return expect($thumbsUpEmoji.data('originalTitle')).toBe('You, sam, jerry, max, and andy');
+
+        expect($thumbsUpEmoji.data('originalTitle')).toBe('You, sam, jerry, max, and andy');
       });
       return it('handles the special case where "You" is not cleanly comma seperated', function() {
         var $thumbsUpEmoji, $votesBlock, awardUrl;
@@ -231,7 +246,8 @@ import '~/lib/utils/common_utils';
         $thumbsUpEmoji.attr('data-title', 'sam');
         awardsHandler.addAward($votesBlock, awardUrl, 'thumbsup', false);
         $thumbsUpEmoji.tooltip();
-        return expect($thumbsUpEmoji.data('originalTitle')).toBe('You and sam');
+
+        expect($thumbsUpEmoji.data('originalTitle')).toBe('You and sam');
       });
     });
@@ -245,7 +261,8 @@ import '~/lib/utils/common_utils';
         $thumbsUpEmoji.addClass('active');
         awardsHandler.addAward($votesBlock, awardUrl, 'thumbsup', false);
         $thumbsUpEmoji.tooltip();
-        return expect($thumbsUpEmoji.data('originalTitle')).toBe('sam, jerry, max, and andy');
+
+        expect($thumbsUpEmoji.data('originalTitle')).toBe('sam, jerry, max, and andy');
       });
       return it('handles the special case where "You" is not cleanly comma seperated', function() {
         var $thumbsUpEmoji, $votesBlock, awardUrl;
@@ -256,7 +273,8 @@ import '~/lib/utils/common_utils';
         $thumbsUpEmoji.addClass('active');
         awardsHandler.addAward($votesBlock, awardUrl, 'thumbsup', false);
         $thumbsUpEmoji.tooltip();
-        return expect($thumbsUpEmoji.data('originalTitle')).toBe('sam');
+
+        expect($thumbsUpEmoji.data('originalTitle')).toBe('sam');
       });
     });
@@ -267,6 +285,7 @@ import '~/lib/utils/common_utils';
             expect($('[data-name=angel]').is(':visible')).toBe(true);
             expect($('[data-name=anger]').is(':visible')).toBe(true);
             awardsHandler.searchEmojis('ali');
+
             expect($('[data-name=angel]').is(':visible')).toBe(false);
             expect($('[data-name=anger]').is(':visible')).toBe(false);
             expect($('[data-name=alien]').is(':visible')).toBe(true);
@@ -282,10 +301,12 @@ import '~/lib/utils/common_utils';
         return openAndWaitForEmojiMenu()
           .then(() => {
             awardsHandler.searchEmojis('ali');
+
             expect($('[data-name=angel]').is(':visible')).toBe(false);
             expect($('[data-name=anger]').is(':visible')).toBe(false);
             expect($('[data-name=alien]').is(':visible')).toBe(true);
             awardsHandler.searchEmojis('');
+
             expect($('[data-name=angel]').is(':visible')).toBe(true);
             expect($('[data-name=anger]').is(':visible')).toBe(true);
             expect($('[data-name=alien]').is(':visible')).toBe(true);
@@ -309,6 +330,7 @@ import '~/lib/utils/common_utils';
           expect($emoji.length).toBe(1);
           expect($block.find(emojiSelector).length).toBe(0);
           $emoji.click();
+
           expect($menu.hasClass('.is-visible')).toBe(false);
           expect($block.find(emojiSelector).length).toBe(1);
         });
@@ -332,6 +354,7 @@ import '~/lib/utils/common_utils';
               `.emoji-menu-list:not(.frequent-emojis) ${emojiSelector}`,
             );
             $emoji.click();
+
             expect($block.find(emojiSelector).length).toBe(0);
           })
           .then(done)

spec/javascripts/badges/components/badge_form_spec.js

@@ -66,8 +66,10 @@ describe('BadgeForm component', () => {
     };
     const expectInvalidInput = inputElementSelector => {
       const inputElement = vm.$el.querySelector(inputElementSelector);
+
       expect(inputElement).toBeMatchedBy(':invalid');
       const feedbackElement = vm.$el.querySelector(`${inputElementSelector} + .invalid-feedback`);
+
       expect(feedbackElement).toBeVisible();
     };
@@ -90,6 +92,7 @@ describe('BadgeForm component', () => {
       submitForm();
       expectInvalidInput(imageUrlSelector);
+
       expect(vm[submitAction]).not.toHaveBeenCalled();
     });
@@ -99,6 +102,7 @@ describe('BadgeForm component', () => {
       submitForm();
       expectInvalidInput(imageUrlSelector);
+
       expect(vm[submitAction]).not.toHaveBeenCalled();
     });
@@ -108,6 +112,7 @@ describe('BadgeForm component', () => {
       submitForm();
       expectInvalidInput(linkUrlSelector);
+
       expect(vm[submitAction]).not.toHaveBeenCalled();
     });
@@ -117,6 +122,7 @@ describe('BadgeForm component', () => {
       submitForm();
       expectInvalidInput(linkUrlSelector);
+
       expect(vm[submitAction]).not.toHaveBeenCalled();
     });
@@ -143,8 +149,10 @@ describe('BadgeForm component', () => {
     it('renders one button', () => {
       expect(vm.$el.querySelector('.row-content-block')).toBeNull();
       const buttons = vm.$el.querySelectorAll('.form-group:last-of-type button');
+
       expect(buttons.length).toBe(1);
       const buttonAddElement = buttons[0];
+
       expect(buttonAddElement).toBeVisible();
       expect(buttonAddElement).toHaveText('Add badge');
     });
@@ -165,11 +173,14 @@ describe('BadgeForm component', () => {
     it('renders two buttons', () => {
       const buttons = vm.$el.querySelectorAll('.row-content-block button');
+
       expect(buttons.length).toBe(2);
       const buttonSaveElement = buttons[0];
+
       expect(buttonSaveElement).toBeVisible();
       expect(buttonSaveElement).toHaveText('Save changes');
       const buttonCancelElement = buttons[1];
+
       expect(buttonCancelElement).toBeVisible();
       expect(buttonCancelElement).toHaveText('Cancel');
     });

spec/javascripts/badges/components/badge_list_row_spec.js

@@ -34,6 +34,7 @@ describe('BadgeListRow component', () => {
   it('renders the badge', () => {
     const badgeElement = vm.$el.querySelector('.project-badge');
+
     expect(badgeElement).not.toBeNull();
     expect(badgeElement.getAttribute('src')).toBe(badge.renderedImageUrl);
   });
@@ -48,11 +49,14 @@ describe('BadgeListRow component', () => {
   it('shows edit and delete buttons', () => {
     const buttons = vm.$el.querySelectorAll('.table-button-footer button');
+
     expect(buttons).toHaveLength(2);
     const buttonEditElement = buttons[0];
+
     expect(buttonEditElement).toBeVisible();
     expect(buttonEditElement).toHaveSpriteIcon('pencil');
     const buttonDeleteElement = buttons[1];
+
     expect(buttonDeleteElement).toBeVisible();
     expect(buttonDeleteElement).toHaveSpriteIcon('remove');
   });
@@ -91,6 +95,7 @@ describe('BadgeListRow component', () => {
     it('hides edit and delete buttons', () => {
       const buttons = vm.$el.querySelectorAll('.table-button-footer button');
+
       expect(buttons).toHaveLength(0);
     });
   });

spec/javascripts/badges/components/badge_list_spec.js

@@ -34,11 +34,13 @@ describe('BadgeList component', () => {
   it('renders a header with the badge count', () => {
     const header = vm.$el.querySelector('.card-header');
+
     expect(header).toHaveText(new RegExp(`Your badges\\s+${numberOfDummyBadges}`));
   });
   it('renders a row for each badge', () => {
     const rows = vm.$el.querySelectorAll('.gl-responsive-table-row');
+
     expect(rows).toHaveLength(numberOfDummyBadges);
   });
@@ -59,6 +61,7 @@ describe('BadgeList component', () => {
     Vue.nextTick()
       .then(() => {
         const loadingIcon = vm.$el.querySelector('.fa-spinner');
+
         expect(loadingIcon).toBeVisible();
       })
       .then(done)

spec/javascripts/badges/components/badge_settings_spec.js

@@ -38,6 +38,7 @@ describe('BadgeSettings component', () => {
     $(modal).on('shown.bs.modal', () => {
       expect(modal).toContainText('Delete badge?');
       const badgeElement = modal.querySelector('img.project-badge');
+
       expect(badgeElement).not.toBe(null);
       expect(badgeElement.getAttribute('src')).toBe(badge.renderedImageUrl);
@@ -53,14 +54,17 @@ describe('BadgeSettings component', () => {
   it('displays a form to add a badge', () => {
     const form = vm.$el.querySelector('form:nth-of-type(2)');
+
     expect(form).not.toBe(null);
     const button = form.querySelector('.btn-success');
+
     expect(button).not.toBe(null);
     expect(button).toHaveText(/Add badge/);
   });
   it('displays badge list', () => {
     const badgeListElement = vm.$el.querySelector('.card');
+
     expect(badgeListElement).not.toBe(null);
     expect(badgeListElement).toBeVisible();
     expect(badgeListElement).toContainText('Your badges');
@@ -77,17 +81,21 @@ describe('BadgeSettings component', () => {
     it('displays a form to edit a badge', () => {
       const form = vm.$el.querySelector('form:nth-of-type(1)');
+
       expect(form).not.toBe(null);
       const submitButton = form.querySelector('.btn-success');
+
       expect(submitButton).not.toBe(null);
       expect(submitButton).toHaveText(/Save changes/);
       const cancelButton = form.querySelector('.btn-cancel');
+
       expect(cancelButton).not.toBe(null);
       expect(cancelButton).toHaveText(/Cancel/);
     });
     it('displays no badge list', () => {
       const badgeListElement = vm.$el.querySelector('.card');
+
       expect(badgeListElement).toBeHidden();
     });
   });
@@ -102,6 +110,7 @@ describe('BadgeSettings component', () => {
         deleteButton.click();
         const badge = store.state.badgeInModal;
+
         expect(vm.deleteBadge).toHaveBeenCalledWith(badge);
       });
     });

spec/javascripts/badges/components/badge_spec.js

@@ -107,6 +107,7 @@ describe('Badge component', () => {
       expect(vm.isLoading).toBe(false);
       expect(vm.hasError).toBe(false);
       const { badgeImage, loadingIcon, reloadButton } = findElements();
+
       expect(badgeImage).toBeVisible();
       expect(loadingIcon).toBeHidden();
       expect(reloadButton).toBeHidden();
@@ -119,6 +120,7 @@ describe('Badge component', () => {
       Vue.nextTick()
         .then(() => {
           const { badgeImage, loadingIcon, reloadButton } = findElements();
+
           expect(badgeImage).toBeHidden();
           expect(loadingIcon).toBeVisible();
           expect(reloadButton).toBeHidden();
@@ -134,6 +136,7 @@ describe('Badge component', () => {
       Vue.nextTick()
         .then(() => {
           const { badgeImage, loadingIcon, reloadButton } = findElements();
+
           expect(badgeImage).toBeHidden();
           expect(loadingIcon).toBeHidden();
           expect(reloadButton).toBeVisible();

spec/javascripts/badges/store/actions_spec.js

@@ -94,6 +94,7 @@ describe('Badges store actions', () => {
             link_url: badgeInAddForm.linkUrl,
           }),
         );
+
         expect(dispatch.calls.allArgs()).toEqual([['requestNewBadge']]);
         dispatch.calls.reset();
         return [200, dummyResponse];
@@ -117,6 +118,7 @@ describe('Badges store actions', () => {
             link_url: badgeInAddForm.linkUrl,
           }),
         );
+
         expect(dispatch.calls.allArgs()).toEqual([['requestNewBadge']]);
         dispatch.calls.reset();
         return [500, ''];
@@ -296,6 +298,7 @@ describe('Badges store actions', () => {
         .loadBadges({ state, dispatch }, dummyData)
         .then(() => {
           const badges = dummyReponse.map(transformBackendBadge);
+
           expect(dispatch.calls.allArgs()).toEqual([['receiveLoadBadges', badges]]);
         })
         .then(done)
@@ -416,6 +419,7 @@ describe('Badges store actions', () => {
         .then(() => {
           expect(axios.get.calls.count()).toBe(1);
           const url = axios.get.calls.argsFor(0)[0];
+
           expect(url).toMatch(`^${dummyEndpointUrl}/render?`);
           expect(url).toMatch('\\?link_url=%3Cscript%3EI%20am%20dangerous!%3C%2Fscript%3E&');
           expect(url).toMatch('&image_url=%26make-sandwhich%3Dtrue$');
@@ -436,6 +440,7 @@ describe('Badges store actions', () => {
         .renderBadge({ state, dispatch })
         .then(() => {
           const renderedBadge = transformBackendBadge(dummyReponse);
+
           expect(dispatch.calls.allArgs()).toEqual([['receiveRenderedBadge', renderedBadge]]);
         })
         .then(done)
@@ -525,6 +530,7 @@ describe('Badges store actions', () => {
             link_url: badgeInEditForm.linkUrl,
           }),
         );
+
         expect(dispatch.calls.allArgs()).toEqual([['requestUpdatedBadge']]);
         dispatch.calls.reset();
         return [200, dummyResponse];
@@ -548,6 +554,7 @@ describe('Badges store actions', () => {
             link_url: badgeInEditForm.linkUrl,
           }),
         );
+
         expect(dispatch.calls.allArgs()).toEqual([['requestUpdatedBadge']]);
         dispatch.calls.reset();
         return [500, ''];

spec/javascripts/behaviors/autosize_spec.js

@@ -12,6 +12,7 @@ describe('Autosize behavior', () => {
   it('does not overwrite the resize property', () => {
     load();
+
     expect($('textarea')).toHaveCss({
       resize: 'vertical',
     });

spec/javascripts/behaviors/copy_as_gfm_spec.js

@@ -29,6 +29,7 @@ describe('CopyAsGFM', () => {
     it('wraps pasted code when not already in code tags', () => {
       spyOn(window.gl.utils, 'insertText').and.callFake((el, textFunc) => {
         const insertedText = textFunc('This is code: ', '');
+
         expect(insertedText).toEqual('`code`');
       });
@@ -38,6 +39,7 @@ describe('CopyAsGFM', () => {
     it('does not wrap pasted code when already in code tags', () => {
       spyOn(window.gl.utils, 'insertText').and.callFake((el, textFunc) => {
         const insertedText = textFunc('This is code: `', '`');
+
         expect(insertedText).toEqual('code');
       });
@@ -86,6 +88,7 @@ describe('CopyAsGFM', () => {
         simulateCopy();
         const expectedGFM = '- List Item1\n- List Item2';
+
         expect(clipboardData.setData).toHaveBeenCalledWith('text/x-gfm', expectedGFM);
       });
@@ -95,6 +98,7 @@ describe('CopyAsGFM', () => {
         simulateCopy();
         const expectedGFM = '1. List Item1\n1. List Item2';
+
         expect(clipboardData.setData).toHaveBeenCalledWith('text/x-gfm', expectedGFM);
       });
     });

spec/javascripts/behaviors/quick_submit_spec.js

@@ -30,6 +30,7 @@ describe('Quick Submit behavior', function () {
         keyCode: 32,
       }),
     );
+
     expect(this.spies.submit).not.toHaveBeenTriggered();
   });
@@ -40,6 +41,7 @@ describe('Quick Submit behavior', function () {
         metaKey: false,
       }),
     );
+
     expect(this.spies.submit).not.toHaveBeenTriggered();
   });
@@ -49,6 +51,7 @@ describe('Quick Submit behavior', function () {
         repeat: true,
       }),
     );
+
     expect(this.spies.submit).not.toHaveBeenTriggered();
   });
@@ -86,7 +89,8 @@ describe('Quick Submit behavior', function () {
     describe('In Macintosh', () => {
       it('responds to Meta+Enter', () => {
         this.textarea.trigger(keydownEvent());
-        return expect(this.spies.submit).toHaveBeenTriggered();
+
+        expect(this.spies.submit).toHaveBeenTriggered();
       });
       it('excludes other modifier keys', () => {
@@ -105,13 +109,15 @@ describe('Quick Submit behavior', function () {
             shiftKey: true,
           }),
         );
-        return expect(this.spies.submit).not.toHaveBeenTriggered();
+
+        expect(this.spies.submit).not.toHaveBeenTriggered();
       });
     });
   } else {
     it('responds to Ctrl+Enter', () => {
       this.textarea.trigger(keydownEvent());
-      return expect(this.spies.submit).toHaveBeenTriggered();
+
+      expect(this.spies.submit).toHaveBeenTriggered();
     });
     it('excludes other modifier keys', () => {
@@ -130,7 +136,8 @@ describe('Quick Submit behavior', function () {
           shiftKey: true,
         }),
       );
-      return expect(this.spies.submit).not.toHaveBeenTriggered();
+
+      expect(this.spies.submit).not.toHaveBeenTriggered();
     });
   }
 });

spec/javascripts/behaviors/requires_input_spec.js

@@ -12,33 +12,39 @@ describe('requiresInput', () => {
   it('disables submit when any field is required', () => {
     $('.js-requires-input').requiresInput();
+
     expect(submitButton).toBeDisabled();
   });
   it('enables submit when no field is required', () => {
     $('*[required=required]').prop('required', false);
     $('.js-requires-input').requiresInput();
+
     expect(submitButton).not.toBeDisabled();
   });
   it('enables submit when all required fields are pre-filled', () => {
     $('*[required=required]').remove();
     $('.js-requires-input').requiresInput();
+
     expect($('.submit')).not.toBeDisabled();
   });
   it('enables submit when all required fields receive input', () => {
     $('.js-requires-input').requiresInput();
     $('#required1').val('input1').change();
+
     expect(submitButton).toBeDisabled();
     $('#optional1').val('input1').change();
+
     expect(submitButton).toBeDisabled();
     $('#required2').val('input2').change();
     $('#required3').val('input3').change();
     $('#required4').val('input4').change();
     $('#required5').val('1').change();
+
     expect($('.submit')).not.toBeDisabled();
   });
 });

spec/javascripts/behaviors/secret_values_spec.js

@@ -130,6 +130,7 @@ describe('setupSecretValues', () => {
       values.forEach((value) => {
         expect(value.classList.contains('hide')).toEqual(true);
       });
+
       expect(placeholders.length).toEqual(3);
       placeholders.forEach((placeholder) => {
         expect(placeholder.classList.contains('hide')).toEqual(false);
@@ -148,6 +149,7 @@ describe('setupSecretValues', () => {
       values.forEach((value) => {
         expect(value.classList.contains('hide')).toEqual(false);
       });
+
       expect(placeholders.length).toEqual(3);
       placeholders.forEach((placeholder) => {
         expect(placeholder.classList.contains('hide')).toEqual(true);
@@ -159,6 +161,7 @@ describe('setupSecretValues', () => {
       values.forEach((value) => {
         expect(value.classList.contains('hide')).toEqual(true);
       });
+
       expect(placeholders.length).toEqual(3);
       placeholders.forEach((placeholder) => {
         expect(placeholder.classList.contains('hide')).toEqual(false);
@@ -184,6 +187,7 @@ describe('setupSecretValues', () => {
       values.forEach((value) => {
         expect(value.classList.contains('hide')).toEqual(false);
       });
+
       expect(placeholders.length).toEqual(4);
       placeholders.forEach((placeholder) => {
         expect(placeholder.classList.contains('hide')).toEqual(true);
@@ -195,6 +199,7 @@ describe('setupSecretValues', () => {
       values.forEach((value) => {
         expect(value.classList.contains('hide')).toEqual(true);
       });
+
       expect(placeholders.length).toEqual(4);
       placeholders.forEach((placeholder) => {
         expect(placeholder.classList.contains('hide')).toEqual(false);

spec/javascripts/behaviors/shortcuts/shortcuts_issuable_spec.js

@@ -57,9 +57,11 @@ describe('ShortcutsIssuable', function() {
       it('leaves existing input intact', () => {
         $(FORM_SELECTOR).val('This text was already here.');
+
         expect($(FORM_SELECTOR).val()).toBe('This text was already here.');
         ShortcutsIssuable.replyWithSelectedText(true);
+
         expect($(FORM_SELECTOR).val()).toBe('This text was already here.\n\n> Selected text.\n\n');
       });
@@ -70,6 +72,7 @@ describe('ShortcutsIssuable', function() {
         });
         ShortcutsIssuable.replyWithSelectedText(true);
+
         expect(triggered).toBe(true);
       });

spec/javascripts/blob/blob_fork_suggestion_spec.js

@@ -26,6 +26,7 @@ describe('BlobForkSuggestion', () => {
   it('showSuggestionSection', () => {
     blobForkSuggestion.showSuggestionSection('/foo', 'foo');
+
     expect(suggestionSection.classList.contains('hidden')).toEqual(false);
     expect(forkButton.getAttribute('href')).toEqual('/foo');
     expect(actionTextPiece.textContent).toEqual('foo');
@@ -33,6 +34,7 @@ describe('BlobForkSuggestion', () => {
   it('hideSuggestionSection', () => {
     blobForkSuggestion.hideSuggestionSection();
+
     expect(suggestionSection.classList.contains('hidden')).toEqual(true);
   });
 });

spec/javascripts/blob/viewer/index_spec.js

@@ -165,6 +165,7 @@ describe('Blob viewer', () => {
       expect(
         simpleBtn.classList.contains('active'),
       ).toBeTruthy();
+
       expect(simpleBtn.blur).toHaveBeenCalled();
     });

spec/javascripts/boards/boards_store_spec.js

@@ -86,10 +86,12 @@ describe('Store', () => {
           description: 'testing;'
         }
       });
+
       expect(boardsStore.state.lists.length).toBe(1);
       setTimeout(() => {
         const list = boardsStore.findList('id', listObj.id);
+
         expect(list).toBeDefined();
         expect(list.id).toBe(listObj.id);
         expect(list.position).toBe(0);
@@ -103,6 +105,7 @@ describe('Store', () => {
     it('check for blank state not adding', () => {
       boardsStore.addList(listObj);
+
       expect(boardsStore.shouldAddBlankState()).toBe(false);
     });
@@ -118,6 +121,7 @@ describe('Store', () => {
       boardsStore.addBlankState();
       const list = boardsStore.findList('type', 'blank', 'blank');
+
       expect(list).toBeDefined();
     });

spec/javascripts/boards/issue_spec.js

@@ -47,6 +47,7 @@ describe('Issue model', () => {
       color: 'blue',
       description: 'bugs!'
     });
+
     expect(issue.labels.length).toBe(2);
   });
@@ -63,12 +64,14 @@ describe('Issue model', () => {
   it('finds label', () => {
     const label = issue.findLabel(issue.labels[0]);
+
     expect(label).toBeDefined();
   });
   it('removes label', () => {
     const label = issue.findLabel(issue.labels[0]);
     issue.removeLabel(label);
+
     expect(issue.labels.length).toBe(0);
   });
@@ -79,9 +82,11 @@ describe('Issue model', () => {
       color: 'blue',
       description: 'bugs!'
     });
+
     expect(issue.labels.length).toBe(2);
     issue.removeLabels([issue.labels[0], issue.labels[1]]);
+
     expect(issue.labels.length).toBe(0);
   });
@@ -98,17 +103,20 @@ describe('Issue model', () => {
   it('finds assignee', () => {
     const assignee = issue.findAssignee(issue.assignees[0]);
+
     expect(assignee).toBeDefined();
   });
   it('removes assignee', () => {
     const assignee = issue.findAssignee(issue.assignees[0]);
     issue.removeAssignee(assignee);
+
     expect(issue.assignees.length).toBe(0);
   });
   it('removes all assignees', () => {
     issue.removeAllAssignees();
+
     expect(issue.assignees.length).toBe(0);
   });
@@ -131,6 +139,7 @@ describe('Issue model', () => {
   it('updates data', () => {
     issue.updateData({ subscribed: true });
+
     expect(issue.subscribed).toBe(true);
   });

spec/javascripts/boards/list_spec.js

@@ -60,6 +60,7 @@ describe('List model', () => {
   it('destroys the list', (done) => {
     boardsStore.addList(listObj);
     list = boardsStore.findList('id', listObj.id);
+
     expect(boardsStore.state.lists.length).toBe(1);
     list.destroy();
@@ -72,6 +73,7 @@ describe('List model', () => {
   it('gets issue from list', (done) => {
     setTimeout(() => {
       const issue = list.findIssue(1);
+
       expect(issue).toBeDefined();
       done();
     }, 0);
@@ -80,8 +82,10 @@ describe('List model', () => {
   it('removes issue', (done) => {
     setTimeout(() => {
       const issue = list.findIssue(1);
+
       expect(list.issues.length).toBe(1);
       list.removeIssue(issue);
+
       expect(list.issues.length).toBe(0);
       done();
     }, 0);