Protected tags changes from backend maintainer review

app/models/concerns/protected_ref_access.rb

@@ -11,7 +11,7 @@ module ProtectedRefAccess
   end
   def check_access(user)
-    return true if user.is_admin?
+    return true if user.admin?
     project.team.max_member_access(user.id) >= access_level
   end

app/models/protected_ref_matcher.rb

@@ -4,7 +4,7 @@ class ProtectedRefMatcher
   end
   # Returns all protected refs that match the given ref name.
-  # This realizes all records from the scope built up so far, and does
+  # This checks all records from the scope built up so far, and does
   # _not_ return a relation.
   #
   # This method optionally takes in a list of `protected_refs` to search
@@ -38,6 +38,8 @@ class ProtectedRefMatcher
   end
   def wildcard_match?(ref_name)
+    return false unless wildcard?
+
     wildcard_regex === ref_name
   end

changelogs/unreleased/18471-restrict-tag-pushes-protected-tags.yml

 ---
-title: Protected Tags feature
+title: Tags can be protected, restricting creation of matching tags by user role
 merge_request: 10356
 author: