Skip to content
Snippets Groups Projects
Commit a7750f1b authored by Eric Eastwood's avatar Eric Eastwood
Browse files

Enable autocomplete on project snippets

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1210 disabled
autocomplete for personal snippets and project snippets. But we want
autocomplete on project snippets.
parent 025cbc2a
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -226,6 +226,8 @@ import initSettingsPanels from './settings_panels';
case 'projects:snippets:edit':
case 'projects:snippets:create':
case 'projects:snippets:update':
new gl.GLForm($('.snippet-form'), true);
break;
case 'snippets:new':
case 'snippets:edit':
case 'snippets:create':
Loading
Loading
Loading
Loading
@@ -9,4 +9,4 @@
.row-content-block.top-block.content-component-block
= render 'award_emoji/awards_block', awardable: @snippet, inline: true
 
#notes= render "shared/notes/notes_with_form", :autocomplete => false
#notes= render "shared/notes/notes_with_form", :autocomplete => true
Loading
Loading
@@ -33,20 +33,11 @@ describe 'Project snippets', :js, feature: true do
visit namespace_project_snippet_path(project.namespace, project, snippets[0])
end
 
it 'should not have autocomplete' do
wait_for_requests
request_count_before = page.driver.network_traffic.count
it 'should have autocomplete' do
find('#note_note').native.send_keys('')
fill_in 'note[note]', with: '@'
 
wait_for_requests
request_count_after = page.driver.network_traffic.count
# This selector probably won't be in place even if autocomplete was enabled
# but we want to make sure
expect(page).not_to have_selector('.atwho-view')
expect(request_count_before).to eq(request_count_after)
expect(page).to have_selector('.atwho-view')
end
end
end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment