Add latest changes from gitlab-org/gitlab@master

app/assets/javascripts/pipelines/components/pipelines_artifacts.vue

 <script>
-/* eslint-disable @gitlab/vue-i18n/no-bare-strings */
+/* eslint-disable @gitlab/vue-require-i18n-strings */
 import { GlLink, GlTooltipDirective } from '@gitlab/ui';
 import Icon from '~/vue_shared/components/icon.vue';

app/assets/javascripts/registry/explorer/components/project_empty_state.vue

@@ -14,15 +14,15 @@ export default {
   computed: {
     ...mapState(['config']),
     dockerBuildCommand() {
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       return `docker build -t ${this.config.repositoryUrl} .`;
     },
     dockerPushCommand() {
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       return `docker push ${this.config.repositoryUrl}`;
     },
     dockerLoginCommand() {
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       return `docker login ${this.config.registryHostUrlWithPort}`;
     },
   },

app/assets/javascripts/registry/list/components/project_empty_state.vue

@@ -37,15 +37,15 @@ export default {
   },
   computed: {
     dockerBuildCommand() {
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       return `docker build -t ${this.repositoryUrl} .`;
     },
     dockerPushCommand() {
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       return `docker push ${this.repositoryUrl}`;
     },
     dockerLoginCommand() {
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       return `docker login ${this.registryHostUrlWithPort}`;
     },
     noContainerImagesText() {

app/assets/javascripts/reports/components/report_link.vue

 <script>
-/* eslint-disable @gitlab/vue-i18n/no-bare-strings */
+/* eslint-disable @gitlab/vue-require-i18n-strings */
 export default {
   name: 'ReportIssueLink',
   props: {

app/assets/javascripts/repository/components/table/row.vue

@@ -151,7 +151,7 @@ export default {
       >
         {{ fullPath }}
       </component>
-      <!-- eslint-disable-next-line @gitlab/vue-i18n/no-bare-strings -->
+      <!-- eslint-disable-next-line @gitlab/vue-require-i18n-strings -->
       <gl-badge v-if="lfsOid" variant="default" class="label-lfs ml-1">LFS</gl-badge>
       <template v-if="isSubmodule">
         @ <gl-link :href="submoduleTreeUrl" class="commit-sha">{{ shortSha }}</gl-link>

app/assets/javascripts/repository/graphql.js

@@ -39,7 +39,7 @@ const defaultClient = createDefaultClient(
     cacheConfig: {
       fragmentMatcher,
       dataIdFromObject: obj => {
-        /* eslint-disable @gitlab/i18n/no-non-i18n-strings */
+        /* eslint-disable @gitlab/require-i18n-strings */
         // eslint-disable-next-line no-underscore-dangle
         switch (obj.__typename) {
           // We need to create a dynamic ID for each entry
@@ -55,7 +55,7 @@ const defaultClient = createDefaultClient(
             // eslint-disable-next-line no-underscore-dangle
             return obj.id || obj._id;
         }
-        /* eslint-enable @gitlab/i18n/no-non-i18n-strings */
+        /* eslint-enable @gitlab/require-i18n-strings */
       },
     },
   },

app/assets/javascripts/repository/utils/title.js

@@ -9,7 +9,7 @@ export const setTitle = (pathMatch, ref, project) => {
   const path = pathMatch.replace(/^\//, '');
   const isEmpty = path === '';
-  /* eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings */
+  /* eslint-disable-next-line @gitlab/require-i18n-strings */
   document.title = `${isEmpty ? 'Files' : path} · ${ref} · ${project} ${DEFAULT_TITLE}`;
 };

app/assets/javascripts/search_autocomplete.js

@@ -420,11 +420,11 @@ export class SearchAutocomplete {
   onClick(item, $el, e) {
     if (window.location.pathname.indexOf(item.url) !== -1) {
       if (!e.metaKey) e.preventDefault();
-      /* eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings */
+      /* eslint-disable-next-line @gitlab/require-i18n-strings */
       if (item.category === 'Projects') {
         this.projectInputEl.val(item.id);
       }
-      /* eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings */
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       if (item.category === 'Groups') {
         this.groupInputEl.val(item.id);
       }

app/assets/javascripts/sidebar/components/assignees/assignees.vue

@@ -4,7 +4,7 @@ import UncollapsedAssigneeList from '../assignees/uncollapsed_assignee_list.vue'
 export default {
   // name: 'Assignees' is a false positive: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/26#possible-false-positives
-  // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+  // eslint-disable-next-line @gitlab/require-i18n-strings
   name: 'Assignees',
   components: {
     CollapsedAssigneeList,

app/assets/javascripts/sidebar/components/time_tracking/time_tracker.vue

@@ -40,6 +40,7 @@ export default {
     limitToHours: {
       type: Boolean,
       default: false,
+      required: false,
     },
     rootPath: {
       type: String,

app/assets/javascripts/sidebar/queries/updateStatus.mutation.graphql

-mutation ($projectPath: ID!, $iid: String!, $healthStatus: HealthStatus) {
-  updateIssue(input: { projectPath: $projectPath, iid: $iid, healthStatus: $healthStatus}) {
+mutation($projectPath: ID!, $iid: String!, $healthStatus: HealthStatus) {
+  updateIssue(input: { projectPath: $projectPath, iid: $iid, healthStatus: $healthStatus }) {
     issue {
       healthStatus
     }
+    errors
   }
 }

app/assets/javascripts/snippets/components/snippet_header.vue

@@ -137,7 +137,10 @@ export default {
           mutation: DeleteSnippetMutation,
           variables: { id: this.snippet.id },
         })
-        .then(() => {
+        .then(({ data }) => {
+          if (data?.destroySnippet?.errors) {
+            throw new Error(data?.destroySnippet?.errors[0]);
+          }
           this.isDeleting = false;
           this.errorMessage = undefined;
           this.closeDeleteModal();

app/assets/javascripts/tracking.js

@@ -54,7 +54,7 @@ export default class Tracking {
   static event(category = document.body.dataset.page, action = 'generic', data = {}) {
     if (!this.enabled()) return false;
-    // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+    // eslint-disable-next-line @gitlab/require-i18n-strings
     if (!category) throw new Error('Tracking: no category provided for tracking.');
     const { label, property, value, context } = data;

app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment.vue

@@ -5,7 +5,7 @@ import { MANUAL_DEPLOY, WILL_DEPLOY, CREATED } from './constants';
 export default {
   // name: 'Deployment' is a false positive: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/26#possible-false-positives
-  // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+  // eslint-disable-next-line @gitlab/require-i18n-strings
   name: 'Deployment',
   components: {
     DeploymentActions,

app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue

 <script>
-/* eslint-disable @gitlab/vue-i18n/no-bare-strings */
+/* eslint-disable @gitlab/vue-require-i18n-strings */
 import { GlLoadingIcon } from '@gitlab/ui';
 import Flash from '~/flash';
 import tooltip from '~/vue_shared/directives/tooltip';
@@ -86,7 +86,7 @@ export default {
         .then(res => res.data)
         .then(data => {
           // False positive i18n lint: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/26
-          // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+          // eslint-disable-next-line @gitlab/require-i18n-strings
           if (data.message === 'Branch was deleted') {
             eventHub.$emit('MRWidgetUpdateRequested', () => {
               this.isMakingRequest = false;

app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue

@@ -42,7 +42,7 @@ import { setFaviconOverlay } from '../lib/utils/common_utils';
 export default {
   el: '#js-vue-mr-widget',
   // False positive i18n lint: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/25
-  // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+  // eslint-disable-next-line @gitlab/require-i18n-strings
   name: 'MRWidget',
   components: {
     Loading,

app/assets/javascripts/vue_shared/components/changed_file_icon.vue

@@ -40,7 +40,7 @@ export default {
   computed: {
     changedIcon() {
       // False positive i18n lint: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/26
-      // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings
+      // eslint-disable-next-line @gitlab/require-i18n-strings
       const suffix = this.file.staged && this.showStagedIcon ? '-solid' : '';
       return `${getCommitIconMap(this.file).icon}${suffix}`;

app/assets/javascripts/vue_shared/components/content_viewer/content_viewer.vue

@@ -8,6 +8,7 @@ export default {
     content: {
       type: String,
       default: '',
+      required: false,
     },
     path: {
       type: String,

app/assets/javascripts/vue_shared/components/content_viewer/viewers/image_viewer.vue

@@ -16,6 +16,7 @@ export default {
     renderInfo: {
       type: Boolean,
       default: true,
+      required: false,
     },
     innerCssClasses: {
       type: [Array, Object, String],

app/assets/javascripts/vue_shared/components/markdown/header.vue

@@ -39,10 +39,10 @@ export default {
     mdTable() {
       return [
         // False positive i18n lint: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/26
-        '| header | header |', // eslint-disable-line @gitlab/i18n/no-non-i18n-strings
+        '| header | header |', // eslint-disable-line @gitlab/require-i18n-strings
         '| ------ | ------ |',
-        '| cell | cell |', // eslint-disable-line @gitlab/i18n/no-non-i18n-strings
-        '| cell | cell |', // eslint-disable-line @gitlab/i18n/no-non-i18n-strings
+        '| cell | cell |', // eslint-disable-line @gitlab/require-i18n-strings
+        '| cell | cell |', // eslint-disable-line @gitlab/require-i18n-strings
       ].join('\n');
     },
     mdSuggestion() {