Merge branch 'security-label-xss-11-4' into 'security-11-4'

[11.4] Escape html entities when no label found See merge request gitlab/gitlabhq!2749

Merge branch 'security-label-xss-11-4' into 'security-11-4'
b5fe07e4 · John Jarvis · dc4f76e3 · 3d4ffa2f · b5fe07e4 · b5fe07e4
Commit b5fe07e4 authored 6 years ago by John Jarvis
--- a/changelogs/unreleased/54427-label-xss.yml
+++ b/changelogs/unreleased/54427-label-xss.yml
+---
+title: Escape html entities in LabelReferenceFilter when no label found
+merge_request:
+author:
+type: security
--- a/lib/banzai/filter/label_reference_filter.rb
+++ b/lib/banzai/filter/label_reference_filter.rb
@@ -29,7 +29,7 @@ module Banzai
          if label
            yield match, label.id, project, namespace, $~
          else
-            match
+            escape_html_entities(match)
          end
        end
      end
@@ -102,6 +102,10 @@ module Banzai
        CGI.unescapeHTML(text.to_s)
      end
  
+      def escape_html_entities(text)
+        CGI.escapeHTML(text.to_s)
+      end
+
      def object_link_title(object, matches)
        # use title of wrapped element instead
        nil

--- a/spec/lib/banzai/filter/label_reference_filter_spec.rb
+++ b/spec/lib/banzai/filter/label_reference_filter_spec.rb
@@ -236,6 +236,24 @@ describe Banzai::Filter::LabelReferenceFilter do
    end
  end
  
+  context 'References with html entities' do
+    let!(:label)     { create(:label, name: '&lt;html&gt;', project: project) }
+
+    it 'links to a valid reference' do
+      doc = reference_filter('See ~"&lt;html&gt;"')
+
+      expect(doc.css('a').first.attr('href')).to eq urls
+        .project_issues_url(project, label_name: label.name)
+      expect(doc.text).to eq 'See <html>'
+    end
+
+    it 'ignores invalid label names and escapes entities' do
+      act = %(Label #{Label.reference_prefix}"&lt;non valid&gt;")
+
+      expect(reference_filter(act).to_html).to eq act
+    end
+  end
+
  describe 'consecutive references' do
    let(:bug) { create(:label, name: 'bug', project: project) }
    let(:feature_proposal) { create(:label, name: 'feature proposal', project: project) }