Skip to content
Snippets Groups Projects
Commit b82ccf2c authored by Bastian Blank's avatar Bastian Blank
Browse files

Don't try to set any ACL on uploaded objects

Set ACL of uploaded objects to not-public (fog-aws) or no ACL at all
(fog-google).  Value is ignored by other supported backends (fog-aliyun,
fog-openstack, fog-rackspace)

This allows uploads to GCS with ACL support disabled.
parent 50a1e01f
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -278,8 +278,12 @@ module ObjectStorage
self.class.object_store_credentials
end
 
# Set ACL of uploaded objects to not-public (fog-aws)[1] or no ACL at all
# (fog-google). Value is ignored by other supported backends (fog-aliyun,
# fog-openstack, fog-rackspace)
# [1]: https://github.com/fog/fog-aws/blob/daa50bb3717a462baf4d04d0e0cbfc18baacb541/lib/fog/aws/models/storage/file.rb#L152-L159
def fog_public
false
nil
end
 
def delete_migrated_file(migrated_file)
Loading
Loading
Loading
Loading
@@ -375,7 +375,7 @@ describe ObjectStorage do
describe '#fog_public' do
subject { uploader.fog_public }
 
it { is_expected.to eq(false) }
it { is_expected.to eq(nil) }
end
 
describe '.workhorse_authorize' do
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment