Skip to content
Snippets Groups Projects
Commit bcfd9386 authored by Jacob Vosmaer (GitLab)'s avatar Jacob Vosmaer (GitLab)
Browse files

Fix popen bug in `rake gitlab:satellites:create`

The Satellite#create method no longer sets the `$?` global variable.
Instead, we can use the method return value to test if the satellite was
created successfully
parent bfd44948
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -8,6 +8,7 @@ v 6.8.0
- Create branches via API (sponsored by O'Reilly Media)
- Changed permission of gitlab-satellites directory not to be world accessible
- Protected branch does not allow force push
- Fix popen bug in `rake gitlab:satellites:create`
 
v 6.7.3
- Fix the merge notification email not being sent (Pierre de La Morinerie)
Loading
Loading
Loading
Loading
@@ -27,11 +27,8 @@ namespace :gitlab do
if project.satellite.exists?
puts "exists already".green
else
puts ""
project.satellite.create
print "... "
if $?.success?
print "\n... "
if project.satellite.create
puts "created".green
else
puts "error".red
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment