Merge branch 'master' into 'master'

Use the same standard for method names on project activity and menu page objects

See merge request gitlab-org/gitlab-ce!24738

qa/qa/page/project/activity.rb

@@ -6,7 +6,7 @@ module QA
           element :push_events, "event_filter_link EventFilter::PUSH, _('Push events')" # rubocop:disable QA/ElementWithPattern
         end
-        def go_to_push_events
+        def click_push_events
           click_on 'Push events'
         end
       end

qa/qa/page/project/menu.rb

@@ -30,7 +30,7 @@ module QA
           end
         end
-        def go_to_activity
+        def click_activity
           within_sidebar do
             click_element(:activity_link)
           end

qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb

@@ -14,8 +14,8 @@ module QA
         end
         project_push.project.visit!
-        Page::Project::Menu.perform(&:go_to_activity)
-        Page::Project::Activity.perform(&:go_to_push_events)
+        Page::Project::Menu.perform(&:click_activity)
+        Page::Project::Activity.perform(&:click_push_events)
         expect(page).to have_content('pushed new branch master')
       end