Huge replace of old users_project and users_group references

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

app/assets/javascripts/admin.js.coffee

@@ -46,10 +46,10 @@ class Admin
       modal.hide()
       $('.change-owner-link').show()
-    $('li.users_project').bind 'ajax:success', ->
+    $('li.project_member').bind 'ajax:success', ->
       Turbolinks.visit(location.href)
-    $('li.users_group').bind 'ajax:success', ->
+    $('li.group_member').bind 'ajax:success', ->
       Turbolinks.visit(location.href)
 @Admin = Admin

app/assets/javascripts/groups.js.coffee

 class GroupMembers
   constructor: ->
-    $('li.users_group').bind 'ajax:success', ->
+    $('li.group_member').bind 'ajax:success', ->
       $(this).fadeOut()
 @GroupMembers = GroupMembers

app/controllers/admin/groups_controller.rb

@@ -8,7 +8,7 @@ class Admin::GroupsController < Admin::ApplicationController
   end
   def show
-    @members = @group.members.order("group_access DESC").page(params[:members_page]).per(30)
+    @members = @group.members.order("access_level DESC").page(params[:members_page]).per(30)
     @projects = @group.projects.page(params[:projects_page]).per(30)
   end
@@ -40,7 +40,7 @@ class Admin::GroupsController < Admin::ApplicationController
   end
   def project_teams_update
-    @group.add_users(params[:user_ids].split(','), params[:group_access])
+    @group.add_users(params[:user_ids].split(','), params[:access_level])
     redirect_to [:admin, @group], notice: 'Users were successfully added.'
   end

app/controllers/admin/projects_controller.rb

@@ -16,10 +16,10 @@ class Admin::ProjectsController < Admin::ApplicationController
   def show
     if @group
-      @group_members = @group.members.order("group_access DESC").page(params[:group_members_page]).per(30)
+      @group_members = @group.members.order("access_level DESC").page(params[:group_members_page]).per(30)
     end
-    @project_members = @project.users_projects.page(params[:project_members_page]).per(30)
+    @project_members = @project.project_members.page(params[:project_members_page]).per(30)
   end
   def transfer

app/controllers/groups_controller.rb

@@ -65,15 +65,15 @@ class GroupsController < ApplicationController
   def members
     @project = group.projects.find(params[:project_id]) if params[:project_id]
-    @members = group.users_groups
+    @members = group.group_members
     if params[:search].present?
       users = group.users.search(params[:search]).to_a
       @members = @members.where(user_id: users)
     end
-    @members = @members.order('group_access DESC').page(params[:page]).per(50)
-    @users_group = UsersGroup.new
+    @members = @members.order('access_level DESC').page(params[:page]).per(50)
+    @users_group = GroupMember.new
   end
   def edit

app/controllers/profiles/groups_controller.rb

@@ -2,11 +2,11 @@ class Profiles::GroupsController < ApplicationController
   layout "profile"
   def index
-    @user_groups = current_user.users_groups.page(params[:page]).per(20)
+    @user_groups = current_user.group_members.page(params[:page]).per(20)
   end
   def leave
-    @users_group = group.users_groups.where(user_id: current_user.id).first
+    @users_group = group.group_members.where(user_id: current_user.id).first
     if can?(current_user, :destroy, @users_group)
       @users_group.destroy
       redirect_to(profile_groups_path, info: "You left #{group.name} group.")

app/controllers/profiles/notifications_controller.rb

@@ -3,8 +3,8 @@ class Profiles::NotificationsController < ApplicationController
   def show
     @notification = current_user.notification
-    @users_projects = current_user.users_projects
-    @users_groups = current_user.users_groups
+    @users_projects = current_user.project_members
+    @users_groups = current_user.group_members
   end
   def update
@@ -14,11 +14,11 @@ class Profiles::NotificationsController < ApplicationController
                current_user.notification_level = params[:notification_level]
                current_user.save
              elsif type == 'group'
-               users_group = current_user.users_groups.find(params[:notification_id])
+               users_group = current_user.group_members.find(params[:notification_id])
                users_group.notification_level = params[:notification_level]
                users_group.save
              else
-               users_project = current_user.users_projects.find(params[:notification_id])
+               users_project = current_user.project_members.find(params[:notification_id])
                users_project.notification_level = params[:notification_level]
                users_project.save
              end

app/controllers/projects/team_members_controller.rb

@@ -6,17 +6,17 @@ class Projects::TeamMembersController < Projects::ApplicationController
   def index
     @group = @project.group
-    @users_projects = @project.users_projects.order('project_access DESC')
+    @users_projects = @project.project_members.order('access_level DESC')
   end
   def new
-    @user_project_relation = project.users_projects.new
+    @user_project_relation = project.project_members.new
   end
   def create
     users = User.where(id: params[:user_ids].split(','))
-    @project.team << [users, params[:project_access]]
+    @project.team << [users, params[:access_level]]
     if params[:redirect_to]
       redirect_to params[:redirect_to]
@@ -26,7 +26,7 @@ class Projects::TeamMembersController < Projects::ApplicationController
   end
   def update
-    @user_project_relation = project.users_projects.find_by(user_id: member)
+    @user_project_relation = project.project_members.find_by(user_id: member)
     @user_project_relation.update_attributes(member_params)
     unless @user_project_relation.valid?
@@ -36,7 +36,7 @@ class Projects::TeamMembersController < Projects::ApplicationController
   end
   def destroy
-    @user_project_relation = project.users_projects.find_by(user_id: member)
+    @user_project_relation = project.project_members.find_by(user_id: member)
     @user_project_relation.destroy
     respond_to do |format|
@@ -46,7 +46,7 @@ class Projects::TeamMembersController < Projects::ApplicationController
   end
   def leave
-    project.users_projects.find_by(user_id: current_user).destroy
+    project.project_members.find_by(user_id: current_user).destroy
     respond_to do |format|
       format.html { redirect_to :back }
@@ -69,6 +69,6 @@ class Projects::TeamMembersController < Projects::ApplicationController
   end
   def member_params
-    params.require(:team_member).permit(:user_id, :project_access)
+    params.require(:team_member).permit(:user_id, :access_level)
   end
 end

app/controllers/users_groups_controller.rb

-class UsersGroupsController < ApplicationController
+class GroupMembersController < ApplicationController
   before_filter :group
   # Authorize
@@ -7,18 +7,18 @@ class UsersGroupsController < ApplicationController
   layout 'group'
   def create
-    @group.add_users(params[:user_ids].split(','), params[:group_access])
+    @group.add_users(params[:user_ids].split(','), params[:access_level])
     redirect_to members_group_path(@group), notice: 'Users were successfully added.'
   end
   def update
-    @member = @group.users_groups.find(params[:id])
+    @member = @group.group_members.find(params[:id])
     @member.update_attributes(member_params)
   end
   def destroy
-    @users_group = @group.users_groups.find(params[:id])
+    @users_group = @group.group_members.find(params[:id])
     if can?(current_user, :destroy, @users_group)  # May fail if last owner.
       @users_group.destroy
       respond_to do |format|
@@ -43,6 +43,6 @@ class UsersGroupsController < ApplicationController
   end
   def member_params
-    params.require(:users_group).permit(:group_access, :user_id)
+    params.require(:users_group).permit(:access_level, :user_id)
   end
 end

app/finders/projects_finder.rb

@@ -19,10 +19,8 @@ class ProjectsFinder
         # Return ALL group projects
         group.projects
       else
-        projects_members = UsersProject.where(
-          project_id: group.projects,
-          user_id: current_user
-        )
+        projects_members = ProjectMember.in_projects(group.projects).
+          with_user(current_user)
         if projects_members.any?
           # User is a project member

app/mailers/emails/groups.rb

 module Emails
   module Groups
-    def group_access_granted_email(user_group_id)
-      @membership = UsersGroup.find(user_group_id)
+    def access_level_granted_email(user_group_id)
+      @membership = GroupMember.find(user_group_id)
       @group = @membership.group
       @target_url = group_url(@group)
       mail(to: @membership.user.email,

app/mailers/emails/projects.rb

 module Emails
   module Projects
-    def project_access_granted_email(user_project_id)
-      @users_project = UsersProject.find user_project_id
+    def access_level_granted_email(user_project_id)
+      @users_project = ProjectMember.find user_project_id
       @project = @users_project.project
       @target_url = project_url(@project)
       mail(to: @users_project.user.email,

app/models/ability.rb

@@ -14,7 +14,7 @@ class Ability
       when "MergeRequest" then merge_request_abilities(user, subject)
       when "Group" then group_abilities(user, subject)
       when "Namespace" then namespace_abilities(user, subject)
-      when "UsersGroup" then users_group_abilities(user, subject)
+      when "GroupMember" then users_group_abilities(user, subject)
       else []
       end.concat(global_abilities(user))
     end

app/models/concerns/notifiable.rb

 # == Notifiable concern
 #
-# Contains notification functionality shared between UsersProject and UsersGroup
+# Contains notification functionality
 #
 module Notifiable
   extend ActiveSupport::Concern

app/models/group.rb

@@ -17,8 +17,8 @@ require 'carrierwave/orm/activerecord'
 require 'file_size_validator'
 class Group < Namespace
-  has_many :users_groups, dependent: :destroy
-  has_many :users, through: :users_groups
+  has_many :group_members, dependent: :destroy, as: :source, class_name: 'GroupMember'
+  has_many :users, through: :group_members
   validate :avatar_type, if: ->(user) { user.avatar_changed? }
   validates :avatar, file_size: { maximum: 100.kilobytes.to_i }
@@ -30,22 +30,22 @@ class Group < Namespace
   end
   def owners
-    @owners ||= users_groups.owners.map(&:user)
+    @owners ||= group_members.owners.map(&:user)
   end
-  def add_users(user_ids, group_access)
+  def add_users(user_ids, access_level)
     user_ids.compact.each do |user_id|
-      user = self.users_groups.find_or_initialize_by(user_id: user_id)
-      user.update_attributes(group_access: group_access)
+      user = self.group_members.find_or_initialize_by(user_id: user_id)
+      user.update_attributes(access_level: access_level)
     end
   end
-  def add_user(user, group_access)
-    self.users_groups.create(user_id: user.id, group_access: group_access)
+  def add_user(user, access_level)
+    self.group_members.create(user_id: user.id, access_level: access_level)
   end
   def add_owner(user)
-    self.add_user(user, UsersGroup::OWNER)
+    self.add_user(user, Gitlab::Access::OWNER)
   end
   def has_owner?(user)
@@ -61,7 +61,7 @@ class Group < Namespace
   end
   def members
-    users_groups
+    group_members
   end
   def avatar_type

app/models/group_member.rb

-class GroupMember < Member
-end

app/models/member.rb

@@ -8,11 +8,13 @@ class Member < ActiveRecord::Base
   validates :user, presence: true
   validates :source, presence: true
   validates :user_id, uniqueness: { scope: [:source_type, :source_id], message: "already exists in source" }
-  validates :access_level, inclusion: { in: Gitlab::Access.values }, presence: true
-  scope :guests, -> { where(group_access: GUEST) }
-  scope :reporters, -> { where(group_access: REPORTER) }
-  scope :developers, -> { where(group_access: DEVELOPER) }
-  scope :masters,  -> { where(group_access: MASTER) }
-  scope :owners,  -> { where(group_access: OWNER) }
+  validates :access_level, inclusion: { in: Gitlab::Access.all_values }, presence: true
+  scope :guests, -> { where(access_level: GUEST) }
+  scope :reporters, -> { where(access_level: REPORTER) }
+  scope :developers, -> { where(access_level: DEVELOPER) }
+  scope :masters,  -> { where(access_level: MASTER) }
+  scope :owners,  -> { where(access_level: OWNER) }
+
+  delegate :name, :username, :email, to: :user, prefix: true
 end

app/models/members/group_member.rb

+class GroupMember < Member
+  SOURCE_TYPE = 'Group'
+
+  # Make sure group member points only to group as it source
+  default_value_for :source_type, SOURCE_TYPE
+  validates_format_of :source_type, with: /\AGroup\z/
+  default_scope { where(source_type: SOURCE_TYPE) }
+
+  scope :with_group, ->(group) { where(source_id: group.id) }
+  scope :with_user, ->(user) { where(user_id: user.id) }
+
+  after_create :notify_create
+  after_update :notify_update
+
+  def self.access_level_roles
+    Gitlab::Access.options_with_owner
+  end
+
+  def group
+    source
+  end
+
+  def access_field
+    access_level
+  end
+
+  def notify_create
+    notification_service.new_group_member(self)
+  end
+
+  def notify_update
+    if access_level_changed?
+      notification_service.update_group_member(self)
+    end
+  end
+
+  def notification_service
+    NotificationService.new
+  end
+end

app/models/users_project.rb → app/models/members/project_member.rb

-# == Schema Information
-#
-# Table name: users_projects
-#
-#  id                 :integer          not null, primary key
-#  user_id            :integer          not null
-#  project_id         :integer          not null
-#  created_at         :datetime
-#  updated_at         :datetime
-#  project_access     :integer          default(0), not null
-#  notification_level :integer          default(3), not null
-#
-
-class UsersProject < ActiveRecord::Base
-  include Gitlab::ShellAdapter
-  include Notifiable
-  include Gitlab::Access
-
-  belongs_to :user
-  belongs_to :project
-
-  validates :user, presence: true
-  validates :user_id, uniqueness: { scope: [:project_id], message: "already exists in project" }
-  validates :project_access, inclusion: { in: Gitlab::Access.values }, presence: true
-  validates :project, presence: true
-  delegate :name, :username, :email, to: :user, prefix: true
-
-  scope :guests, -> { where(project_access: GUEST) }
-  scope :reporters, -> { where(project_access: REPORTER) }
-  scope :developers, -> { where(project_access: DEVELOPER) }
-  scope :masters,  -> { where(project_access: MASTER) }
-  scope :in_project, ->(project) { where(project_id: project.id) }
-  scope :in_projects, ->(projects) { where(project_id: projects.map { |p| p.id }) }
-  scope :with_user, ->(user) { where(user_id: user.id) }
+class ProjectMember < Member
+  SOURCE_TYPE = 'Project'
+  include Gitlab::ShellAdapter
+  # Make sure project member points only to project as it source
+  default_value_for :source_type, SOURCE_TYPE
+  validates_format_of :source_type, with: /\AProject\z/
+  default_scope { where(source_type: SOURCE_TYPE) }
   after_create :post_create_hook
   after_update :post_update_hook
   after_destroy :post_destroy_hook
+  scope :in_project, ->(project) { where(source_id: project.id) }
+  scope :in_projects, ->(projects) { where(source_id: projects.pluck(:id)) }
+  scope :with_user, ->(user) { where(user_id: user.id) }
+
   class << self
     # Add users to project teams with passed access option
@@ -50,7 +27,7 @@ class UsersProject < ActiveRecord::Base
     #   add_users_into_projects(
     #     project_ids,
     #     user_ids,
-    #     UsersProject::MASTER
+    #     ProjectMember::MASTER
     #   )
     #
     #   add_users_into_projects(
@@ -60,20 +37,20 @@ class UsersProject < ActiveRecord::Base
     #   )
     #
     def add_users_into_projects(project_ids, user_ids, access)
-      project_access = if roles_hash.has_key?(access)
-                         roles_hash[access]
-                       elsif roles_hash.values.include?(access.to_i)
-                         access
-                       else
-                         raise "Non valid access"
-                       end
-
-      UsersProject.transaction do
+      access_level = if roles_hash.has_key?(access)
+                       roles_hash[access]
+                     elsif roles_hash.values.include?(access.to_i)
+                       access
+                     else
+                       raise "Non valid access"
+                     end
+
+      ProjectMember.transaction do
         project_ids.each do |project_id|
           user_ids.each do |user_id|
-            users_project = UsersProject.new(project_access: project_access, user_id: user_id)
-            users_project.project_id = project_id
-            users_project.save
+            member = ProjectMember.new(access_level: access_level, user_id: user_id)
+            member.source_id = project_id
+            member.save
           end
         end
       end
@@ -84,10 +61,10 @@ class UsersProject < ActiveRecord::Base
     end
     def truncate_teams(project_ids)
-      UsersProject.transaction do
-        users_projects = UsersProject.where(project_id: project_ids)
-        users_projects.each do |users_project|
-          users_project.destroy
+      ProjectMember.transaction do
+        members = ProjectMember.where(source_id: project_ids)
+        members.each do |member|
+          member.destroy
         end
       end
@@ -110,7 +87,7 @@ class UsersProject < ActiveRecord::Base
   end
   def access_field
-    project_access
+    access_level
   end
   def owner?
@@ -129,7 +106,7 @@ class UsersProject < ActiveRecord::Base
   end
   def post_update_hook
-    notification_service.update_team_member(self) if self.project_access_changed?
+    notification_service.update_team_member(self) if self.access_level_changed?
   end
   def post_destroy_hook
@@ -149,4 +126,8 @@ class UsersProject < ActiveRecord::Base
   def system_hook_service
     SystemHooksService.new
   end
+
+  def project
+    source
+  end
 end

app/models/project_member.rb

-class ProjectMember < Member
-end