improvements to breadcrumb titles, links & nesting

app/assets/javascripts/group_name.js

@@ -5,12 +5,15 @@ export default class GroupName {
   constructor() {
     this.titleContainer = document.querySelector('.js-title-container');
     this.title = this.titleContainer.querySelector('.title');
-    this.titleWidth = this.title.offsetWidth;
-    this.groupTitle = this.titleContainer.querySelector('.group-title');
-    this.groups = this.titleContainer.querySelectorAll('.group-path');
-    this.toggle = null;
-    this.isHidden = false;
-    this.init();
+
+    if (this.title) {
+      this.titleWidth = this.title.offsetWidth;
+      this.groupTitle = this.titleContainer.querySelector('.group-title');
+      this.groups = this.titleContainer.querySelectorAll('.group-path');
+      this.toggle = null;
+      this.isHidden = false;
+      this.init();
+    }
   }
   init() {

app/helpers/breadcrumbs_helper.rb

+module BreadcrumbsHelper
+  def breadcrumbs_extra_links(text, link)
+    @breadcrumbs_extra_links ||= []
+    @breadcrumbs_extra_links.push({
+      text: text,
+      link: link
+    })
+  end
+
+  def breadcrumb_title_link
+    return @breadcrumb_link if @breadcrumb_link
+
+    if controller.available_action?(:index)
+      url_for(action: "index")
+    else
+      request.path
+    end
+  end
+end

app/views/admin/appearances/show.html.haml

+- @breadcrumb_title = "Appearance"
 - page_title "Appearance"
 %h3.page-title

app/views/admin/application_settings/show.html.haml

+- @breadcrumb_title = "Settings"
 - page_title "Settings"
 %h3.page-title Settings

app/views/admin/broadcast_messages/edit.html.haml

+- @breadcrumb_title = "Messages"
 - page_title "Broadcast Messages"
 = render 'form'

app/views/admin/broadcast_messages/index.html.haml

+- @breadcrumb_title = "Messages"
 - page_title "Broadcast Messages"
 %h3.page-title

app/views/admin/hooks/index.html.haml

+- @breadcrumb_title = "System Hooks"
 - page_title 'System Hooks'
 %h3.page-title
   System hooks

app/views/admin/services/index.html.haml

+- @breadcrumb_title = "Services Templates"
 - page_title "Service Templates"
 %h3.page-title Service templates
 %p.light Service template allows you to set default values for project services

app/views/dashboard/activity.html.haml

+- @breadcrumb_title = "Activity"
 - @hide_top_links = true
 - @no_container = true

app/views/dashboard/issues.html.haml

+- @hide_top_links = true
 - page_title "Issues"
 - header_title  "Issues", issues_dashboard_path(assignee_id: current_user.id)
 = content_for :meta_tags do

app/views/dashboard/merge_requests.html.haml

+- @hide_top_links = true
 - page_title "Merge Requests"
 - header_title  "Merge Requests", merge_requests_dashboard_path(assignee_id: current_user.id)

app/views/dashboard/projects/starred.html.haml

+- @hide_top_links = true
 - @no_container = true
 - page_title "Starred Projects"

app/views/dashboard/todos/index.html.haml

+- @hide_top_links = true
 - page_title "Todos"
 - header_title "Todos", dashboard_todos_path

app/views/explore/groups/index.html.haml

+- @hide_top_links = true
 - page_title    "Groups"
 - header_title  "Groups", dashboard_groups_path

app/views/explore/projects/index.html.haml

+- @hide_top_links = true
 - page_title    "Projects"
 - header_title  "Projects", dashboard_projects_path

app/views/explore/projects/starred.html.haml

+- @hide_top_links = true
 - page_title    "Projects"
 - header_title  "Projects", dashboard_projects_path

app/views/explore/projects/trending.html.haml

+- @hide_top_links = true
 - page_title    "Projects"
 - header_title  "Projects", dashboard_projects_path

app/views/groups/edit.html.haml

+- @breadcrumb_title = "Settings"
 = render "groups/settings_head"
 .panel.panel-default.prepend-top-default
   .panel-heading

app/views/groups/group_members/index.html.haml

+- @breadcrumb_title = "Members"
 - page_title "Members"
 .project-members-page.prepend-top-default

app/views/groups/issues.html.haml

+- @breadcrumb_title = "Issues"
 - page_title "Issues"
 - group_issues_exists = group_issues(@group).exists?
 = render "head_issues"