Merge branch 'fix-project-creation' into 'master'

Creator should be added as a master of the project on creation

Fixes: #4222

See merge request !2463

CHANGELOG

@@ -67,6 +67,7 @@ v 8.4.0 (unreleased)
   - Improve UX in builds artifacts browser
   - Increase default size of `data` column in `events` table when using MySQL
   - Expose button to CI Lint tool on project builds page
+  - Fix: Creator should be added as a master of the project on creation
 v 8.3.4
   - Use gitlab-workhorse 0.5.4 (fixes API routing bug)

app/services/projects/create_service.rb

@@ -95,7 +95,7 @@ module Projects
       system_hook_service.execute_hooks_for(@project, :create)
       unless @project.group
-        @project.team << [current_user, :master, current_user]
+        @project.team << [current_user, :master]
       end
       @project.import_start if @project.import?

spec/services/projects/create_service_spec.rb

@@ -32,6 +32,7 @@ describe Projects::CreateService, services: true do
       it { expect(@project).to be_valid }
       it { expect(@project.owner).to eq(@user) }
+      it { expect(@project.team.masters).to include(@user) }
       it { expect(@project.namespace).to eq(@user.namespace) }
     end