Skip to content
Snippets Groups Projects
Unverified Commit d00d60a6 authored by Ash McKenzie's avatar Ash McKenzie Committed by Ash McKenzie
Browse files

Allow UsageData.count to use count_by:

parent 9246fd57
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -176,8 +176,8 @@ module Gitlab
{} # augmented in EE
end
 
def count(relation, fallback: -1)
relation.count
def count(relation, count_by: nil, fallback: -1)
count_by ? relation.count(count_by) : relation.count
rescue ActiveRecord::StatementInvalid
fallback
end
Loading
Loading
Loading
Loading
@@ -234,6 +234,12 @@ describe Gitlab::UsageData do
expect(described_class.count(relation)).to eq(1)
end
 
it 'returns the count for count_by when provided' do
allow(relation).to receive(:count).with(:creator_id).and_return(2)
expect(described_class.count(relation, count_by: :creator_id)).to eq(2)
end
it 'returns the fallback value when counting fails' do
allow(relation).to receive(:count).and_raise(ActiveRecord::StatementInvalid.new(''))
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment