Skip to content
Snippets Groups Projects
Commit d01b817e authored by Filipa Lacerda's avatar Filipa Lacerda
Browse files

Remove duplicate escape in job sidebar

parent 6ebbd70f
No related branches found
No related tags found
No related merge requests found
<script>
import _ from 'underscore';
import CiIcon from '~/vue_shared/components/ci_icon.vue';
import Icon from '~/vue_shared/components/icon.vue';
import tooltip from '~/vue_shared/directives/tooltip';
Loading
Loading
@@ -27,7 +26,7 @@
return this.jobId === currentJobId;
},
tooltipText(job) {
return `${_.escape(job.name)} - ${job.status.tooltip}`;
return `${job.name} - ${job.status.tooltip}`;
},
},
};
Loading
Loading
---
title: Remove duplicate escape in job sidebar
merge_request:
author:
type: fixed
Loading
Loading
@@ -151,9 +151,8 @@ describe 'Jobs', :clean_gitlab_redis_shared_state do
end
 
it 'renders escaped tooltip name' do
page.within('aside.right-sidebar') do
expect(find('.active.build-job a')['data-original-title']).to eq('&lt;img src=x onerror=alert(document.domain)&gt; - passed')
end
page.find('.active.build-job a').hover
expect(page).to have_content('<img src=x onerror=alert(document.domain)> - passed')
end
end
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment