Address feedback

app/views/notify/repository_push_email.html.haml

@@ -26,10 +26,8 @@
   %h4 #{pluralize @message.diffs_count, "changed file"}:
-  - diff_files = @message.diffs
-
   %ul
-    - diff_files.each do |diff_file|
+    - @message.diffs.each do |diff_file|
       %li.file-stats
         %a{ href: "#{@message.target_url if @message.disable_diffs?}##{hexdigest(diff_file.file_path)}" }
           - if diff_file.deleted_file?
@@ -52,7 +50,7 @@
       %h5 The diff was not included because it is too large.
     - else
       %h4 Changes:
-      - diff_files.each do |diff_file|
+      - @message.diffs.each do |diff_file|
         - file_hash = hexdigest(diff_file.file_path)
         %li{ id: file_hash }
           %a{ href: @message.target_url + "##{file_hash}" }<

lib/gitlab/diff/file_collection/base.rb

@@ -2,7 +2,7 @@ module Gitlab
   module Diff
     module FileCollection
       class Base
-        attr_reader :project, :diff_options, :diff_view, :diff_refs, :fallback_diff_refs
+        attr_reader :project, :diff_options, :diff_refs, :fallback_diff_refs
         delegate :count, :size, :real_size, to: :diff_files