Add latest changes from gitlab-org/gitlab@master

spec/lib/gitlab/ci/build/policy/changes_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 describe Gitlab::Ci::Build::Policy::Changes do
-  set(:project) { create(:project) }
+  let_it_be(:project) { create(:project) }
   describe '#satisfied_by?' do
     describe 'paths matching' do
@@ -89,7 +89,7 @@ describe Gitlab::Ci::Build::Policy::Changes do
     end
     describe 'gitaly integration' do
-      set(:project) { create(:project, :repository) }
+      let_it_be(:project) { create(:project, :repository) }
       let(:pipeline) do
         create(:ci_empty_pipeline, project: project,
@@ -119,6 +119,7 @@ describe Gitlab::Ci::Build::Policy::Changes do
     end
     context 'when branch is created' do
+      let_it_be(:project) { create(:project, :repository) }
       let(:pipeline) do
         create(:ci_empty_pipeline, project: project,
                                    ref: 'feature',

spec/lib/gitlab/ci/build/policy/kubernetes_spec.rb

@@ -18,7 +18,7 @@ describe Gitlab::Ci::Build::Policy::Kubernetes do
   end
   context 'when kubernetes service is inactive' do
-    set(:project) { create(:project) }
+    let_it_be(:project) { create(:project) }
     it 'is not satisfied by a pipeline without kubernetes available' do
       expect(described_class.new('active'))

spec/lib/gitlab/ci/build/policy/variables_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 describe Gitlab::Ci::Build::Policy::Variables do
-  set(:project) { create(:project) }
+  let_it_be(:project) { create(:project) }
   let(:pipeline) do
     build(:ci_empty_pipeline, project: project, ref: 'master', source: :push)

spec/lib/gitlab/ci/config/external/file/local_spec.rb

@@ -3,13 +3,11 @@
 require 'spec_helper'
 describe Gitlab::Ci::Config::External::File::Local do
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user) }
-
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:sha) { '12345' }
   let(:context_params) { { project: project, sha: sha, user: user } }
   let(:context) { Gitlab::Ci::Config::External::Context.new(**context_params) }
-
   let(:params) { { local: location } }
   let(:local_file) { described_class.new(params, context) }

spec/lib/gitlab/ci/config/external/file/project_spec.rb

@@ -3,10 +3,9 @@
 require 'spec_helper'
 describe Gitlab::Ci::Config::External::File::Project do
-  set(:context_project) { create(:project) }
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user) }
-
+  let_it_be(:context_project) { create(:project) }
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:context_user) { user }
   let(:context_params) { { project: context_project, sha: '12345', user: context_user } }
   let(:context) { Gitlab::Ci::Config::External::Context.new(**context_params) }

spec/lib/gitlab/ci/config/external/file/template_spec.rb

@@ -3,14 +3,12 @@
 require 'spec_helper'
 describe Gitlab::Ci::Config::External::File::Template do
-  set(:project) { create(:project) }
-  set(:user) { create(:user) }
-
+  let_it_be(:project) { create(:project) }
+  let_it_be(:user) { create(:user) }
   let(:context_params) { { project: project, sha: '12345', user: user } }
   let(:context) { Gitlab::Ci::Config::External::Context.new(**context_params) }
   let(:template) { 'Auto-DevOps.gitlab-ci.yml' }
   let(:params) { { template: template } }
-
   let(:template_file) { described_class.new(params, context) }
   before do

spec/lib/gitlab/ci/config/external/mapper_spec.rb

@@ -5,9 +5,8 @@ require 'spec_helper'
 describe Gitlab::Ci::Config::External::Mapper do
   include StubRequests
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user) }
-
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:local_file) { '/lib/gitlab/ci/templates/non-existent-file.yml' }
   let(:remote_url) { 'https://gitlab.com/gitlab-org/gitlab-foss/blob/1234/.gitlab-ci-1.yml' }
   let(:template_file) { 'Auto-DevOps.gitlab-ci.yml' }

spec/lib/gitlab/ci/config/external/processor_spec.rb

@@ -5,10 +5,9 @@ require 'spec_helper'
 describe Gitlab::Ci::Config::External::Processor do
   include StubRequests
-  set(:project) { create(:project, :repository) }
-  set(:another_project) { create(:project, :repository) }
-  set(:user) { create(:user) }
-
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:another_project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:sha) { '12345' }
   let(:context_params) { { project: project, sha: sha, user: user } }
   let(:context) { Gitlab::Ci::Config::External::Context.new(**context_params) }

spec/lib/gitlab/ci/config_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Gitlab::Ci::Config do
   include StubRequests
-  set(:user) { create(:user) }
+  let_it_be(:user) { create(:user) }
   before do
     allow_next_instance_of(Gitlab::Ci::Config::External::Context) do |instance|

spec/lib/gitlab/ci/pipeline/chain/build_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Build do
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user, developer_projects: [project]) }
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user, developer_projects: [project]) }
   let(:pipeline) { Ci::Pipeline.new }
   let(:variables_attributes) do

spec/lib/gitlab/ci/pipeline/chain/command_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Command do
-  set(:project) { create(:project, :repository) }
+  let_it_be(:project) { create(:project, :repository) }
   describe '#initialize' do
     subject do

spec/lib/gitlab/ci/pipeline/chain/create_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Create do
-  set(:project) { create(:project) }
-  set(:user) { create(:user) }
+  let_it_be(:project) { create(:project) }
+  let_it_be(:user) { create(:user) }
   let(:pipeline) do
     build(:ci_empty_pipeline, project: project, ref: 'master')

spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Populate do
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user) }
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:pipeline) do
     build(:ci_pipeline, project: project, ref: 'master', user: user)

spec/lib/gitlab/ci/pipeline/chain/sequence_spec.rb

@@ -3,9 +3,8 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Sequence do
-  set(:project) { create(:project) }
-  set(:user) { create(:user) }
-
+  let_it_be(:project) { create(:project) }
+  let_it_be(:user) { create(:user) }
   let(:pipeline) { build_stubbed(:ci_pipeline) }
   let(:command) { Gitlab::Ci::Pipeline::Chain::Command.new }
   let(:first_step) { spy('first step') }

spec/lib/gitlab/ci/pipeline/chain/skip_spec.rb

@@ -3,9 +3,9 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Skip do
-  set(:project) { create(:project) }
-  set(:user) { create(:user) }
-  set(:pipeline) { create(:ci_pipeline, project: project) }
+  let_it_be(:project, reload: true) { create(:project) }
+  let_it_be(:user) { create(:user) }
+  let_it_be(:pipeline, reload: true) { create(:ci_pipeline, project: project) }
   let(:command) do
     Gitlab::Ci::Pipeline::Chain::Command.new(

spec/lib/gitlab/ci/pipeline/chain/validate/abilities_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Validate::Abilities do
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user) }
+  let_it_be(:project, reload: true) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:pipeline) do
     build_stubbed(:ci_pipeline, project: project)

spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb

@@ -3,10 +3,9 @@
 require 'spec_helper'
 describe Gitlab::Ci::Pipeline::Chain::Validate::Repository do
-  set(:project) { create(:project, :repository) }
-  set(:user) { create(:user) }
+  let_it_be(:project) { create(:project, :repository) }
+  let_it_be(:user) { create(:user) }
   let(:pipeline) { build_stubbed(:ci_pipeline) }
-
   let!(:step) { described_class.new(pipeline, command) }
   before do

spec/lib/gitlab/ci/status/composite_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 describe Gitlab::Ci::Status::Composite do
-  set(:pipeline) { create(:ci_pipeline) }
+  let_it_be(:pipeline) { create(:ci_pipeline) }
   before(:all) do
     @statuses = HasStatus::STATUSES_ENUM.map do |status, idx|

spec/lib/gitlab/ci/trace/chunked_io_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Gitlab::Ci::Trace::ChunkedIO, :clean_gitlab_redis_cache do
   include ChunkedIOHelpers
-  set(:build) { create(:ci_build, :running) }
+  let_it_be(:build) { create(:ci_build, :running) }
   let(:chunked_io) { described_class.new(build) }
   before do

spec/lib/gitlab/ci/trace/stream_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 describe Gitlab::Ci::Trace::Stream, :clean_gitlab_redis_cache do
-  set(:build) { create(:ci_build, :running) }
+  let_it_be(:build) { create(:ci_build, :running) }
   before do
     stub_feature_flags(ci_enable_live_trace: true)