Skip to content
Snippets Groups Projects
Unverified Commit e107ebc3 authored by Luke "Jared" Bennett's avatar Luke "Jared" Bennett
Browse files

Refactor PersistentUserCallout instantiations

Uses a new factory method to DRY instantiation.
parent f100c9ba
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -119,8 +119,7 @@ export default class Clusters {
 
static initDismissableCallout() {
const callout = document.querySelector('.js-cluster-security-warning');
if (callout) new PersistentUserCallout(callout); // eslint-disable-line no-new
PersistentUserCallout.factory(callout);
}
 
addListeners() {
Loading
Loading
Loading
Loading
@@ -2,6 +2,5 @@ import PersistentUserCallout from '~/persistent_user_callout';
 
document.addEventListener('DOMContentLoaded', () => {
const callout = document.querySelector('.gcp-signup-offer');
if (callout) new PersistentUserCallout(callout); // eslint-disable-line no-new
PersistentUserCallout.factory(callout);
});
Loading
Loading
@@ -3,8 +3,7 @@ import initGkeDropdowns from '~/projects/gke_cluster_dropdowns';
 
function initGcpSignupCallout() {
const callout = document.querySelector('.gcp-signup-offer');
if (callout) new PersistentUserCallout(callout); // eslint-disable-line no-new
PersistentUserCallout.factory(callout);
}
 
document.addEventListener('DOMContentLoaded', () => {
Loading
Loading
Loading
Loading
@@ -2,6 +2,5 @@ import PersistentUserCallout from '~/persistent_user_callout';
 
document.addEventListener('DOMContentLoaded', () => {
const callout = document.querySelector('.gcp-signup-offer');
if (callout) new PersistentUserCallout(callout); // eslint-disable-line no-new
PersistentUserCallout.factory(callout);
});
Loading
Loading
@@ -13,7 +13,7 @@ document.addEventListener('DOMContentLoaded', () => {
 
if (newClusterViews.indexOf(page) > -1) {
const callout = document.querySelector('.gcp-signup-offer');
if (callout) new PersistentUserCallout(callout); // eslint-disable-line no-new
PersistentUserCallout.factory(callout);
 
initGkeDropdowns();
}
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment