Skip to content
Snippets Groups Projects
Commit e3dd1ada authored by Bob Van Landuyt's avatar Bob Van Landuyt
Browse files

Skip specs for default relative positions

If a model has a default relative position we don't need to test that
it is moved to the end, it will instead get the default value assigned.
parent 536ebecf
No related branches found
No related tags found
No related merge requests found
# frozen_string_literal: true
 
RSpec.shared_examples "a class that supports relative positioning" do
RSpec.shared_examples 'a class that supports relative positioning' do
let(:item1) { create(factory, default_params) }
let(:item2) { create(factory, default_params) }
let(:new_item) { create(factory, default_params) }
Loading
Loading
@@ -11,6 +11,9 @@ RSpec.shared_examples "a class that supports relative positioning" do
 
describe '.move_nulls_to_end' do
it 'moves items with null relative_position to the end' do
skip("#{item1} has a default relative position") if item1.relative_position
skip("#{item2} has a default relative position") if item2.relative_position
described_class.move_nulls_to_end([item1, item2])
 
expect(item2.prev_relative_position).to eq item1.relative_position
Loading
Loading
@@ -19,6 +22,8 @@ RSpec.shared_examples "a class that supports relative positioning" do
end
 
it 'moves the item near the start position when there are no existing positions' do
skip("#{item1} has a default relative position") if item1.relative_position
described_class.move_nulls_to_end([item1])
 
expect(item1.relative_position).to eq(described_class::START_POSITION + described_class::IDEAL_DISTANCE)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment