Add few frontend improvements

app/assets/javascripts/jobs/components/sidebar_detail_row.vue

@@ -44,8 +44,12 @@
       <a
         :href="helpUrl"
         target="_blank"
+        rel="noopener noreferrer nofollow"
       >
-        <i class="fa fa-question-circle"></i>
+        <i
+          class="fa fa-question-circle"
+          aria-hidden="true"
+        ></i>
       </a>
     </span>
   </p>

app/assets/javascripts/jobs/components/sidebar_details_block.vue

@@ -22,6 +22,11 @@
         type: Boolean,
         required: true,
       },
+      runnerHelpUrl: {
+        type: String,
+        required: false,
+        default: '',
+      },
     },
     computed: {
       shouldRenderContent() {
@@ -127,7 +132,7 @@
           class="js-job-timeout"
           v-if="job.timeout"
           title="Timeout"
-          help-url="/help/ci/runners/README.html#setting-maximum-job-timeout-for-a-runner"
+          :help-url="runnerHelpUrl"
           :value="timeout"
         />
         <detail-row

app/assets/javascripts/jobs/job_details_bundle.js

@@ -51,6 +51,7 @@ export default () => {
         props: {
           isLoading: this.mediator.state.isLoading,
           job: this.mediator.store.state.job,
+          runnerHelpUrl: dataset.runnerHelpUrl,
         },
       });
     },

app/views/projects/jobs/show.html.haml

@@ -111,4 +111,4 @@
 .js-build-options{ data: javascript_build_options }
-#js-job-details-vue{ data: { endpoint: project_job_path(@project, @build, format: :json) } }
+#js-job-details-vue{ data: { endpoint: project_job_path(@project, @build, format: :json), runner_help_url: '/help/ci/runners/README.html#setting-maximum-job-timeout-for-a-runner' } }