Change gitlab_sign_in to sign_in where possible

spec/features/abuse_report_spec.rb

@@ -4,7 +4,7 @@ feature 'Abuse reports', feature: true do
   let(:another_user) { create(:user) }
   before do
-    gitlab_sign_in :user
+    sign_in(create(:user))
   end
   scenario 'Report abuse' do

spec/features/admin/admin_abuse_reports_spec.rb

@@ -5,7 +5,7 @@ describe "Admin::AbuseReports", feature: true, js: true  do
   context 'as an admin' do
     before do
-      gitlab_sign_in :admin
+      sign_in(create(:admin))
     end
     describe 'if a user has been reported for abuse' do

spec/features/admin/admin_active_tab_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 RSpec.describe 'admin active tab' do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   shared_examples 'page has active tab' do |title|

spec/features/admin/admin_appearance_spec.rb

@@ -4,7 +4,7 @@ feature 'Admin Appearance', feature: true do
   let!(:appearance) { create(:appearance) }
   scenario 'Create new appearance' do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
     visit admin_appearances_path
     fill_in 'appearance_title', with: 'MyCompany'
@@ -20,7 +20,7 @@ feature 'Admin Appearance', feature: true do
   end
   scenario 'Preview appearance' do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
     visit admin_appearances_path
     click_link "Preview"
@@ -34,7 +34,7 @@ feature 'Admin Appearance', feature: true do
   end
   scenario 'Appearance logo' do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
     visit admin_appearances_path
     attach_file(:appearance_logo, logo_fixture)
@@ -46,7 +46,7 @@ feature 'Admin Appearance', feature: true do
   end
   scenario 'Header logos' do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
     visit admin_appearances_path
     attach_file(:appearance_header_logo, logo_fixture)

spec/features/admin/admin_broadcast_messages_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 feature 'Admin Broadcast Messages', feature: true do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
     create(:broadcast_message, :expired, message: 'Migration to new server')
     visit admin_broadcast_messages_path
   end

spec/features/admin/admin_browse_spam_logs_spec.rb

@@ -4,7 +4,7 @@ describe 'Admin browse spam logs' do
   let!(:spam_log) { create(:spam_log, description: 'abcde ' * 20) }
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   scenario 'Browse spam logs' do

spec/features/admin/admin_browses_logs_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 describe 'Admin browses logs' do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   it 'shows available log files' do

spec/features/admin/admin_builds_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 describe 'Admin Builds' do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   describe 'GET /admin/builds' do

spec/features/admin/admin_cohorts_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 feature 'Admin cohorts page', feature: true do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   scenario 'See users count per month' do

spec/features/admin/admin_conversational_development_index_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 describe 'Admin Conversational Development Index' do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   context 'when usage ping is disabled' do

spec/features/admin/admin_deploy_keys_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'admin deploy keys', type: :feature do
   let!(:another_deploy_key) { create(:another_deploy_key, public: true) }
   before do
-    gitlab_sign_in(:admin)
+    sign_in(create(:admin))
   end
   it 'show all public deploy keys' do

spec/features/admin/admin_disables_git_access_protocol_spec.rb

@@ -8,7 +8,7 @@ feature 'Admin disables Git access protocol', feature: true do
   background do
     stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
-    gitlab_sign_in(admin)
+    sign_in(admin)
   end
   context 'with HTTP disabled' do

spec/features/admin/admin_disables_two_factor_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 feature 'Admin disables 2FA for a user', feature: true do
   scenario 'successfully', js: true do
-    gitlab_sign_in(:admin)
+    sign_in(create(:admin))
     user = create(:user, :two_factor)
     edit_user(user)
@@ -17,7 +17,7 @@ feature 'Admin disables 2FA for a user', feature: true do
   end
   scenario 'for a user without 2FA enabled' do
-    gitlab_sign_in(:admin)
+    sign_in(create(:admin))
     user = create(:user)
     edit_user(user)

spec/features/admin/admin_groups_spec.rb

@@ -6,9 +6,10 @@ feature 'Admin Groups', feature: true do
   let(:internal) { Gitlab::VisibilityLevel::INTERNAL }
   let(:user) { create :user }
   let!(:group) { create :group }
-  let!(:current_user) { gitlab_sign_in :admin }
+  let!(:current_user) { create(:admin) }
   before do
+    sign_in(current_user)
     stub_application_setting(default_group_visibility: internal)
   end

spec/features/admin/admin_health_check_spec.rb

@@ -5,7 +5,7 @@ feature "Admin Health Check", feature: true do
   before do
     stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   describe '#show' do

spec/features/admin/admin_hook_logs_spec.rb

@@ -6,7 +6,7 @@ feature 'Admin::HookLogs', feature: true do
   let(:hook_log) { create(:web_hook_log, web_hook: system_hook, internal_error_message: 'some error') }
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   scenario 'show list of hook logs' do

spec/features/admin/admin_hooks_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe 'Admin::Hooks', feature: true do
   before do
     @project = create(:project)
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
     @system_hook = create(:system_hook)
   end

spec/features/admin/admin_labels_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe 'admin issues labels' do
   let!(:feature_label) { Label.create(title: 'feature', template: true) }
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   describe 'list' do

spec/features/admin/admin_manage_applications_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 RSpec.describe 'admin manage applications', feature: true do
   before do
-    gitlab_sign_in :admin
+    sign_in(create(:admin))
   end
   it do

spec/features/admin/admin_projects_spec.rb

@@ -5,8 +5,10 @@ describe "Admin::Projects", feature: true  do
   let(:user) { create :user }
   let!(:project) { create(:project) }
-  let!(:current_user) do
-    gitlab_sign_in :admin
+  let!(:current_user) { create(:admin) }
+
+  before do
+    sign_in(current_user)
   end
   describe "GET /admin/projects" do