Merge branch 'frozen-string-enable-app-models' into 'master'

Enable frozen string in app/models/*.rb

See merge request gitlab-org/gitlab-ce!20851

app/models/system_note_metadata.rb

+# frozen_string_literal: true
+
 class SystemNoteMetadata < ActiveRecord::Base
   # These notes's action text might contain a reference that is external.
   # We should always force a deep validation upon references that are found

app/models/term_agreement.rb

+# frozen_string_literal: true
+
 class TermAgreement < ActiveRecord::Base
   belongs_to :term, class_name: 'ApplicationSetting::Term'
   belongs_to :user

app/models/timelog.rb

+# frozen_string_literal: true
+
 class Timelog < ActiveRecord::Base
   validates :time_spent, :user, presence: true
   validate :issuable_id_is_present

app/models/todo.rb

+# frozen_string_literal: true
+
 class Todo < ActiveRecord::Base
   include Sortable

app/models/tree.rb

+# frozen_string_literal: true
+
 class Tree
   include Gitlab::MarkupHelper

app/models/trending_project.rb

+# frozen_string_literal: true
+
 class TrendingProject < ActiveRecord::Base
   belongs_to :project

app/models/u2f_registration.rb

+# frozen_string_literal: true
+
 # Registration information for U2F (universal 2nd factor) devices, like Yubikeys
 class U2fRegistration < ActiveRecord::Base

app/models/upload.rb

+# frozen_string_literal: true
+
 class Upload < ActiveRecord::Base
   # Upper limit for foreground checksum processing
   CHECKSUM_THRESHOLD = 100.megabytes

app/models/user.rb

+# frozen_string_literal: true
+
 require 'carrierwave/orm/activerecord'
 class User < ActiveRecord::Base

app/models/user_agent_detail.rb

+# frozen_string_literal: true
+
 class UserAgentDetail < ActiveRecord::Base
   belongs_to :subject, polymorphic: true # rubocop:disable Cop/PolymorphicAssociations

app/models/user_callout.rb

+# frozen_string_literal: true
+
 class UserCallout < ActiveRecord::Base
   belongs_to :user

app/models/user_custom_attribute.rb

+# frozen_string_literal: true
+
 class UserCustomAttribute < ActiveRecord::Base
   belongs_to :user

app/models/user_interacted_project.rb

+# frozen_string_literal: true
+
 class UserInteractedProject < ActiveRecord::Base
   belongs_to :user
   belongs_to :project

app/models/user_synced_attributes_metadata.rb

+# frozen_string_literal: true
+
 class UserSyncedAttributesMetadata < ActiveRecord::Base
   belongs_to :user

app/models/users_star_project.rb

+# frozen_string_literal: true
+
 class UsersStarProject < ActiveRecord::Base
   belongs_to :project, counter_cache: :star_count, touch: true
   belongs_to :user

app/models/wiki_directory.rb

+# frozen_string_literal: true
+
 class WikiDirectory
   include ActiveModel::Validations

app/models/wiki_page.rb

+# frozen_string_literal: true
+
 # rubocop:disable Rails/ActiveRecordAliases
 class WikiPage
   PageChangedError = Class.new(StandardError)

changelogs/unreleased/frozen-string-enable-app-models.yml

+---
+title: Enable frozen string in app/models/*.rb
+merge_request: 20851
+author: gfyoung
+type: performance

spec/controllers/admin/services_controller_spec.rb

@@ -13,7 +13,7 @@ describe Admin::ServicesController do
     Service.available_services_names.each do |service_name|
       context "#{service_name}" do
         let!(:service) do
-          service_template = service_name.concat("_service").camelize.constantize
+          service_template = "#{service_name}_service".camelize.constantize
           service_template.where(template: true).first_or_create
         end