Skip to content
Snippets Groups Projects
Commit f83927eb authored by Filipa Lacerda's avatar Filipa Lacerda
Browse files

Change prop name to keep consistency with other props.

parent 21d88cda
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -23,7 +23,7 @@
* name
* ref_url
*/
commitRef: {
commit_ref: {
type: Object,
required: false,
default: () => ({}),
Loading
Loading
@@ -80,7 +80,7 @@
* @returns {Boolean}
*/
hasCommitRef() {
return this.commitRef && this.commitRef.name && this.commitRef.ref_url;
return this.commit_ref && this.commit_ref.name && this.commit_ref.ref_url;
},
 
/**
Loading
Loading
@@ -138,8 +138,8 @@
 
<a v-if="hasCommitRef"
class="monospace branch-name"
:href="commitRef.ref_url">
{{commitRef.name}}
:href="commit_ref.ref_url">
{{commit_ref.name}}
</a>
 
<div class="icon-container commit-icon commit-icon-container"></div>
Loading
Loading
Loading
Loading
@@ -10,7 +10,7 @@ describe('Commit component', () => {
el: document.querySelector('.test-commit-container'),
propsData: {
tag: false,
commitRef: {
commit_ref: {
name: 'master',
ref_url: 'http://localhost/namespace2/gitlabhq/tree/master',
},
Loading
Loading
@@ -34,7 +34,7 @@ describe('Commit component', () => {
 
props = {
tag: true,
commitRef: {
commit_ref: {
name: 'master',
ref_url: 'http://localhost/namespace2/gitlabhq/tree/master',
},
Loading
Loading
@@ -59,11 +59,11 @@ describe('Commit component', () => {
});
 
it('should render a link to the ref url', () => {
expect(component.$el.querySelector('.branch-name').getAttribute('href')).toEqual(props.commitRef.ref_url);
expect(component.$el.querySelector('.branch-name').getAttribute('href')).toEqual(props.commit_ref.ref_url);
});
 
it('should render the ref name', () => {
expect(component.$el.querySelector('.branch-name').textContent).toContain(props.commitRef.name);
expect(component.$el.querySelector('.branch-name').textContent).toContain(props.commit_ref.name);
});
 
it('should render the commit short sha with a link to the commit url', () => {
Loading
Loading
@@ -103,7 +103,7 @@ describe('Commit component', () => {
fixture.set('<div class="test-commit-container"></div>');
props = {
tag: false,
commitRef: {
commit_ref: {
name: 'master',
ref_url: 'http://localhost/namespace2/gitlabhq/tree/master',
},
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment