Add latest changes from gitlab-org/gitlab@master

changelogs/unreleased/zj-pg-connection-ff-gitaly.yml

+---
+title: Remove required dependecy of Postgresql for Gitaly
+merge_request: 18659
+author:
+type: other

lib/feature/gitaly.rb

@@ -19,7 +19,7 @@ class Feature
         default_on = DEFAULT_ON_FLAGS.include?(feature_flag)
         Feature.enabled?("gitaly_#{feature_flag}", default_enabled: default_on)
-      rescue ActiveRecord::NoDatabaseError
+      rescue ActiveRecord::NoDatabaseError, PG::ConnectionBad
         false
       end

qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb

@@ -4,9 +4,6 @@ module QA
   context 'Create' do
     describe 'Commit data' do
       before(:context) do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
-        Page::Main::Login.perform(&:sign_in_using_credentials)
-
         # Get the user's details to confirm they're included in the email patch
         @user = Resource::User.fabricate_via_api! do |user|
           user.username = Runtime::User.username
@@ -34,9 +31,12 @@ module QA
       end
       def view_commit
+        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Page::Main::Login.perform(&:sign_in_using_credentials)
+
         @project.visit!
-        Page::Project::Show.perform do |page| # rubocop:disable QA/AmbiguousPageObjectName
-          page.click_commit(@commit_message)
+        Page::Project::Show.perform do |show|
+          show.click_commit(@commit_message)
         end
       end

qa/qa/support/api.rb

@@ -14,7 +14,7 @@ module QA
           payload: payload,
           verify_ssl: false)
       rescue RestClient::ExceptionWithResponse => e
-        e.response
+        return_response_or_raise(e)
       end
       def get(url, raw_response: false)
@@ -24,7 +24,7 @@ module QA
           verify_ssl: false,
           raw_response: raw_response)
       rescue RestClient::ExceptionWithResponse => e
-        e.response
+        return_response_or_raise(e)
       end
       def put(url, payload)
@@ -34,7 +34,7 @@ module QA
           payload: payload,
           verify_ssl: false)
       rescue RestClient::ExceptionWithResponse => e
-        e.response
+        return_response_or_raise(e)
       end
       def delete(url)
@@ -43,7 +43,7 @@ module QA
           url: url,
           verify_ssl: false)
       rescue RestClient::ExceptionWithResponse => e
-        e.response
+        return_response_or_raise(e)
       end
       def head(url)
@@ -52,12 +52,18 @@ module QA
           url: url,
           verify_ssl: false)
       rescue RestClient::ExceptionWithResponse => e
-        e.response
+        return_response_or_raise(e)
       end
       def parse_body(response)
         JSON.parse(response.body, symbolize_names: true)
       end
+
+      def return_response_or_raise(error)
+        raise error unless error.respond_to?(:response) && error.response
+
+        error.response
+      end
     end
   end
 end