Merge branch 'frozen_string_lib_2' into 'master'

Add frozen_string_literal to lib part 2

See merge request gitlab-org/gitlab-ce!32094

lib/gitlab/profiler.rb

@@ -97,7 +97,7 @@ module Gitlab
           attr_reader :load_times_by_model, :private_token
           def debug(message, *)
-            message.gsub!(private_token, FILTERED_STRING) if private_token
+            message = message.gsub(private_token, FILTERED_STRING) if private_token
             _, type, time = *message.match(/(\w+) Load \(([0-9.]+)ms\)/)

lib/gitlab/quick_actions/substitution_definition.rb

@@ -17,8 +17,9 @@ module Gitlab
         return unless content
         all_names.each do |a_name|
-          content.gsub!(%r{/#{a_name} ?(.*)$}i, execute_block(action_block, context, '\1'))
+          content = content.gsub(%r{/#{a_name} ?(.*)$}i, execute_block(action_block, context, '\1'))
         end
+
         content
       end
     end

spec/lib/gitlab/legacy_github_import/release_formatter_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::LegacyGithubImport::ReleaseFormatter do

spec/lib/gitlab/legacy_github_import/user_formatter_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::LegacyGithubImport::UserFormatter do

spec/lib/gitlab/legacy_github_import/wiki_formatter_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::LegacyGithubImport::WikiFormatter do

spec/lib/gitlab/loop_helpers_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::LoopHelpers do

spec/lib/gitlab/manifest_import/manifest_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::ManifestImport::Manifest do

spec/lib/gitlab/manifest_import/project_creator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::ManifestImport::ProjectCreator do

spec/lib/gitlab/markup_helper_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::MarkupHelper do

spec/lib/gitlab/metrics/background_transaction_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::BackgroundTransaction do

spec/lib/gitlab/metrics/delta_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Delta do

spec/lib/gitlab/metrics/instrumentation_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Instrumentation do

spec/lib/gitlab/metrics/method_call_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::MethodCall do

spec/lib/gitlab/metrics/methods_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Methods do

spec/lib/gitlab/metrics/metric_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Metric do

spec/lib/gitlab/metrics/prometheus_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Prometheus, :prometheus do

spec/lib/gitlab/metrics/rack_middleware_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::RackMiddleware do

spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::RequestsRackMiddleware do

spec/lib/gitlab/metrics/samplers/influx_sampler_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Samplers::InfluxSampler do

spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 describe Gitlab::Metrics::Samplers::RubySampler do