Skip to content
Snippets Groups Projects
Commit ffee05c2 authored by Grzegorz Bizon's avatar Grzegorz Bizon
Browse files

Improve invalid build artifacts metadata path matcher

parent f80d7a86
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -43,6 +43,7 @@ module Gitlab
def match_entries(gz)
paths, metadata = [], []
match_pattern = %r{^#{Regexp.escape(@path)}[^/\s]*/?$}
invalid_pattern = %r{(^\.?\.?/)|(/\.?\.?/)}
 
until gz.eof? do
begin
Loading
Loading
@@ -50,7 +51,7 @@ module Gitlab
meta = read_string(gz)
next unless path =~ match_pattern
next unless path_valid?(path)
next if path =~ invalid_pattern
 
paths.push(path)
metadata.push(JSON.parse(meta.chomp, symbolize_names: true))
Loading
Loading
@@ -62,10 +63,6 @@ module Gitlab
[paths, metadata]
end
 
def path_valid?(path)
!(path.start_with?('/') || path =~ %r{\.?\./})
end
def read_version
gzip do|gz|
version_string = read_string(gz)
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment