#41341

Signed-off-by: Ashley Dumaine <adumaine@datto.com>

#41341

This essentially allows to pass both user and email, so that we can
either prefer the user to retrieve the avatar or (if user is not
present) fall back to the email lookup.

We want to drop the generic #avatar_icon helper that supports both an email
and a user object being passed in. Instead, we want to explicitly use the #avatar_icon_for_user
and #avatar_icon_for_email helpers depending on what we have at hand.
This allows us to avoid unnecessary database queries (e.g. call
User.find_by_any_email if we already have the user).

In situations like here, this makes it less convenient to use.

We need to keep the email lookup as we want to fall back to displaying
the gravatar result for a given email if the user does not exist.

Whenever we already deal with a User object, let's use the more specific
method avatar_icon_for_user.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/42928

The refs hash is used to determine what branches and tags have a commit
as head in the network graph. The previous implementation depended on
Rugged#references. The problem with this implementation was that it
depended on rugged, but also that it iterated over all references and
thus loading more data than needed if for example the project uses CI/CD
environments, Pipelines, or Merge Requests.

Given only refs are checked the network cares about the GraphHelper#refs
method has no need to reject those, simplifying the method.

Closes gitlab-org/gitaly#880

Closes #40755.

Fabio authored 7 years ago and Tim Zallmann committed 7 years ago

Resolve "Add a link to documentation on how to get external ip in the Kubernetes cluster details page"