Added the ability to see project deployments using a group cluster

This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.

Added a cluster domain wanring if no domain is defined

This reverts merge request !32400

This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.

This commit also unifies layout structure
and remove no_container flag

We're reversing the deprecation due to user feedback

- Adds CSS classes to represent browser & platform
- Adds JS flags to `gl` object to represent
browser & platform

The current default is too small
for a user to see what they have pasted in.

This commit adds a warning message that is always displayed that informs
users that their GitLab Pages sites will take a bit of time before they
can be accessed after being deployed for the first time.

- Use "results" instead of "blobs", "wiki blobs", "snippet blobs"
- Use "comments" instead of "notes"
- Use correct pluralization
- Don't add "1 - 10 of" if there's only one page

Previously submitting a DELETE request to an issuable URL would be
enough to destroy it, but this should require human confirmation.  We
now require that the `destroy_confirm` parameter is set to a truthy
value before this can complete.

In addition, we log a Sentry error if a deletion arrived without
confirmation.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62387

Fix missing .btn-success class on the following buttons:
* 'Create milestone' button
* Secondary button on profile tabs

`btn-create` was an old class which was was removed in !23232
and replaced with `btn-success`,
but these two seem to have been missed in the process.

Signed-off-by: Tao Wang <twang2218@gmail.com>
Signed-off-by: Rémy Coutable <remy@rymai.me>

Add E2E spec to test that issue closes with commit message

This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.

Igor Drozdov authored 5 years ago and Mayra Cabrera committed 5 years ago

- Extract MR fields for notes into a separate serializer
- Check if pipelines are empty via count

Previously, we called the `peek_enabled?` method like so:

    prepend_before_action :set_peek_request_id, if: :peek_enabled?

Now we don't have a `set_peek_request_id` method, so we don't need that
line. However, the `peek_enabled?` part had a side-effect: it would also
populate the request store cache for whether the performance bar was
enabled for the current request or not.

This commit makes that side-effect explicit, and replaces all uses of
`peek_enabled?` with the more explicit
`Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that
still sets `SafeRequestStore[:peek_enabled]` directly, because it is
contrasting behaviour with and without a request store enabled.

The upshot is:

1. We still set the value in one place. We make it more explicit that
   that's what we're doing.
2. Reading that value uses a consistent method so it's easier to find in
   future.

Only display time if the job has deployed

Update JS tests for displaying job deployment time

Simplify boolean check in deployedDate

Payton Burdette authored 5 years ago and Filipa Lacerda committed 5 years ago

Add changelog entry

Remove unnecessary test checking for form value

Translations updated for gitlab.pot

Use proper format on changelog entry

Jeremy Jackson authored 5 years ago and Jan Provaznik committed 5 years ago

This also restructures how and where the configuration for
Snowplow lives.

Only displays the todo body if the todo has a note.
This is to avoid redundant Issue or Merge Request titles
displayed both in the Todo title and body.

Peek's `Peek.request_id` method doesn't work well with a multi-threaded
server and concurrent requests, because requests can 'steal' another
request's ID, or unset it before it was due.

The upstream change resolves this; the commit here is just to ensure
that GitLab works with that upstream change, mostly by not using
`Peek.request_id` any more (as the method doesn't exist).

Make these templates for mail notifications for a new issue and a new
merge request more similar.

Also remove some leading whitespace in text mails.

Add qa selector elements and files from the EE branch

This will help prevent issues such as
https://gitlab.com/gitlab-org/gitlab-ce/issues/66449.

Due to indentation, the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31402 broke the
templating of Piwik script header.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66627

Jeremy Jackson authored 5 years ago and Mayra Cabrera committed 5 years ago

This reverts merge request !31826

Jeremy Jackson authored 5 years ago and Jan Provaznik committed 5 years ago

This also restructures how and where the configuration for
Snowplow lives.

Update show.html.haml

Scott Hampton authored 5 years ago and Mayra Cabrera committed 5 years ago

Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.

We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.

by adding the proper notification icon