Added the ability to see project deployments using a group cluster

The current default is too small
for a user to see what they have pasted in.

Only display the details of the cluster page when the cluster
exists. If it is in "creating" state, show a message and a spinner

Added the ability to update the namespace label text for gitlab-managed

Any resources created while the cluster was managed
will be untouched, allowing users to set/unset this
flag as they please.

Added a changelog entry for the feature

Signed-off-by: Rémy Coutable <remy@rymai.me>

Peter Leitzen authored 5 years ago and Bob Van Landuyt :neckbeard: committed 5 years ago

Tweak cluster helper and refactor its specs.

When this option is enabled, GitLab will create namespaces and service
accounts as usual. When disabled, GitLab wont create any project
specific kubernetes resources

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56557

Stop using `Rails.env.test?` in views.

In the new cluster forms, display form error messages
below form fields instead of a summary banner on top
of the form.

Include client side validation in order to display
user friendly error messages.

Also remove unnecessary placeholders.

This will allow to user the term managed? on
https://gitlab.com/gitlab-org/gitlab-ce/issues/56557. Managed? will be
used to distinct clusters that are automatically managed by GitLab

Displays Knative domain field automatically after Helm is successfully
installed.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56954

When ingress application is installed, the cluster domain help text
is updated to indicate that ingress external ip can be used as the
cluster domain

Use not_to instead of to__not

João Cunha authored 6 years ago and Jacques Erasmus committed 6 years ago

- extends presenters to include update endpoint path
- sends path to the client on clusters clusters show view.

The domain name setting was not doing anything (as far as I could tell).
Now we set the input and save the form. This was a regression introduced
in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24580/diffs

- Changes help text on clusters form to make it more explicit.
- Removes unnecessary warnings on auto devops form
- Simplifies cluster methods logic

- Fixes multiple typos on AutoDevops script
- Add an alias to Clusters::Cluster#domain as base_domain, so it's more
descriptive
- Removes unnecessary memoization on qa specs
- Changes migration to a post migration to deal better with traffic on
big instances (like gitlab.com)

Changes domain field to be on the Cluster page show, removing it from
Auto DevOps setting. Also injects the new environment variable
KUBE_INGRESS_BASE_DOMAIN into kubernetes#predefined_variables.

Migration to move the information from ProjectAutoDevops#domain
to Clusters::Cluster#domain. As well as necessary modifications to qa
selectors

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52363

gcp/show and user/show partial contain basically the same html elements
causing duplication.

The difference between the partials is that one of them has
html elements disabled if the cluster is managed. This MR aims to
remove that duplication by having just a single
show partial for both types

Modifies clusters form to display a disabled text field for environment
scope.

This changes is needed for https://gitlab.com/gitlab-org/gitlab-ce/issues/52363

https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8731

Include a new policy in Clusterables
(projects and groups), which checks if another cluster
can be added

clusterable_has_cluster? and multiple_clusters_available
private methods will be overriden in EE

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/34758

Given the note is about how to interpret ancestor clusters, use the
finder which actually knows if there are any ancestor clusters to find
out if the note should be shown, rather than passing the same info via a
view to a helper

Added note about Kaminari.paginate_array

Link to followup issue too

Part of the code such as #show_path is already present on the presenter.
Also avoid having code in two places (helper and presenter)

Sanitize and assert html_safe. Additional layer of defense - on top of
GitLab already requiring group names to be composed of small set of
chars A-Z, - and spaces.

Only link to cluster if user can read cluster

Make clear that arg is a GroupClusterablePresenter

Add more specs for completeness

Mayra Cabrera authored 6 years ago and Thong Kuah committed 6 years ago

- Use sprite_icon instead of hardcoded html
- Use a more descriptive method name
- Changes specs to use html_safe matcher

Mayra Cabrera authored 6 years ago and Thong Kuah committed 6 years ago

- Moves logic into ClustersHelp
- Add CSS to ensure compatibility with EE view.