Skip to content
Snippets Groups Projects
  1. Feb 24, 2020
  2. Nov 21, 2019
  3. Oct 23, 2019
    • Dylan Griffith's avatar
      Change Note#to_ability_name to 'note' · 0df265b6
      Dylan Griffith authored
      This is to be more consistent as there is already a :read_note policy in
      NotePolicy. To keep other behaviour the same we've introduced a
      Note#noteable_ability_name that is used anywhere this was expected.
      0df265b6
  4. Sep 30, 2019
  5. Sep 23, 2019
  6. Jul 10, 2019
  7. Jun 14, 2019
    • Bob Van Landuyt's avatar
      Expose comments on Noteables in GraphQL · b6ff5f1e
      Bob Van Landuyt authored
      This exposes `Note`s on Issues & MergeRequests using a
      `Types::Notes::NoteableType` in GraphQL.
      
      Exposing notes on a new type can be done by implementing the
      `NoteableType` interface on the type. The presented object should
      be a `Noteable`.
      b6ff5f1e
  8. Feb 13, 2019
  9. Feb 06, 2019
  10. Jul 26, 2018
  11. Jun 21, 2018
  12. Dec 07, 2017
  13. Oct 07, 2017
  14. Jul 21, 2017
  15. Jun 01, 2017
  16. May 31, 2017
  17. May 29, 2017
  18. Apr 07, 2017
  19. Apr 06, 2017
  20. Apr 05, 2017
  21. Dec 05, 2016
    • Bob Van Landuyt's avatar
      Feature: delegate all open discussions to Issue · 1123057a
      Bob Van Landuyt authored
      When a merge request can only be merged when all discussions are
      resolved. This feature allows to easily delegate those discussions to a
      new issue, while marking them as resolved in the merge request.
      
      The user is presented with a new issue, prepared with mentions of all
      unresolved discussions, including the first unresolved note of the
      discussion, time and link to the note.
      
      When the issue is created, the discussions in the merge request will get
      a system note directing the user to the newly created issue.
      1123057a
  22. Nov 28, 2016
  23. Nov 25, 2016
    • hhoopes's avatar
      Add keyword arguments to truncated_diff method · a761c59a
      hhoopes authored
      * Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
      * Tweaked templates for consistency and format appropriateness
      a761c59a
    • hhoopes's avatar
      Change diff highlight/truncate for reusability · f928dba9
      hhoopes authored
      Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.
      
      Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
      f928dba9
  24. Sep 06, 2016
  25. Aug 19, 2016
  26. Aug 17, 2016
  27. Aug 16, 2016
  28. Aug 12, 2016
  29. Aug 02, 2016
    • Paco Guzman's avatar
      Speedup DiffNote#active? on discussions, preloading noteables and avoid... · 8716ff7f
      Paco Guzman authored
      Speedup DiffNote#active? on discussions, preloading noteables and avoid touching git repository to return diff_refs when possible
      
      - Preloading noteable we share the same noteable instance when more than one 
      discussion refers to the same noteable.
      - Any other call to that object that is cached in that object will be for any 
      discussion.
      - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that 
      diff_refs using directly those sha instead accessing to the git repository to first get the 
      commits and later the sha.
      8716ff7f
  30. Jul 29, 2016
  31. Jul 27, 2016
  32. Jul 26, 2016
Loading