Skip to content
Snippets Groups Projects
  1. May 30, 2019
  2. May 28, 2019
  3. May 27, 2019
    • Kerri Miller's avatar
      Reject slug+uri concat if slug is deemed unsafe · f383ad62
      Kerri Miller authored
      First reported:
        https://gitlab.com/gitlab-org/gitlab-ce/issues/60143
      
      When the page slug is "javascript:" and we attempt to link to a relative
      path (using `.` or `..`) the code will concatenate the slug and the uri.
      This MR adds a guard to that concat step that will return `nil` if the
      incoming slug matches against any of the "unsafe" slug regexes;
      currently this is only for the slug "javascript:" but can be extended if
      needed. Manually tested against a non-exhaustive list from OWASP of
      common javascript XSS exploits that have to to with mangling the
      "javascript:" method, and all are caught by this change or by existing
      code that ingests the user-specified slug.
      f383ad62
  4. May 24, 2019
  5. May 23, 2019
  6. May 22, 2019
  7. May 21, 2019
  8. May 20, 2019
  9. May 19, 2019
  10. May 06, 2019
    • Mark Chao's avatar
      Validate MR branch names · d27353be
      Mark Chao authored
      Prevents refspec as branch name, which would bypass branch protection
      when used in conjunction with rebase.
      
      HEAD seems to be a special case with lots of occurrence,
      so it is considered valid for now.
      
      Another special case is `refs/head/*`, which can be imported.
      d27353be
  11. May 03, 2019
  12. May 01, 2019
  13. Apr 30, 2019
  14. Apr 29, 2019
  15. Apr 26, 2019
Loading